From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933037AbcGENDt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jul 2016 09:03:49 -0400
Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45776
	"EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932812AbcGENDT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jul 2016 09:03:19 -0400
Subject: Re: [PATCH] arm64: dts: Fix rtc by providing rtc_src clock
To: Alim Akhtar <alim.akhtar@samsung.com>,
        linux-arm-kernel@lists.infradead.org
References: <1467713107-15932-1-git-send-email-alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, catalin.marinas@arm.com,
        linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        k.kozlowski@samsung.com, pankaj.dubey@samsung.com
From: Javier Martinez Canillas <javier@osg.samsung.com>
Message-ID: <caea8f78-be5e-233f-c475-41c2973761ae@osg.samsung.com>
Date: Tue, 5 Jul 2016 09:03:02 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <1467713107-15932-1-git-send-email-alim.akhtar@samsung.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Alim,

On 07/05/2016 06:05 AM, Alim Akhtar wrote:
> Add rtc source clock as exynos7 needs source (32.768KHz) clock
> for rtc block. Without this currently rtc driver probe is broken
> on this SoC, thats because rtc-s3c driver expect rtc_src clock to
> be provided for _s3c6410-rtc_ type rtc controllers.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index 03f9cf6..7f48cf0 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -12,6 +12,7 @@
>  /dts-v1/;
>  #include "exynos7.dtsi"
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/clock/samsung,s2mps11.h>
>  
>  / {
>  	model = "Samsung Exynos7 Espresso board based on EXYNOS7";
> @@ -44,6 +45,8 @@
>  
>  &rtc {
>  	status = "okay";
> +	clocks = <&clock_ccore PCLK_RTC>, <&s2mps15_osc S2MPS11_CLK_AP>;
> +	clock-names = "rtc", "rtc_src";
>  };
>  
>  &watchdog {
> 

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America