From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 183CB2206A7; Fri, 7 Nov 2025 19:01:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762542105; cv=none; b=iFeAAW1Dokdib4yE4SlurXHeogCSTtvgzXKRIlFs15xB4kpHz7OlF6mq1N+J1QlprbkMqah+jWGNMfKlchxwGuw14+YFDieBUL7vSZjmY3pA7tr1RORHO1vrUYzkPUJ7hQcMcVvTXcw8Q42u9skjSDGg6wJRIY1m29G3c6MTOYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762542105; c=relaxed/simple; bh=UF2IWmAQDO1X410z/PEbaUPD3GkoRYJG5/Gzv8WH+zA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u33c/TtJaj+c9Ua69RqfmD1IYsN1sj1XvsEBzdjSnJx2u3mI3fa4Q01dHBe6glvXA6C/FErloM1tZGgFsIAt33vPRWlAarwff79OIvZY39R1vzpUspCdfNVez1EQ4Vpn9qpSFwJ6LjgMIZXOXcs551sj7VUXLyvmOWPmyyWoYoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Vm/vdScp; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Vm/vdScp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=dmnU+NL/eOaWWwyUapILw4TvGX9F7hjLcTmUpXNjT/k=; b=Vm/vdScphQjeXHY9UIUIfdxx0g 5Ab7Zw42SRbmBnh8WFIlTdvmz5p65Nt+neQW1u5YxD/gh7WtR2PkS/YuETgQCF55hhc72sSOzY9UN e5zBKjNC4rPDMsnMU32yoH7wqWjcB3XPbhbnzFGW9L4SlK9iwO2gNIJH0QK9DUxfViiQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vHRi1-00DGHz-DH; Fri, 07 Nov 2025 20:01:17 +0100 Date: Fri, 7 Nov 2025 20:01:17 +0100 From: Andrew Lunn To: "Lad, Prabhakar" Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Horatiu Vultur , Geert Uytterhoeven , Vladimir Oltean , Vadim Fedorenko , Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar Subject: Re: [PATCH net-next] net: phy: mscc: Add support for PHY LEDs on VSC8541 Message-ID: References: <20251106200309.1096131-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <2dabb0d5-f28f-4fdc-abeb-54119ab1f2cf@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Certainly the probes can be simplified into a single function. I'll > create a patch for this. Please do make sure of each device having its own .probe pointer. Don't have one probe function with lots of if/else clauses. Put what is device specific into a device specific probe, and what is common into helpers. > > Also, is the LED handling you are adding here specific to the 8541? If > > you look at the datasheets for the other devices, are any the same? > > > Looking at the below datasheets the LED handlings seem to be the same. That is common. So yes, please add it to them all. It does not matter if you can only test one device. Andrew