From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B600CC48BE8 for ; Tue, 15 Jun 2021 03:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2B9961403 for ; Tue, 15 Jun 2021 03:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbhFODWJ (ORCPT ); Mon, 14 Jun 2021 23:22:09 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4909 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230017AbhFODWI (ORCPT ); Mon, 14 Jun 2021 23:22:08 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G3s0r4QBGz6yrZ; Tue, 15 Jun 2021 09:58:20 +0800 (CST) Received: from dggpeml500020.china.huawei.com (7.185.36.88) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 10:01:23 +0800 Received: from [10.174.177.174] (10.174.177.174) by dggpeml500020.china.huawei.com (7.185.36.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 10:01:22 +0800 Subject: Re: [PATCH -next] drm/nouveau:disp: Remove set but not used variable 'ret' To: , , , , , , , , CC: , , , References: <20210515090155.186083-1-libaokun1@huawei.com> From: "libaokun (A)" Message-ID: Date: Tue, 15 Jun 2021 10:01:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210515090155.186083-1-libaokun1@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.174] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500020.china.huawei.com (7.185.36.88) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping 在 2021/5/15 17:01, Baokun Li 写道: > From: "libaokun1@huawei.com" > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function 'nv50_mstm_cleanup': > drivers/gpu/drm/nouveau/dispnv50/disp.c:1389:6: warning: > variable ‘ret’ set but not used [-Wunused-but-set-variable] > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function 'nv50_mstm_prepare': > drivers/gpu/drm/nouveau/dispnv50/disp.c:1413:6: warning: > variable ‘ret’ set but not used [-Wunused-but-set-variable] > > It never used since introduction. > > Signed-off-by: Baokun Li > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > index 1c9c0cdf85db..5ee3f1fc76d7 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -1386,12 +1386,10 @@ nv50_mstm_cleanup(struct nv50_mstm *mstm) > { > struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev); > struct drm_encoder *encoder; > - int ret; > > NV_ATOMIC(drm, "%s: mstm cleanup\n", mstm->outp->base.base.name); > - ret = drm_dp_check_act_status(&mstm->mgr); > - > - ret = drm_dp_update_payload_part2(&mstm->mgr); > + drm_dp_check_act_status(&mstm->mgr); > + drm_dp_update_payload_part2(&mstm->mgr); > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) { > @@ -1410,10 +1408,9 @@ nv50_mstm_prepare(struct nv50_mstm *mstm) > { > struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev); > struct drm_encoder *encoder; > - int ret; > > NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name); > - ret = drm_dp_update_payload_part1(&mstm->mgr); > + drm_dp_update_payload_part1(&mstm->mgr); > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {