From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>,
<davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: ATMEL MACB ETHERNET DRIVER
Date: Wed, 8 Jul 2020 13:01:51 +0200 [thread overview]
Message-ID: <caf7b073-a254-44a9-9466-b919b03596cf@microchip.com> (raw)
In-Reply-To: <20200708103519.13915-1-grandmaster@al2klimov.de>
On 08/07/2020 at 12:35, Alexander A. Klimov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
The links go to Cadence. If people from Cadence want to change
something, don't hesitate to speak out. On my side:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely or at least not HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See: https://lkml.org/lkml/2020/6/26/837
>
> If you apply the patch, please let me know.
>
>
> drivers/net/ethernet/cadence/macb_pci.c | 2 +-
> drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c
> index 617b3b728dd0..cd7d0332cba3 100644
> --- a/drivers/net/ethernet/cadence/macb_pci.c
> +++ b/drivers/net/ethernet/cadence/macb_pci.c
> @@ -2,7 +2,7 @@
> /**
> * Cadence GEM PCI wrapper.
> *
> - * Copyright (C) 2016 Cadence Design Systems - http://www.cadence.com
> + * Copyright (C) 2016 Cadence Design Systems - https://www.cadence.com
> *
> * Authors: Rafal Ozieblo <rafalo@cadence.com>
> * Bartosz Folta <bfolta@cadence.com>
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
> index 43a3f0dbf857..31ebf3ee7ec0 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -2,7 +2,7 @@
> /**
> * 1588 PTP support for Cadence GEM device.
> *
> - * Copyright (C) 2017 Cadence Design Systems - http://www.cadence.com
> + * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
> *
> * Authors: Rafal Ozieblo <rafalo@cadence.com>
> * Bartosz Folta <bfolta@cadence.com>
> --
> 2.27.0
>
--
Nicolas Ferre
next prev parent reply other threads:[~2020-07-08 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 10:35 Alexander A. Klimov
2020-07-08 11:01 ` Nicolas Ferre [this message]
2020-07-08 17:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf7b073-a254-44a9-9466-b919b03596cf@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=davem@davemloft.net \
--cc=grandmaster@al2klimov.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®