From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: aviad.krawczyk@huawei.com, davem@davemloft.net
Cc: netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] net: huawei: hinic: a possible sleep-in-atomic-context bug in msg_to_mgmt_async
Date: Fri, 11 Jan 2019 10:32:25 +0800 [thread overview]
Message-ID: <cafbb5d2-1a35-cd7b-1604-0125e42c403c@gmail.com> (raw)
The driver may sleep in an interrupt handler.
The function call path (from bottom to top) in the directory
"drivers/net/ethernet/huawei/hinic/" in Linux-4.17 is:
[FUNC] down
hinic_hw_mgmt.c, 324: down in msg_to_mgmt_async
hinic_hw_mgmt.c, 408: msg_to_mgmt_async in mgmt_recv_msg_handler
hinic_hw_mgmt.c, 464:mgmt_recv_msg_handler in recv_mgmt_msg_handler
hinic_hw_mgmt.c, 484: recv_mgmt_msg_handler in mgmt_msg_aeqe_handler
hinic_hw_eqs.c, 264: [FUNC_PTR]mgmt_msg_aeqe_handler in aeq_irq_handler
hinic_hw_eqs.c, 355: aeq_irq_handler in eq_irq_handler
hinic_hw_eqs.c, 383: eq_irq_handler in ceq_tasklet
Note that [FUNC_PTR] means a function pointer call.
This bug is found by my static analysis tool (DSAC-2) and checked by my
manual code review.
I do not know how to correctly fix this bug, so I just report it.
A possible way may be to replace up() and down() with spin_lock() and
spin_unlock().
Best wishes,
Jia-Ju Bai
reply other threads:[~2019-01-11 2:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cafbb5d2-1a35-cd7b-1604-0125e42c403c@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=aviad.krawczyk@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®