From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05998374195 for ; Fri, 7 Aug 2026 14:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786111936; cv=none; b=R0WKSrQHxLKfPLK9J7+P/mG4PcHU8Tao6x2vX3pE/stATic+7QRq+hTV1Es6CGqTWWm/fJgqKNoAkiq1YFSEO78vZYalNE4+GXG5M6N8uCuLAnS5Ayrt8WGAmaOixCzvc8fJlcpCGrxytgfVN2jX1h2xPZ8wlvd/QBV1x9tHX8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786111936; c=relaxed/simple; bh=iLv1tIWivF/5I8UWLwGD3GmhFGyyrMYA0OYvkAJZvPQ=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=GNy3dgi+Fu6C0jBqhSWcJgM2RGgHdL2SbnuJHTeXFRUciTkMvE4NYoO/hcQeFcBnzu4sBNMzc7lJdaF4BNS3xKCcMMKbAm0YRNJnfuukZqDLHmjfknpETmOuFN8Wh2jUIzFq1R6IfA7q6BNZ+y/4VlY9OjCMoM8cUxKr/dm+Ucw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hXDDSzFg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cSHGrGw4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hXDDSzFg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cSHGrGw4" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 677De8Cw1434610 for ; Fri, 7 Aug 2026 14:12:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1lQfzcT+hJ0DElVppqFC5o4kaK+gwF6cwSUj8RWciT0=; b=hXDDSzFgehrFqywV KHi0sC5tBXTP3V9HuH/wkAHvcpyItE6xp72u74HgMRELZjKSBD/MT828rctQePpR znX7M/PvORhA6r2V4MAfUrXqIjzgAHOlD+DtDyOJ+JhAGalJqNva9dI+QYy5jK9B Ew7gufOXg6nlI9NLUlo37g/BwnxEe6YvdU5v8+I+v2GYaAqb5o57VZLASvHTY/qG Sw216VBvx8+oTu+F6wxrFaL0CxZeUjNeLr1Gi+AqafVcBuc+VaMBTW2FFTwN1ZGk vhk1l21I3p8nj7S0ojidsf6O9CDwtvytDoF2GQMJFxByZ1INm1nOZ6MGR7XAoNwK FMWjPA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fwgewg4cv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 14:12:10 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-381250979d5so3547216a91.0 for ; Fri, 07 Aug 2026 07:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786111930; x=1786716730; darn=vger.kernel.org; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:from:to:cc:subject:date:message-id:reply-to:content-type; bh=1lQfzcT+hJ0DElVppqFC5o4kaK+gwF6cwSUj8RWciT0=; b=cSHGrGw4SzwCZPhxfwzTQOrG2OZUmW/ZrPK7zAfYTnGu0d5qoJoo9qMuWpNv3bZJEN tm6A1+5gQWGGHK5pPzqiImL37QXu8rB0gFYC0RDBXutvXeJilk8pNiwNaNJJ91g0aXZp WGcpoIsh0l+oN6af0oEXshQ5YQUjIQQPGWLmJnTII5EUnJDFHoYMEDGvGBQKihy3P0Z/ eC62LDPgxwiRkXEnEFAgzrXqoVjJUEvg3QzLp1MusTKkmRs9C7PzOvuLiwPcD4t+tdUK bOHbPm9mPsepkqu7GlD4zXK9KwWOIJgDhac42bCy71s18we+9+AiLIFJym3SuNaDg+0D BUEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786111930; x=1786716730; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1lQfzcT+hJ0DElVppqFC5o4kaK+gwF6cwSUj8RWciT0=; b=HNTd4fCJ/L8hldDLjyzMyHIai0NCWzend+IHO7RZCpcRPHP91G+6k+8Qr4KPVpiZ1d 2F2Fi7VH9T9fxSbsgH8DJRhkGBmbl7QUzgaQcwyUCUZF33YtoP/sWNBUizQgKD+mkh3p YMGnJlMIQizGjI1KCi/0Pm5nUERMerPFaC/xVLFAb5H364HPLQLr27MlWAPy57p/wW5p gfMZYFXsoFvpEg9FEBdaXzJZHoe0Jf0QN6KBIancT7JzO6medbmQGdU93vNZKHbU9u7F N2cg7CpiPfbVtHbTkWYLz34sTkn0A+LzOK6ASU1Mr5vuPpX+ATY+iiBscOc37Ss/GPl3 Y+eA== X-Forwarded-Encrypted: i=1; AHgh+Rq27IV6xDWqp60qTn0/VQDIklNvWbSmp+EyXKxz4w+vR8y9DSvYJG2MkaMSE9cJv19hgWR1+xzPbpqbM9g=@vger.kernel.org X-Gm-Message-State: AOJu0YwUCopoQksAuHrBcFDjtmJX9kHu08rLheJ6pH0FA74JIEbaokRl 7RdE2ucNCgICge0UTW8jf/EdoFeCzTw/CRz8BZX++QirOuQNLM3UGsMjFj9yhUYDGYuSkpEp1W5 Hto+JvwZ0ITEjxpikc18MbpF2YMTPout8Xb4Pf3MfkQlrWAJDobd3N8e9hQhb9adGSco= X-Gm-Gg: AR+sD13u0t+tzDIOKpZ4p6oSAxybNdBgSboEx7w4R57oIV3FQFjV/jJbY+4yUzV9kTn uiHwLDpeyl4u3YhqKcMcvqtPH9T62RAyHRJ+xFTXIHVAy/SQSrlS4Q18sRhbACH8gre3H6rXSL3 AKecUeYTZf9yFgOPdGkDKOy6L2HjtBQEbsQhnaVvbhjjRDSnSmwkEU3p0enPU8Qpu/jztEBYrzv xCenlFJTL1+d2IS0dWsnpx8+XL7Vr3P5gd1gl86VQqGrMqdT/gLJLg4c5kasdHGdlkhopVavaaf Z/pf0XHODYZTnEi/3sM/2yMS+Z5IPzgHnhB5z1qW2Li6rjGzUECh+Qkq+GubPWK/F1FxbPpeMw8 /qtkLGnufMVTVMLctzl7AQQMx5gmqcQ== X-Received: by 2002:a17:90b:562f:b0:38e:7168:281 with SMTP id 98e67ed59e1d1-3928237024cmr32324a91.10.1786111929650; Fri, 07 Aug 2026 07:12:09 -0700 (PDT) X-Received: by 2002:a17:90b:562f:b0:38e:7168:281 with SMTP id 98e67ed59e1d1-3928237024cmr32235a91.10.1786111929116; Fri, 07 Aug 2026 07:12:09 -0700 (PDT) Received: from [192.168.29.77] ([49.43.219.187]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95c40sm2937567a91.8.2026.08.07.07.12.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 07:12:08 -0700 (PDT) Subject: Re: [PATCH v6 1/2] mmc: Allow host driver to control the re-programming of crypto keys To: Dmitry Baryshkov Cc: ebiggers@kernel.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, quic_dmukhopa@quicinc.com, quic_rampraka@quicinc.com, quic_nitirawa@quicinc.com, quic_sachgupt@quicinc.com, quic_bhaskarv@quicinc.com, quic_gaurkash@quicinc.com, quic_sartgarg@quicinc.com, ram.gupta@oss.qualcomm.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260803163123.1802005-1-neeraj.soni@oss.qualcomm.com> <20260803163123.1802005-2-neeraj.soni@oss.qualcomm.com> From: Neeraj Soni Message-ID: Date: Fri, 7 Aug 2026 19:42:01 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDExMSBTYWx0ZWRfX4ye2vZC5fs40 xItL6c48du4RSzQdS1HTajIDy1mL1mxLjP5pHHC73JJd8YGUgyhVmEWHKYXKOTvDgb7BouPVFXA x+bt4jJIbi9wjnyRfM3+zplX8n0Bvno= X-Authority-Analysis: v=2.4 cv=N5cZ0W9B c=1 sm=1 tr=0 ts=6a75e7ba cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=1azyIadIo70wB74QPeCPrg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=JFn_MUE5eIINXpBiEhIA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: GwbT2Y8-nD34HjhxkXdxPA5Buv3gR6hV X-Proofpoint-ORIG-GUID: GwbT2Y8-nD34HjhxkXdxPA5Buv3gR6hV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDExMSBTYWx0ZWRfX9OO4b7WjYgZe XexS51XZeT5OQ/UYMP0nEPVgns4BaJ784JRaV3IzKDoCb6ooGxGMIayvgdP49S/E12ulGXoBUsB /drwPxhoGGEzBjMKFK3IQKQ5azJ/ys3dUPD/kNFhlAiYSWtxH0FsWl1qHeesvP3yaxxi303x7w8 KUAZTqmzMsdJs5r2aM8iDHzEFcAbIvQ9Q4jlxg99Y0Fmd+vX74CSkmlQ1YESuNM8NAGB15xai7j f8IlOx7RZw7uabvfOxZSE3FjewujlzUIcO+ffwV2dV4JfI6qVG2Nok5Qjb8jJ1SmmFy8kWpp1yM wVKyB1dTMlvUwFk1KeFAQ8KX3dNxLStTfkuZ14VjJqGWPsujVp41vwVG48INJDfkaMyeakEBOGk Ca7+wlZ5coEInsuTVSEuLsZdNmK3XkKXh5aiUEE5en7fBBw3P8csP4wtF8aYXXcIhvXkaqH7KgG 9eF6i9XfGOxVd98Q88Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_02,2026-08-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070111 On 8/3/2026 11:42 PM, Dmitry Baryshkov wrote: > On Mon, Aug 03, 2026 at 10:01:22PM +0530, Neeraj Soni wrote: >> The register context for the crypto profile belongs to the >> sdhci/cqhci host and not the mmc card, hence re-programming should be >> managed by the host driver itself. > > Don't you have a reference to the host in the function? >Yes there is no direct reference avaialble to the host in this function. >> >> Add the flag MMC_CAP2_CRYPTO_NO_REPROG as part of host->caps2 to control >> reprogramming keys to crypto engine for SoCs which do not require this >> feature. >> >> Signed-off-by: Seshu Madhavi Puppala >> Co-developed-by: Ram Prakash Gupta >> Signed-off-by: Ram Prakash Gupta >> Co-developed-by: Sarthak Garg >> Signed-off-by: Sarthak Garg >> Signed-off-by: Debraj Mukhopadhyay >> Signed-off-by: Neeraj Soni >> --- >> drivers/mmc/core/crypto.c | 2 +- >> include/linux/mmc/host.h | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/core/crypto.c b/drivers/mmc/core/crypto.c >> index fec4fbf16a5b..a5a90bfc634e 100644 >> --- a/drivers/mmc/core/crypto.c >> +++ b/drivers/mmc/core/crypto.c >> @@ -15,7 +15,7 @@ >> void mmc_crypto_set_initial_state(struct mmc_host *host) >> { >> /* Reset might clear all keys, so reprogram all the keys. */ >> - if (host->caps2 & MMC_CAP2_CRYPTO) >> + if ((host->caps2 & MMC_CAP2_CRYPTO) && !(host->caps2 & MMC_CAP2_CRYPTO_NO_REPROG)) >> blk_crypto_reprogram_all_keys(&host->crypto_profile); >> } > Regards Neeraj