From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] md-linear: use struct_size() in kzalloc()
Date: Tue, 29 Jan 2019 11:22:54 -0600 [thread overview]
Message-ID: <caff2263-fb7d-257c-f7f2-cca6c537f597@embeddedor.com> (raw)
In-Reply-To: <CAPhsuW7a_F_K1cJdrGHLhnuCdpeN365n1BG-QawmxKWaZajGeA@mail.gmail.com>
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 1/7/19 5:01 PM, Song Liu wrote:
> On Mon, Jan 7, 2019 at 10:35 AM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> One of the more common cases of allocation size calculations is finding the
>> size of a structure that has a zero-sized array at the end, along with memory
>> for some number of elements for that array. For example:
>>
>> struct foo {
>> int stuff;
>> void *entry[];
>> };
>>
>> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
>>
>> Instead of leaving these open-coded and prone to type mistakes, we can now
>> use the new struct_size() helper:
>>
>> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Acked-by: Song Liu <songliubraving@fb.com>
>
>> ---
>> drivers/md/md-linear.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
>> index d45c697c0ebe..5998d78aa189 100644
>> --- a/drivers/md/md-linear.c
>> +++ b/drivers/md/md-linear.c
>> @@ -96,8 +96,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
>> int i, cnt;
>> bool discard_supported = false;
>>
>> - conf = kzalloc (sizeof (*conf) + raid_disks*sizeof(struct dev_info),
>> - GFP_KERNEL);
>> + conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
>> if (!conf)
>> return NULL;
>>
>> --
>> 2.20.1
>>
next prev parent reply other threads:[~2019-01-29 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 17:45 Gustavo A. R. Silva
2019-01-07 23:01 ` Song Liu
2019-01-29 17:22 ` Gustavo A. R. Silva [this message]
2019-01-29 22:10 ` Song Liu
2019-01-29 22:18 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caff2263-fb7d-257c-f7f2-cca6c537f597@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®