From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95162777FD for ; Mon, 26 Jan 2026 14:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769438693; cv=none; b=t1xltOtfKGDgPmEnBr9kniD0Czrx3Q9qAJYKlRm3WVRfqAZEwXgFBWMR61sUHP7YL1/wCeEl0O69FZhUm4SMBF87xDnQmDF8aCyK4etzD37p1Fkmkx2Q4IhV0TknAIP+VvCgGoYo5cEbCdRR+L6xP7FUIP5fEAnSSXSVDzVkiUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769438693; c=relaxed/simple; bh=GP7PmySZu/+TZ+vSZUM4nmTzVvZnKwy0kC00wxVH4BU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=baBdHtyUxqy7/DE4Z1M3Yk4zwMvgIarxXtl3KMtqP+a8ubQWYCy2lVLr9FidN6ZtV85CGp4wjFdxCZv1duIx3pFJI4I6s5ao7Hm2mNv1w7V9avzDc2C70JSjNaxRTlcGSwMuniAxKS52e5P0fB6h8y0g7o4DfrAe0CtZUk2qgEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DOuiefEh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N1ow8MsF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DOuiefEh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N1ow8MsF" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60Q7eojg3419777 for ; Mon, 26 Jan 2026 14:44:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ApTr57Y0vLLo1N1yQrHIjnvTHUoSt+xQRfNJVnUPykM=; b=DOuiefEhfL8uj7wz 8Z3bwdWYhRF3YqHWN8XG9U6OeauL0vpZlTz8Im9pjNWxBCE7R/CGHa/vgOlmH6wb Qrpb4Ne8X50xPZggW52zpLvUpHfFvLUYl7KYfdAs+geRYyDgn88gfqcW7vR+MRut /Z2/QEKHNqZxb0LcMmdPfK0ZjcyFPOiJK9v1gKA/PECBzFf6HcCOAyeKKHkXUNMJ bUs0TAo5VN1vmkVlMkEM7V9cqR/0GAIGPWvZjMxvdJVAZBcHq1DRTnm5yBZNLRdu kaRZY//+AaxrBT/5xARL5m3rlxc8ZLK3bkFNHLE92eE5uX8ye26HS4zg3tFfMFQm r1nAkQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bvq24msmd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 14:44:50 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-501506ff58fso13632811cf.1 for ; Mon, 26 Jan 2026 06:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769438690; x=1770043490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ApTr57Y0vLLo1N1yQrHIjnvTHUoSt+xQRfNJVnUPykM=; b=N1ow8MsFzpwGsSRDmaBuyFZ4rSw1A8Rbud5/dOPJzTHXj72ko9zKpGsGosBJRSYG0J weVboGs4RqMsP+w+HfzO5/ITU817AFbF9ZECrXYpQdlc6Opt4O8qPXNgU9hEotMkfx0s Tt8h3S/WeBuUS31l658BNGUathNjnGlh1b1uO0Xd34BJmsLueQEh5EubA8iO30ydGyP3 LsY7aNVemzlOSyq42UWmHAVxpIAHGsYCB2pSu8fiTrAemYm0PHyJ9Nm6jHRMqZc6LKTf cj+rIisCMO5t7DH/8kTcDAtHIuTAMvESfOWYnZzZGvbNKhIM3wqFcatRD5W/fNBV9V7K 9RyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769438690; x=1770043490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ApTr57Y0vLLo1N1yQrHIjnvTHUoSt+xQRfNJVnUPykM=; b=BoBDDjamK16bgU9t9/M9LyEVAWsMGers9NuMHGV3RnW2w5XuR4afYqEuwIof2TSOJL /5CFaQzG59J6Ge+iVOUt+yCxm9qJWz2gNeDhaEvgFCFPk43uV0yGxDQrPZpr8JirlGX0 /0/xn7BAUISgc+6cRBmCOTZGSBejtaSv6LrVsLEUt7Iodlk/JUtETPj4XyQypQ9aHZV0 Q8oegReL3Rv93nb1PKfmEP+vts6EV4m4K1hlYu/EoUQu/K+O3UIuNhajbYREePcLHWSb QpXwih3bKTXLrKrQGejY4vf5snevPH9TifwqYdx5rAB0BPwzLpj1E5xKxA4UdLdlTd1Y iSVw== X-Forwarded-Encrypted: i=1; AJvYcCWbdCt+yjredq3cKdS5BrBxI9X5/+bc93disDX4vG0f1I8Jp/LKk3uQA9di7+n/ZWERf2QfSR+3hin28KU=@vger.kernel.org X-Gm-Message-State: AOJu0YwOZ2OiPUVwdTQz5ApNiHmQK48j5zHPhjXsrBMUyBeQIK91h2+0 5FB60H9GjQHBtBIKIeVIlDxLDtB1JHMhXUC9kA20mzGgbmF2zU9meB8h6CF9jZzFKg6mGQ3800T q9DzIqo+HurJK03JkyPNLTEZuG63hTmNnbaCEzohh5Z73LYjIY39Xzzor5IHcCaaAQV8= X-Gm-Gg: AZuq6aKBX3ey6ujem8ybgA4mWGRMeFi78uemNk6HG1eoeD6lhZ+KXv8b0nxqaO5i8eV UCwiqgJsn4Z6ku0LjfI5n97myKuZsr8VCWAem10xPMBY4/LJgbIzdHjfWshSfsEy21FTR/Oeicu gYuDTMJm+sa1XVUJqbJTTFMOUvkXhbZcBdTBC4C40txXdWS1Hx9clkLeZ8vnLs4XC7mYEhVjuUF zTvqHT+gzMhjLSsE1eENTLJ76HTIksmtsHXPUzHa8+axV3V6V7RwY4In0Ap2NdwZgsbFsJtSguf AEDOihM/55WucdK3anuOHIF0YjbCSjbe8y1X/451cV4MfXEPVbhMXD8YK8oNFNBRYDxU7+S0xSq V14sPhp1ENuctKX5IRDG8+9MTO4Pd31gdkIhJLcQ1VDBqgEi7tzk2v9DvsZTATG+jMCs= X-Received: by 2002:ac8:5814:0:b0:4e0:b24a:6577 with SMTP id d75a77b69052e-50314b66890mr46542671cf.2.1769438690127; Mon, 26 Jan 2026 06:44:50 -0800 (PST) X-Received: by 2002:ac8:5814:0:b0:4e0:b24a:6577 with SMTP id d75a77b69052e-50314b66890mr46542211cf.2.1769438689603; Mon, 26 Jan 2026 06:44:49 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6584b948670sm5141354a12.25.2026.01.26.06.44.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 06:44:48 -0800 (PST) Message-ID: Date: Mon, 26 Jan 2026 15:44:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/3] arm64: dts: qcom: glymur: Add USB related nodes To: Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng , Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Wesley Cheng References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> <01de4054-eebf-4ef3-ad74-c806b208a848@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDEyNiBTYWx0ZWRfX75OzAvfKdppF g/wq5HV+Yd0wm7Gz4+eo8xAeUhFPBDrzL3ydMpBmnWgRBuvnx9XPmWDl33hBLrJz/pwBTB75V9L g9HbsSLHnszW1Lotd0lN+F4/1xUpfeChmz4Zg9hORbkCbgIdbcjK36J9VQE0IXSXS+/pCr4ZR5c 0NokJnTIevvJqnwvzZzg1uTJEU80nOOdFeGTtUHugIz6lCXw/Slx78Up8XUZ2kVRGRb49MdlIKH bQazrV/MyrfRkeWyEqRVtqNx2NgmTM9NXPiKu13flV+U1ZqyTl66E+sdrFbesMg3vtTTkJO+KEK uQn7idWd1purnQJ/YWcQ4S28TFzu4Zfs2VTYedxviCNSpA495K2H8FVzSPc/OCmoF7N/pCQSg1m TpVh6XpUOAdIoFjsy+N1lutkAtt5b7361wgyomDWjPfybCqcI+QVlGqnjkjs8HPS1WoLjKtW2ZE ZgYt+D6HVkUgxZOUDAw== X-Authority-Analysis: v=2.4 cv=EsXfbCcA c=1 sm=1 tr=0 ts=69777de2 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=qn_fkN7zqQ4dxzFuYcEA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: mqzhWXs3Sx7kAh1R0VF1R5Kovle8mNc7 X-Proofpoint-ORIG-GUID: mqzhWXs3Sx7kAh1R0VF1R5Kovle8mNc7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_03,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 adultscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260126 On 1/26/26 3:31 PM, Abel Vesa wrote: > On 26-01-13 14:13:32, Konrad Dybcio wrote: >> On 1/13/26 1:33 PM, Abel Vesa wrote: >>> From: Wesley Cheng >>> >>> The Glymur USB system contains 3 USB type C ports, 1 USB multiport >>> controller and a USB 2.0 only controller. This encompasses 5 SS USB QMP >>> PHYs (3 combo and 2 uni) and 6 M31 eUSB2 PHYs. All controllers are SNPS >>> DWC3 based, so describe them as flattened DWC3 QCOM nodes. >>> >>> Signed-off-by: Wesley Cheng >>> Co-developed-by: Abel Vesa >>> Signed-off-by: Abel Vesa >>> --- >> >> [...] >> >>> >>> + usb_mp_hsphy0: phy@fa1000 { >>> + compatible = "qcom,glymur-m31-eusb2-phy", >>> + "qcom,sm8750-m31-eusb2-phy"; >>> + >>> + reg = <0 0x00fa1000 0 0x29c>; >>> + #phy-cells = <0>; >>> + >>> + clocks = <&tcsr TCSR_USB2_1_CLKREF_EN>; >>> + clock-names = "ref"; >>> + >>> + resets = <&gcc GCC_QUSB2PHY_HS0_MP_BCR>; >>> + >>> + status = "disabled"; >>> + }; >>> + >>> + usb_mp_hsphy1: phy@fa2000 { >>> + compatible = "qcom,glymur-m31-eusb2-phy", >>> + "qcom,sm8750-m31-eusb2-phy"; >>> + >>> + reg = <0 0x00fa2000 0 0x29c>; >>> + #phy-cells = <0>; >>> + >>> + clocks = <&tcsr TCSR_USB2_2_CLKREF_EN>; >>> + clock-names = "ref"; >>> + >>> + resets = <&gcc GCC_QUSB2PHY_HS1_MP_BCR>; >>> + >>> + status = "disabled"; >>> + }; >> >> >> [...] >> >>> + usb1_ss0_hsphy: phy@fd3000 { >> >> Let's not repeat the mess introduced in hamoa.. >> >> Perhaps let's fall back to usb_0 etc.? > > Sure. So then: > > USB SS[0-2] -> usb_[0-2] > USB MP -> usb_mp > USB 2.0 (USB20S in docs) -> ? usb_hs Konrad