From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D37CA9ECB for ; Thu, 31 Oct 2019 13:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F24EC20862 for ; Thu, 31 Oct 2019 13:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727539AbfJaNdq (ORCPT ); Thu, 31 Oct 2019 09:33:46 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:43896 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726728AbfJaNdq (ORCPT ); Thu, 31 Oct 2019 09:33:46 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 59160C34EDB324E71694; Thu, 31 Oct 2019 21:33:44 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Thu, 31 Oct 2019 21:33:40 +0800 Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure To: Dmitry Osipenko , , , , References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> CC: , , From: Yuehaibing Message-ID: Date: Thu, 31 Oct 2019 21:33:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/31 6:26, Dmitry Osipenko wrote: > 30.10.2019 16:54, YueHaibing пишет: >> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >> COMPILE_TEST is y, building fails: >> >> drivers/gpu/host1x/dev.o: In function `host1x_remove': >> dev.c:(.text+0x624): undefined reference to `put_iova_domain' >> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' >> dev.c:(.text+0x62c): undefined reference to `iova_cache_put' >> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put' >> >> Select IOMMU_IOVA while COMPILE_TEST is set to fix this. >> >> Reported-by: Hulk Robot >> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") >> Signed-off-by: YueHaibing >> --- >> drivers/gpu/host1x/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig >> index cf987a3..354232d 100644 >> --- a/drivers/gpu/host1x/Kconfig >> +++ b/drivers/gpu/host1x/Kconfig >> @@ -2,7 +2,7 @@ >> config TEGRA_HOST1X >> tristate "NVIDIA Tegra host1x driver" >> depends on ARCH_TEGRA || (ARM && COMPILE_TEST) >> - select IOMMU_IOVA if IOMMU_SUPPORT >> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) >> help >> Driver for the NVIDIA Tegra host1x hardware. >> >> > > It should be better to unconditionally select IOMMU_IOVA here. > > The same could be done for drivers/staging/media/tegra-vde/ and > drivers/gpu/host1x/, please see [1]. Yep, I will repost, thanks! > > [1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/ > > . >