From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D7DEA3CAA50 for ; Tue, 26 May 2026 07:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779782188; cv=none; b=gBRDdy4ed/a09TwCQEmu1+IPwXwTa1+6hle3182GHH2up2USOl74wpciNM2Y1d0ae9YlSxd9FJ5bD17ctw/4QYG9znKX9zYXSsKD4G661VUlMbKY1TN2mAhH29AU1ojta/SfvjEasIGqtyrhhQxm/BFe4ifviB9GBJ7sVTAVhnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779782188; c=relaxed/simple; bh=6hzmwGTSHEaB23fFB7ucXxNiSw0m1Yr4kYVhH9sPBlk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QK7s4xNYLeLkJg3ZdglvXX7RFscjvKQwgeSpbOZjsqxXOZyKwmeyqgXEGLy35LBVSvUf2NGKL7kR4F0PzTScBrimXpamJ4JuqTua0EBlD06iG5qGzGwRydqI5UJxrUFtNIK1qxjgA0e+mT/eE2sZaUeA7AQvkBhElpsHZRJ1sBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=f0E1fC40; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="f0E1fC40" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1925216F3; Tue, 26 May 2026 00:56:14 -0700 (PDT) Received: from [10.164.19.7] (unknown [10.164.19.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A39FB3F7B4; Tue, 26 May 2026 00:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1779782179; bh=6hzmwGTSHEaB23fFB7ucXxNiSw0m1Yr4kYVhH9sPBlk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=f0E1fC40TQfywE5hwctAqYLLb+iyQKgjGBgeEyteNh1NRYKEPt6LHj3JW/6RtfygU LWBQL3f2e4m8jNT4r1Wim6XN++G6bIO/VnmXWIhtR0zR0oKOLl5dp+MIK1crrGwiOh A33o7d00SJobM3X00BTLuUcWl5uxeZu1Kdtg8vNc= Message-ID: Date: Tue, 26 May 2026 13:26:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] arm64/hugetlb: Extend batching of multiple CONT_PTE in a single PTE setup To: Wen Jiang , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, urezki@gmail.com Cc: baohua@kernel.org, Xueyuan.chen21@gmail.com, rppt@kernel.org, david@kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, ajd@linux.ibm.com, linux-kernel@vger.kernel.org, jiangwen6@xiaomi.com References: <20260522053146.83209-1-jiangwenxiaomi@gmail.com> <20260522053146.83209-2-jiangwenxiaomi@gmail.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260522053146.83209-2-jiangwenxiaomi@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/05/26 11:01 am, Wen Jiang wrote: > From: "Barry Song (Xiaomi)" > > For sizes aligned to CONT_PTE_SIZE and smaller than PMD_SIZE, > we can batch CONT_PTE settings instead of handling them individually. Better wording: "we can handle CONT_PTE_SIZE groups together" > > Signed-off-by: Barry Song (Xiaomi) > Signed-off-by: Wen Jiang > Tested-by: Xueyuan Chen > --- > arch/arm64/mm/hugetlbpage.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index a42c05cf56408..c4d8b226126cb 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -110,6 +110,12 @@ static inline int num_contig_ptes(unsigned long size, size_t *pgsize) > contig_ptes = CONT_PTES; > break; > default: > + if (size > 0 && size < PMD_SIZE && > + IS_ALIGNED(size, CONT_PTE_SIZE)) { > + contig_ptes = size >> PAGE_SHIFT; > + *pgsize = PAGE_SIZE; > + break; > + } > WARN_ON(!__hugetlb_valid_size(size)); > } > > @@ -359,6 +365,10 @@ pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, vm_flags_t flags) > case CONT_PTE_SIZE: > return pte_mkcont(entry); > default: > + if (pagesize > 0 && pagesize < PMD_SIZE && > + IS_ALIGNED(pagesize, CONT_PTE_SIZE)) > + return pte_mkcont(entry); > + > break; > } > pr_warn("%s: unrecognized huge page size 0x%lx\n",