mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] erofs: shouldn't churn the mapping page for duplicated copies
Date: Sat, 15 Oct 2022 10:50:02 +0800	[thread overview]
Message-ID: <cb1474f7-b1fd-f22a-4250-77f2e931a742@kernel.org> (raw)
In-Reply-To: <20221012045056.13421-1-hsiangkao@linux.alibaba.com>

On 2022/10/12 12:50, Gao Xiang wrote:
> If other duplicated copies exist in one decompression shot, should
> leave the old page as is rather than replace it with the new duplicated
> one.  Otherwise, the following cold path to deal with duplicated copies
> will use the invalid bvec.  It impacts compressed data deduplication.
> 
> Also, shift the onlinepage EIO bit to avoid touching the signed bit.
> 
> Fixes: 267f2492c8f7 ("erofs: introduce multi-reference pclusters (fully-referenced)")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

      reply	other threads:[~2022-10-15  2:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12  4:50 Gao Xiang
2022-10-15  2:50 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb1474f7-b1fd-f22a-4250-77f2e931a742@kernel.org \
    --to=chao@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®