From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F99C433DF for ; Fri, 16 Oct 2020 06:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2ABD20848 for ; Fri, 16 Oct 2020 06:10:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E0NaOFMm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390147AbgJPGK0 (ORCPT ); Fri, 16 Oct 2020 02:10:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49905 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728419AbgJPGK0 (ORCPT ); Fri, 16 Oct 2020 02:10:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602828624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SDFh+4dhaaVVnZpAHchgy8jwKvRXaQU7zwokuKHCQLM=; b=E0NaOFMm4JzepU4BuvUt74gR974xc8OO6uKbJ+LJi0tvXF5Fjg5tInoQMs+6MINIqxJiHj MakZNzqMtTZsQBiEHsbbNV+lL2XeDtk3H06paboUzmcUN5z5VbUs+gGovekmhQaVpKKf0K vI+gTejDipuzLBJq+9D3daXuab2iLx0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-138-jg85ItDjP8CczQ6V1SR-8w-1; Fri, 16 Oct 2020 02:10:22 -0400 X-MC-Unique: jg85ItDjP8CczQ6V1SR-8w-1 Received: by mail-ed1-f71.google.com with SMTP id ay19so536112edb.23 for ; Thu, 15 Oct 2020 23:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SDFh+4dhaaVVnZpAHchgy8jwKvRXaQU7zwokuKHCQLM=; b=Kvo2DFihFGMB8rGk4xr99TW34bNNsT3gvP5grooVBHd6S2mdKZ2XNGSVQE2J6B+6um TJITjWsrEfs4HX6cKP/BNJivFr115rgHAIqyaUR3LtS7dTeSBS4L75crZDnhSECNW6De ECbVudBccnoGumxhWqBZKYIJ472JQhEg561SeNQoxf4nxeQiUG2mRCexsUJDbyZUwPhR 3CjCm5rUEuJdE1A7MYucEg6nGOhub/NjmfMlTi3+l9R/5W5BfjAblvvc7wTfYqnjTrMf WIvhTGTO8rMIH9z/TUfCpE1nIycLUPPOBdXvFRDwlv1vXmLjfHWeUOb/gr2kPoWLH16q Q6Iw== X-Gm-Message-State: AOAM530UnbS2T661wotrMvT0SGkGOL0xHYa5VIWDTuwB5HGba57nsgeb vInhtXp2VP+P25Pya5pUbqMM0055nC74gxGCSVr/miAurT9A3He8hHf3CUXXrMgS4Ds7OaZQBAP sbHRLDQ0vU/m01uAYqUQTj4S4 X-Received: by 2002:a17:906:a002:: with SMTP id p2mr1959643ejy.399.1602828621266; Thu, 15 Oct 2020 23:10:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaToAH6DE6ijarStuPvXIQn3tWvFXSGa5ck7V41ia0Yt6o1J9meHKp3eQ45OLyLzpdJKN78w== X-Received: by 2002:a17:906:a002:: with SMTP id p2mr1959624ejy.399.1602828621050; Thu, 15 Oct 2020 23:10:21 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id g4sm824833ejf.78.2020.10.15.23.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 23:10:20 -0700 (PDT) Subject: Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s To: Jerry Snitselaar , linux-integrity@vger.kernel.org Cc: linux-kernel@vger.kernel.org, jarkko@kernel.org, Peter Huewe , Jason Gunthorpe , James Bottomley References: <20201015214430.17937-1-jsnitsel@redhat.com> From: Hans de Goede Message-ID: Date: Fri, 16 Oct 2020 08:10:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201015214430.17937-1-jsnitsel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/15/20 11:44 PM, Jerry Snitselaar wrote: > There is a misconfiguration in the bios of the gpio pin used for the > interrupt in the T490s. When interrupts are enabled in the tpm_tis > driver code this results in an interrupt storm. This was initially > reported when we attempted to enable the interrupt code in the tpm_tis > driver, which previously wasn't setting a flag to enable it. Due to > the reports of the interrupt storm that code was reverted and we went back > to polling instead of using interrupts. Now that we know the T490s problem > is a firmware issue, add code to check if the system is a T490s and > disable interrupts if that is the case. This will allow us to enable > interrupts for everyone else. If the user has a fixed bios they can > force the enabling of interrupts with tpm_tis.interrupts=1 on the > kernel command line. > > Cc: jarkko@kernel.org > Cc: Peter Huewe > Cc: Jason Gunthorpe > Cc: Hans de Goede > Reviewed-by: James Bottomley > Signed-off-by: Jerry Snitselaar Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/char/tpm/tpm_tis.c | 29 +++++++++++++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 0b214963539d..4ed6e660273a 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include "tpm.h" > #include "tpm_tis_core.h" > > @@ -49,8 +50,8 @@ static inline struct tpm_tis_tcg_phy *to_tpm_tis_tcg_phy(struct tpm_tis_data *da > return container_of(data, struct tpm_tis_tcg_phy, priv); > } > > -static bool interrupts = true; > -module_param(interrupts, bool, 0444); > +static int interrupts = -1; > +module_param(interrupts, int, 0444); > MODULE_PARM_DESC(interrupts, "Enable interrupts"); > > static bool itpm; > @@ -63,6 +64,28 @@ module_param(force, bool, 0444); > MODULE_PARM_DESC(force, "Force device probe rather than using ACPI entry"); > #endif > > +static int tpm_tis_disable_irq(const struct dmi_system_id *d) > +{ > + if (interrupts == -1) { > + pr_notice("tpm_tis: %s detected: disabling interrupts.\n", d->ident); > + interrupts = 0; > + } > + > + return 0; > +} > + > +static const struct dmi_system_id tpm_tis_dmi_table[] = { > + { > + .callback = tpm_tis_disable_irq, > + .ident = "ThinkPad T490s", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"), > + }, > + }, > + {} > +}; > + > #if defined(CONFIG_PNP) && defined(CONFIG_ACPI) > static int has_hid(struct acpi_device *dev, const char *hid) > { > @@ -192,6 +215,8 @@ static int tpm_tis_init(struct device *dev, struct tpm_info *tpm_info) > int irq = -1; > int rc; > > + dmi_check_system(tpm_tis_dmi_table); > + > rc = check_acpi_tpm2(dev); > if (rc) > return rc; >