From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753457AbdHKQKi (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Aug 2017 12:10:38 -0400
Received: from resqmta-po-04v.sys.comcast.net ([96.114.154.163]:46596 "EHLO
        resqmta-po-04v.sys.comcast.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752941AbdHKQKh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Aug 2017 12:10:37 -0400
Reply-To: shuah@kernel.org
Subject: Re: [PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system
To: Sumit Semwal <sumit.semwal@linaro.org>,
        Orson Zhai <orson.zhai@linaro.org>
Cc: "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, chunyan.zhang@spreadtrum.com,
        Shuah Khan <shuah@kernel.org>
References: <20170810110447.869-1-orson.zhai@linaro.org>
 <CAO_48GE_iTeuEdqjBQ-c7ENU+FLERrdu6HLDitJkRtE6Kteuqg@mail.gmail.com>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <cb15ec12-9502-8f55-0ec1-68054330bb59@kernel.org>
Date: Fri, 11 Aug 2017 10:10:34 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAO_48GE_iTeuEdqjBQ-c7ENU+FLERrdu6HLDitJkRtE6Kteuqg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfJM0ZxylTgY4by1G2r01V6bQtIVgsW3n1/nA6Nbj7Xo8yNmiCt4BSbU93eneY7l7haCwjVf1T8nl/ZksRRYdvLcplwDYcvJLpLFy5yrxv7TeAkbV05wW
 5GF7TZmDp1ZLJB9kUB2nOldJp52t3/DuafsVRhRAz1Fh/urDqy2cmuIDbiH4D0aq4wuwzjPQpkAHzy1H2Lp8iJePCrsUuN1boTY9UjKlRxVemP1YiZmqO/Jp
 t66aL0AzBz3unbcfFVwAva53WGuHe4wG5wklCaEhaCkLsMhXX8INKX3xmRTN8huJP0hvPNU6fcE9JrmXko/CATxOJs1yUt2hnh1h+zT90vv8MC5JRIef1Jg+
 qhJZAM2m
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/11/2017 09:55 AM, Sumit Semwal wrote:
> Hello Orson,
> 
> Thanks for the patch.
> 
> On 10 August 2017 at 16:34, Orson Zhai <orson.zhai@linaro.org> wrote:
>> The stack size should be 16 bytes aligned in arm64 system. The similar
>> patch has been merged already.
>>
>>> <commit id: 1f78dda2cf5e4eeb00aee2a01c9515e2e704b4c0>
>>> selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned
>>>
>>>    There is a mandate of 16-byte aligned stack on AArch64 [1], so the
>>>    STACK_SIZE here should also be 16-byte aligned, otherwise we would
>>>    get an error when calling clone().
>>>
>>>    [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>>>
>>>    Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
>>>    Acked-by: Arnd Bergmann <arnd@arndb.de>
>>>    Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>
>> Signed-off-by: Orson Zhai <orson.zhai@linaro.org>
> Please feel free to add my
> Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org>

Thanks for the patch and review.
Applied to linux-kselftest next for 4.14-rc1

thanks,
-- Shuah