From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B42E6220F2D for ; Thu, 6 Aug 2026 21:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786051949; cv=none; b=d1pZEPoy0Q/lqa15Y5HYJpbYvKazOew8AEJ5hpXhxdLk6HdK20OCVUbv+o1QSyP4o/p6irr9ptaCsdlIiWPiMy8QJGX1YPje5vv5IfWEDO0flBObGpf4MEjelMaLR/3gS2ELbVwj1fzh6O3/ObPJHn4BXKUzdzCDE8PdaPPLtSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786051949; c=relaxed/simple; bh=YnwxsCul3+jkThFLF+9y5J+N84ltifMob70I4GtiKEA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tMOLPjCHBRvtK9MmINhXSvezIB+OVkz+hzjZuhYHKS96Eone5oxOFETgbKgvct4uUx36HuDIpG6O7YvqwlmXgCUmdRzQEmzuwCL95/YedEaAz0BtkVNVLfct0lDRfkyTudAgsjMFY2qUxSOFnkQsDEsTspBLYZSN2ZI03IxlapY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KqyJ0TVM; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KqyJ0TVM" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2d049069377so29335685ad.0 for ; Thu, 06 Aug 2026 14:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786051948; x=1786656748; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=6vf8m71Thf7y7jGfiPJQl4yxKA5uMf4oLhl2ZsCsSRA=; b=KqyJ0TVMowEdUdHD9xb4zWG558el3MUypB9BHpWatby3aFAIIWvd+Ybv9fR07SMUai wDOxeMggS4bjcdATyR6CIcdAUlkoq3YajdEP+g22hvOfHPmNj+8hVYZXQtkLCaXo5VqN u47Dv4SdsnViO9oRO/19hlXSdiS6K6FKh10/PFGVKGmmDIwHRxtrtVvgMnuYb9rNiexZ +GKscQWf99eBvD1DNA/9+3vhJySEjQjIIc0bnpd1+GF5KMzp9lk2W8v7Kn5edLvyYfMR Wmxo/FEFr1PgIUlnhL38pk8ZJHdPD6i63I/MGJ+yUTBskkwcXwobGQ4CcU7Jfs3mzQNo 4+IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786051948; x=1786656748; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6vf8m71Thf7y7jGfiPJQl4yxKA5uMf4oLhl2ZsCsSRA=; b=robdU3/0tjorTJ2+4A0BO2rHAVepOpTypbfSo7O+jq17QlVeowu6Fw1pZAictTDYjC 0sme1c58gKRi903duFMbJzfXC7a4VVXrdyRRacvNuLDK5C8kCAsCQh596hzHrREJ5o6B o10ChzPdM0K+cQAGZrENPNpR7dBNoW/9XAWtiArxn4nTjpQ5ZTgwnAGVr/kS5l9hDRl3 WKrrvx9/FLWigR8bj+melIaCKkr6QxGtTOwYCLxSChe1soeSD4qRIjY67Ce5bSjuVHzX U5l4BR2dJjC1jn8LQB0q1RJzzK/McE7oxY98E6SnSBjNyd1d86QtUYKyiK1tFzHzoQWN VP/w== X-Forwarded-Encrypted: i=1; AHgh+RqIrwiWdvuUE7byba0LkeRVx8UzMLPfzcwb882rUw0OZ4gU3WojeL+AZmbI2Wz+DHKHkkBb5msJu8qK8LI=@vger.kernel.org X-Gm-Message-State: AOJu0YwP/ScYLerL0En8eYnw5vvA4eRVjsalhySkgRZrYqwm6OkufiCK U6fEmKuuClTzBoBeDnjKBwcbJ4SMkwAICOczXbwg8VdtuK9v/GzB5qrT X-Gm-Gg: AR+sD138h76e8dinmN8zCl05Sw7/9DQzg4xFjsjQnMXnLDQyYMDYjIbIo7RUHR17I4P WoQX+Vi4kO35wq625JwPiqy7cCyQNmKxLf6x8Gfz3vjMEqAPlWbnNKo4Yawn7NY39+cYPflkBhW BvKQOBgnPq7HiDQhY2VxuNuC73NjYD9E8fVWzm3cc8iXzeE3fM1GDODtJ5wBP13qZcXHfdiwKM6 INTSdlZJ477qpulZqZKj2NGzJLzuRG3PLq7JjnZGn69jbMwD+MMM4bCkX+e0dg58ozCbOCdVA96 r32naZBd5MD5v4jlbKD/N3+YK+6ybYjOW/MflvsiPjjJNSWFM2xvfrEUNOdY0q0rnPpNlRKgsMb fMLrT2THHsdgDAm1jQR0cyXJZ56SIK0PytyzEyOnEsnka19a1Ib92hCRgjB//3PyJRf1I8OpQFx tYIzjw5ASNztmPbEivWOSFtsxJJvhNJfPIIvBiq66ezp6rRUW1mGn6+Bi7jILvTxy5wV5Bov1Xg 7tujc6PvhKhhhXq3bIi333y X-Received: by 2002:a17:903:8c5:b0:2c9:e2c1:4fb5 with SMTP id d9443c01a7336-2d106e99159mr54741385ad.22.1786051948008; Thu, 06 Aug 2026 14:32:28 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d16c4e957esm235465ad.75.2026.08.06.14.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 14:32:27 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 6 Aug 2026 14:32:26 -0700 From: Guenter Roeck To: Babanpreet Singh Cc: Wim Van Sebroeck , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] watchdog: wdrtas: Fix kernel-doc parameter name for wdrtas_reboot() Message-ID: References: <20260730060617.7-1-bbnpreetsingh@gmail.com> <20260730060617.7-2-bbnpreetsingh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730060617.7-2-bbnpreetsingh@gmail.com> On Thu, Jul 30, 2026 at 06:06:16AM +0000, Babanpreet Singh wrote: > scripts/kernel-doc -none reports: > > Warning: drivers/watchdog/wdrtas.c:460 function parameter 'this' not > described in 'wdrtas_reboot' > Warning: drivers/watchdog/wdrtas.c:460 Excess function parameter 'nb' > description in 'wdrtas_reboot' > > wdrtas_reboot() names its notifier block argument 'this', but the > kernel-doc comment documents a parameter named 'nb'. > > Update the kernel-doc comment to document the 'this' parameter. > > Assisted-by: Claude:claude-opus-5 > Signed-off-by: Babanpreet Singh This is a 20+ years old driver which doesn't use the watchdog subsystem. I am not going to apply any patches to it unless the author shows that it is a real problem observed on real hardware, and then I am likely going to ask for a conversion to the watchdog subsystem unlesss it is a critical aproblem and not just something AI came up with as a possible issue. Guenter > --- > drivers/watchdog/wdrtas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/wdrtas.c b/drivers/watchdog/wdrtas.c > index d4fe0bc822116..6c25171de224e 100644 > --- a/drivers/watchdog/wdrtas.c > +++ b/drivers/watchdog/wdrtas.c > @@ -448,7 +448,7 @@ static int wdrtas_temp_close(struct inode *inode, struct file *file) > > /** > * wdrtas_reboot - reboot notifier function > - * @nb: notifier block structure > + * @this: notifier block structure > * @code: reboot code > * @ptr: unused > *