From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B094B3BC677 for ; Fri, 24 Apr 2026 11:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777030591; cv=none; b=j4xABlK4icxEuSeLsyMsyvQ9ifmiAO7OI+f+YZ7xWppaHJMM8rsznhWMmnjllMbqQxLDjmIWzzBoY9HsglkkWBHsO/qI3s6Peuw8m4ChAtqMNt9T5xMRTKzSfoqE3BTgghCfBtORqteJPcPis/7rQDkjmlkTBnMgVhDn+04iQr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777030591; c=relaxed/simple; bh=kPMGUNNSmroYSsiqLoYTt4gz7zVsODQoZrsEYXDMkX0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mAAAYkXsMpnQMSKPNhdR1LIRkKwTkJyJhp7QuvpNhqaDUR9JNRB4W+i2NBMmxN84GvEBg5rY0pK3rmsR+VlVdPfbPs8SQHntlG+eWiDXFcBJ5MS+kxBbS/ILUPtGL2B31Ya73tmZ4DT6AmUVOCvOPtKq+wYtAm5Su26vL2Dwp2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OLx4MBQV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T/Ngsdjp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OLx4MBQV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T/Ngsdjp" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63O82gD01888414 for ; Fri, 24 Apr 2026 11:36:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= szb/C/NuDvGqRRu1u78P1sc9wQPhVPl5cH0BZflLHds=; b=OLx4MBQVZcIfvtqp EyXnMunn34PmO6FdZqwrOQ5eJ7VdohfMBqrt1DIAgMr2uE8R3t9hM7eaLq2z72eo YipG+oORIKgtnonaVXYLPwHnQX3/gaAImzkd8WBfO4S9Oq0M1/zeMi6pBgzWRqvY wj0oPjcg3Xle7KGsaJt+w+smHfOrNCWSKTMu1i4CA51wtbDO6x7DWl9jBeW3+hF8 mcrSBlcOojvz1YkxZZWCh6e4sMZxg6xXe6z3XnF6M7i0Il2qdAw9u2SOT2dt6KRT hIEgI4TMaxO5QOruwTXU4tLt/KEddekZOcaugBsK/PDF2nTLE7mkOXePdNEpfPvW lV83gA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqp9dvcwn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Apr 2026 11:36:28 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50e5d7f4b63so16417311cf.0 for ; Fri, 24 Apr 2026 04:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777030588; x=1777635388; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=szb/C/NuDvGqRRu1u78P1sc9wQPhVPl5cH0BZflLHds=; b=T/NgsdjppkTMSp11a9U6JVNm4ynwClbtt+qmBTanaFnXqQizUrI7EaBBfkCZWhM2yC 1rRH5fqrDEKMZ8qp77aCRIGt2HJ+BeY2I8flCVgAJPgObjsW6TymW+Qdsx/NPJo6Yde3 pC/ZeGg/pqA5c5yhF5vCjjeKIzq9PjlsIC////+hKtTHQBE6b6NKYX9PCJH4+TQoxEMd 9AmOctokE4pIF56on5KqBcWeOxOfJCiuB9TIAvr+2cHcBaM9SPtuRdxQW5PyNJtqG90N QxQWTNSI3kWaSsh3wgGSHsIqscdTFLViQYBnJ+wMCMiPNBzxT2OfciWMUQuuwa8ZNM0w /J9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777030588; x=1777635388; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=szb/C/NuDvGqRRu1u78P1sc9wQPhVPl5cH0BZflLHds=; b=FBJLvRk46oeXU+0UD7upER7yNMObCxeCqfHICJvnsr46IgNv/4dFJHxG9GALCQoYti 7KgKenbG0GKUjvNkxFFn2J36qZasmFc0rx6PKuWY8Xk8Jwe4tPdUcv4G2ZSYkZ/HilsR K0r4McCh+mSxVkX7RE95Sgli5kk9bm2nkpTE0Bd+o8hSjv+E0fVW+Eqv5hg1oABEqBv6 bpj6Wh8hQo1lian/g97nzbMyFT36WsVLypG65ROeIzC3/cQ0itwqVokpTRu6DodObslk AYsuZcNl3jQHa76q/uGO+dQMoIQzXFAhLoWWrIXKDzlYlyAcE8CgYW/WhS+VdTVatS0c euHA== X-Forwarded-Encrypted: i=1; AFNElJ/aNMwIrXNz9OWPouQMdHO3Y8RkZSWgUizmZh2iAOzNMKmyg8GBzUzmZGz0nZUhx35HCFl4aV507ijFLjE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+hTYIOQr6SGrmHJwt3YnSFOrRmCzw0pcj3V+LU/LVDR7bpQ1N 4ixwlz4CdASUeL/zzFu/Ap3684S+rL5Bwr1r+2H3RoJtk873xPnzuWClmuqGNF8th6oCPgY9jZn ua20lObAvVnQT6GKNisxoUIZtiySft8ClEQbaOUXnG3otqd06l+hFi0mWWwYnV/ej6t9zyF5ub4 M= X-Gm-Gg: AeBDietjridSHd1MXgbaNNn58sTtc1TR0rajV2E6wA5JWLBcaTfBCFV6xNq/QgPR02q focsPMtcPTB+sicBIEVlNPC16cL0m11p4zOzL1UUe9rSi66g0d0Vrv58j6d4oG/i8syYp7javUL sRnBRl0RIHZDLLcYEaJl1rif8tJ9+2Vrwusd5tmRh+HviRv3mb9QfuqkVy1wZlHpPmpoZw4g4p0 u7dMFz+rB4xyMlhMKO7tdvAAEhNKId0DnCOvAdv3uASIsst1pPjvB9TXUt5zhOmpQTnQL9QqWu3 /tb7xJV5jn3eb5ynD8Ll7Yckf/A/flUuqZorOAEF+3eeHC1H+4MyQsz4QtTZDLXIqA/VhxjJmYY CcOpQ7fE0JkiceFuzl+K0bbpQ43xVAKKmRYLvJEjNigvNy1bZGWyw6XUPx78l7Hc87EBkwoiIV+ JgnpAJj9MA4j9rpA== X-Received: by 2002:a05:622a:1f88:b0:50f:bfe3:a04e with SMTP id d75a77b69052e-50fbfe3a765mr119513731cf.7.1777030587701; Fri, 24 Apr 2026 04:36:27 -0700 (PDT) X-Received: by 2002:a05:622a:1f88:b0:50f:bfe3:a04e with SMTP id d75a77b69052e-50fbfe3a765mr119513231cf.7.1777030587197; Fri, 24 Apr 2026 04:36:27 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c47fe836sm4924815a12.3.2026.04.24.04.36.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 04:36:25 -0700 (PDT) Message-ID: Date: Fri, 24 Apr 2026 13:36:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 04/10] arm64: dts: qcom: msm8939: Add venus node To: Erikas Bitovtas , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Stephan Gerhold Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260416-msm8939-venus-rfc-v1-0-a09fcf2c23df@gmail.com> <20260416-msm8939-venus-rfc-v1-4-a09fcf2c23df@gmail.com> <717459db-479a-4a68-84d1-a718c8ba5a54@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <717459db-479a-4a68-84d1-a718c8ba5a54@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Zd2v2al8USjNl1XzmooO1bxJ489fLGSe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDExMSBTYWx0ZWRfX1RHVH5bNVVQZ YvgTqn1rbzluAI8NE5DBpEVVxuLOszJhFbq3AoOxYwwFcS+rObWTHsMQA1pnzpwQY3pMo65JaOd QCqLrqXwK906GKwKQgdxodh005ajb5aIci8+9VvjDSjqe+Bt10qFe+q7cF0F+NMgPR7Dno13iAa hI+e2Xi7IR/zi7kZWg+rksxUkoDON5q6PcWXpBnd32BBXzGYBnEybbx9Tw8GaFAX2AIcB+jA573 T4GMDCk0llNjaPrrr8vX+kEpNi0A78Jkb0K9Vpli8/jdkL9G+5wnaFurOK0z3wstJ/bqGCSwtnd eno7Xipp4T8aPNqnCyGBy4+djd2Jxumu9KaNnjCqgerNiXdReJ+d0TCLKtbOG4tw/mok3fAjE4W SNy1UtH1rBB3At8PyJRXj6eX2/AjqxTvd6RrHbVqPk0g0SmJvxmDTFHe4kYhnT6f0OurS1jLtgP Gs1PuDniayA/z9w0hCw== X-Authority-Analysis: v=2.4 cv=fP4JG5ae c=1 sm=1 tr=0 ts=69eb55bc cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=bAtGagR5AAAA:20 a=KePjsaevwCBX4e1EH2wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: Zd2v2al8USjNl1XzmooO1bxJ489fLGSe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240111 On 4/18/26 5:34 PM, Erikas Bitovtas wrote: > > > On 4/16/26 5:31 PM, Bryan O'Donoghue wrote: >> On 16/04/2026 14:43, Erikas Bitovtas wrote: >>> +            video-decoder { >>> +                compatible = "venus-decoder"; >>> +                clocks = <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>, >>> +                     <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>; >>> +                clock-names = "core0", "core1"; >>> +                power-domains = <&gcc VENUS_CORE0_GDSC>, >>> +                        <&gcc VENUS_CORE1_GDSC>; >> >> This doesn't make sense. >> >> You have two cores => assign one to encoder and the other to decoder. >> > > This way during decode only one of the cores gets powered up instead of > both, resulting in power collapse fails. > Core clocks and power domains can be moved into Venus node instead of > sub-nodes, like this: > venus: video-codec@1d00000 { > compatible = "qcom,msm8939-venus"; > reg = <0x01d00000 0xff000>; > interrupts = ; > clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>, > <&gcc GCC_VENUS0_AHB_CLK>, > <&gcc GCC_VENUS0_AXI_CLK>, > <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>, > <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>; > clock-names = "core", > "iface", > "bus", > "core0", > "core1"; > power-domains = <&gcc VENUS_GDSC>, > <&gcc VENUS_C0RE0_GDSC>, > <&gcc VENUS_CORE1_GDSC>; > power-domain-names = "venus", "core0", "core1"; > }; > > And then they can be powered up regardless if the session is for > encoding or decoding. > My first question was actually about this - whether these cores should > be powered up only decoding or for encoding as well. Bus configs > downstream signify they are only for decoding: > https://github.com/msm8916-mainline/linux-downstream/blob/b20608408caff817ec874f325127b07609fbaeb8/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L1589 > https://github.com/msm8916-mainline/linux-downstream/blob/b20608408caff817ec874f325127b07609fbaeb8/Documentation/devicetree/bindings/media/video/msm-vidc.txt#L35 > Unfortunately, I couldn't test encoding on my device. It appears to be > broken. Do we know whether it works on msm8916? (+Stephan) Konrad