From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 356A22F616A for ; Thu, 11 Jun 2026 04:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781153142; cv=none; b=lljER4MY4QsTmPfN5Fh6jCCWfBcaC8grolXmhbOFPrUCZS2p+Ow7/n3RydaSbMryjySBVDqR164UpdeZCZWXEXPJd+Er/31kKm4lYq+i/tz6pyXDsasWC6TkeUSMMMvu5ofB9fzQ1F9HWmaVxDWfeDZSHT2P04elaxE6OUrZL1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781153142; c=relaxed/simple; bh=wDZgTVz/oZs6fHMeDkBQJjN738mapPf0RtpZObfLSGo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YqgNRwvt6vVY9gbfSJoG5Zb3w70GxW7bHW1Vxi064hdCYeQqA9RFLlUl7afHI9zuYuXFmOmbd5YiMKux7aBGtA8R0OW+MfT7PU9b8D4SwRnZruky/Ysysszx7JC+divDx6dl4NoHqBsQRHGQ8AgmYOgyFs0Cwh7EHLRi71Qd+qQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eUCmfE5X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G8QPs6Ma; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eUCmfE5X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G8QPs6Ma" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B0Nvpp1615307 for ; Thu, 11 Jun 2026 04:45:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8ks7xcs4CcsvhpxQlRnY7mYEmf/7lZqBcXTDU2LX0qM=; b=eUCmfE5XNyddAO+D 0dw0SQBchcu20RPqbpJtWlc+F9af0uhK8DgWGreLf/IcuIAHWstGYcvZE1wBjWrP pOk3mE3TS7UAxtT2EbgtxlrfPWeHICyUpm/5ME2ncJCLlfHIEkDFMKo87wiJVxO9 xTRl7wT+haxpU2/pecsGphJf0QdP8yTcuqM4gLs+mnNA/qOkCCwHBtEa4p3C2t/a 269c2KgniB28cCu/RNw0PeGLnEqdXZ44WFMg8+cnx3oaU84JBeBc7z2zZvjNgkcL iJo0IJ4q4XAnWtTK5FJhCjIk5z/Zc8YSJ+yDMcDVAAVw5i6mMneD3B0oA02EzWKe yJjCVw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe79hkyt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 04:45:39 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84233efcaadso5075343b3a.1 for ; Wed, 10 Jun 2026 21:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781153139; x=1781757939; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8ks7xcs4CcsvhpxQlRnY7mYEmf/7lZqBcXTDU2LX0qM=; b=G8QPs6MaIde05IkbfG0Ekp9B3NYDtG+Wikvx63NT4Z3ZspkYV3dy4uEl8bzfL11in6 MLrStFDGJVnFYS7e3PchvWDQELTzfFWBcKPMEcT0uJmIW6/2cA5gVXWBiuarZPMHIOv6 DH4FbNHrI0Kzt4mlea1EjE5uzodvXYHLFnyWTepjmVGo6dxe0zzm9bNhzJNxc7snDicz O+jUMC/PFR7No/YfTxFjLT7KTnCxl9XXLTtob0AmixFFU4+P4OKHozQ9/KP0mA40d3ae ZXKat/xJchAJ7PuNas9iqqq1gewWuWipGGxLiKW/NBP7NyV3B+R61qq8gTSPNyLU86zl ATng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781153139; x=1781757939; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ks7xcs4CcsvhpxQlRnY7mYEmf/7lZqBcXTDU2LX0qM=; b=cyNVGop2AvTIcUe1ZTmmrebqoGlZXtxtKqzg6yOyZo2p8EritC68/+3TBbN5G1+a6P och8moUig5pt47jd5nPpADBuaiOp8AIx2S6DXmTLk6Qi/Ylojcgkr5CVLDEt+Q1Ile5F EYyBMjlUqaAYQ8avkyCi9NBjhdZD7RLuJWV9aYOXEYu4oVnojnHEzACTog16ZdqDfH84 o7+nFu98BdKjAymu+IdX22HI/eTcnS0lGTiVIkT2Nci6yIUDcnOh4RYuOC4P2Hk7Pf4P 929bj73MIwUJscB+0BKpxxSA4r4PGaZODHS3/m4vYb3gURVhjTqEVoq6m5Ov3tG5xbUN 5yqA== X-Forwarded-Encrypted: i=1; AFNElJ9nja8gluP3E4hYQgtuVphpZR+Mpe79aCTBawiSg290B7XWIUlcjVQHGNbzO4SKMcGTcFxFozwq6OQ2Bkk=@vger.kernel.org X-Gm-Message-State: AOJu0YzsJjD8KRDDujp5G6E3oeo8mJ9KiXr+hPo2BMbV7ihAmETcSLXH 5OS6HrcNnP0xS6KFYpfMkwoOcZ2PkcDew6ZDHsNcSbbnkBsClqBdhWnMf1qPO4PEJJYlu671RES +3lSAVlSQH1aiUCS6Jxb/ogZOdl6dCdoBuaylXQaXa7CtLbI4fUyHiS6m3lBUBUsZPho= X-Gm-Gg: Acq92OGVtyd6zX3/iTd4krRMffQUjxL1cHAjgrHXLJCDOtKIZy1CYXQNVY983EBwmoa tsv0Fvjfl7BrNK/7OsMIRRzEY3UzvQXl0a2EWPblvBUDZrIHqsMyKfGGdKPNgzmT53fufl0IJB6 S9UCwHLDqx2f0zyDmJovcHhuKyn2b6EuOHFA1rXsTxuNm9boIL3BkpQkQvUCwrLCYqH4ZpS6G/k 4VWvPxJXTIj/drg8+qvUpMmiIeAxW/msKiq6ZFHBMw8jBLQR190vUIS4FJcnC6U8yYmXKy753rD dn65wCelWNkF/NuOmzq9Lc45uX8vbHtyiUkYqvdBEvjHRX+R/hnUPYix9YqP5PdwIyKbtRT3T4L oOelslFMXcwFZ+7NmSzGBZlnex1xRJsERbP1fzeQYomE2+DZVGfQsAiqjPsseNlM= X-Received: by 2002:a05:6a00:bd89:b0:842:5ea5:5fdd with SMTP id d2e1a72fcca58-84336bc6f14mr1290364b3a.40.1781153138774; Wed, 10 Jun 2026 21:45:38 -0700 (PDT) X-Received: by 2002:a05:6a00:bd89:b0:842:5ea5:5fdd with SMTP id d2e1a72fcca58-84336bc6f14mr1290333b3a.40.1781153138304; Wed, 10 Jun 2026 21:45:38 -0700 (PDT) Received: from [10.217.199.117] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-843383197e5sm467576b3a.52.2026.06.10.21.45.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 21:45:37 -0700 (PDT) Message-ID: Date: Thu, 11 Jun 2026 10:15:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] remoteproc: qcom: pas: register TMD thermal cooling devices To: Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260609-qmi-tmd-v3-0-291a2ff4c634@oss.qualcomm.com> <20260609-qmi-tmd-v3-3-291a2ff4c634@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: mtrjRABz9D-xEIbzB9qwZfZWeeCzB64g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDA0MyBTYWx0ZWRfXzKZvlHueXDlA 1dQTJQUGwm1CicZmH+EWIa+pG6/hUh4iOdCFodTPOVxNlNYQs5k2713HkGT8R09XiQMqU8LHvtg bLVzVMgXc9kK4u7W3L9vf7gaBiRqoPzS16O6j/yJ0LQrGQWr2IAu69AdZngqK+/SpTcT9URJU/p KzsNntDSYe89WPvyzD5hPr5zRo5Qkd88jrx7k1hcNDeKbJjLjt/+Q6sFmpJwkvvF2XK94PIt8Wd vI0OxY48wRqltbgCMxgboGHSH1z7NDb1HKTAEtLMswcG2/OMwRiVIAq7mM/xPchjoDxF9g8Lck0 rkXEXJWIoLVu9GfTHPpd47uDohqzI5Gi1V1dZUK1RuCnpQ5b0aexLILEkYI4wDxW5Ly99t77BMU hNzBdN99s3qYJz4yT8If0urTz1gXO2H+Vy7eoEa9FoC0qXGU/TptdECTO78+9VrvicA7MJK26iw tDu3RZa8tOzNN3yiXWA== X-Proofpoint-GUID: mtrjRABz9D-xEIbzB9qwZfZWeeCzB64g X-Authority-Analysis: v=2.4 cv=fbydDUQF c=1 sm=1 tr=0 ts=6a2a3d73 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=cgKxsijKBzv_CCWCEVYA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDA0MyBTYWx0ZWRfX8IlVkswO8G25 jY1gKcUVV7GRUnfsU5+P2Lo+xqW8dSYB/6qreJR/g0phnhaPNT601dqmjGp8Kr49GSnUNyIkSIv edvYuaYgfACLS0u8XRcvES69STrUE7E= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110043 On 6/9/2026 5:33 PM, Konrad Dybcio wrote: > On 6/9/26 12:22 PM, Gaurav Kohli wrote: >> Add support for Thermal Mitigation Devices (TMDs) to enable >> thermal throttling of remote processors through QMI. >> >> This enables the thermal framework to request mitigation when remote >> subsystems (modem, CDSP) contribute to thermal issues. >> >> Signed-off-by: Gaurav Kohli >> Signed-off-by: Daniel Lezcano > > There's no other signs of Daniel in this patch, please fix the > tags chain > > [...] > Thanks Konrad for review, will fix this. >> +static int qcom_pas_setup_tmd(struct qcom_pas *pas) >> +{ >> + struct device *dev = pas->dev; >> + struct device_node *np = dev->of_node; >> + const char **tmd_names; >> + int num_tmds, ret, i; >> + >> + if (!of_find_property(np, "tmd-names", NULL)) > > Let's use device_property_present() instead > Ack. >> + return 0; >> + >> + /* Get the TMD names array */ >> + num_tmds = of_property_count_strings(np, "tmd-names"); > > Is this something we can stuff into platform_data for a given rproc on a > given SoC (for which we already store *some* data in the PAS driver)? > Without tmd-names in DT, it is unclear which index corresponds to which binding. With #cooling-cells, tmd-names in DT provides an explicit name-to-index mapping. Please suggest. > Konrad