From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E97E3101B1 for ; Mon, 2 Feb 2026 12:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770034449; cv=none; b=XbNQK2QQtqIHecl59oPWLzCf9kdDGG/4xaN6HOTmpAP19YXmaCzwky0bNAneZWA5ntu7kvv308/as76u4iHLWN4x6vyPYldPLpoxkPvoj/WIWezdVLJ42iRA77soyXCt2M/e1svQczAE+L5MqPrWxALdVGjrpW8555J2N0G/DAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770034449; c=relaxed/simple; bh=5J34r/+ApNRiahkyIeHhZYRtFT9XyNBJYoicVWmANBA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rPBEnGXOD/y8ekZlQrygiE42YmgvuYbF+MEY3wARdbPM3bIkut6XTFk33oSpEFnx05n8JWgcnntSQSY1cpkBnB7ulvVmmhvLSl1kiafmP6TBhpAvoN3YHNvlxczfFsgPHAolW7GFDI8oMJ//ymub7UtvntSggqRkAYWxsQIEnhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=0NngMaRJ; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="0NngMaRJ" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 163D71A2B8A; Mon, 2 Feb 2026 12:14:03 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D03F160767; Mon, 2 Feb 2026 12:14:02 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 90372119A8888; Mon, 2 Feb 2026 13:13:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770034441; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=ZHd5AnMkbUE3zxk/hg2R1hlw9zSRuQ0nBLYdgKjvwxQ=; b=0NngMaRJMO41O6+zsLzOrtyirfC+VgGur1mYiGh1ixtntaCMFluwQ5Jtlr/yjQjXEx42Tw w6v5UHIFKWSxcFEFxI7nsfI63T/IahRyiHYP7GX417DiQ84/ftcrFzJeA289lmxcMpHgEd Oz4pbHXEgTk+DEMRK92JoKHclB/x1OgQckwt7YfrFpqyPpgBLW6w6beUBPRt2DqTzvBPr5 DDQ6q4d8MfFNqKNg69Sbm/QK5ogMf0THdyRlXqeLLu4Td4v7ezvmipGFSwDmqaEZLKsBcj mQLedF7KYk2TKzrVocG8Y0c6zhV7aDX6ZeN6aGcnZDMUhMnm4MdSUePIh0A4mQ== Message-ID: Date: Mon, 2 Feb 2026 13:14:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/vkms: Add YUV410, YUV411, YVU410, and YVU411 support To: Renjun Wang , hamohammed.sa@gmail.com, simona@ffwll.ch, melissa.srw@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: From: Louis Chauvet Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 2/1/26 15:02, Renjun Wang wrote: > Add support for the following planar YUV formats: > - DRM_FORMAT_YUV410 > - DRM_FORMAT_YUV411 > - DRM_FORMAT_YVU410 > - DRM_FORMAT_YVU411 > > These formats are handled by the existing planar_yuv_read_line() > function, which correctly handles the subsampling defined in each > format's drm_format_info. > > The YVU variants (YVU410, YVU411) are also added to > get_conversion_matrix_to_argb_u16() to ensure the U and V columns > are swapped correctly in the conversion matrix. > > Signed-off-by: Renjun Wang This patch seems correct, so you can add my: Acked-by: Louis Chauvet But how did you test it? I don't see the support in IGT. You have an other application / use-case? Thanks, Louis Chauvet > --- > drivers/gpu/drm/vkms/vkms_formats.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkms_formats.c > index dfb8e13cba87..5ef5d49a44ef 100644 > --- a/drivers/gpu/drm/vkms/vkms_formats.c > +++ b/drivers/gpu/drm/vkms/vkms_formats.c > @@ -730,9 +730,13 @@ pixel_read_line_t get_pixel_read_line_function(u32 format) > case DRM_FORMAT_P012: > case DRM_FORMAT_P016: > return &YUV161616_semiplanar_read_line; > + case DRM_FORMAT_YUV410: > + case DRM_FORMAT_YUV411: > case DRM_FORMAT_YUV420: > case DRM_FORMAT_YUV422: > case DRM_FORMAT_YUV444: > + case DRM_FORMAT_YVU410: > + case DRM_FORMAT_YVU411: > case DRM_FORMAT_YVU420: > case DRM_FORMAT_YVU422: > case DRM_FORMAT_YVU444: > @@ -921,6 +925,8 @@ void get_conversion_matrix_to_argb_u16(u32 format, > memcpy(matrix, matrix_to_copy, sizeof(*matrix_to_copy)); > > switch (format) { > + case DRM_FORMAT_YVU410: > + case DRM_FORMAT_YVU411: > case DRM_FORMAT_YVU420: > case DRM_FORMAT_YVU422: > case DRM_FORMAT_YVU444: