mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, "Xin Li (Intel)" <xin@zytor.com>
Subject: Re: [PATCH v4 08/18] x86/extable: Add support for immediate form MSR instructions
Date: Tue, 30 Jun 2026 08:42:37 +0200	[thread overview]
Message-ID: <cb31b08a-8263-431e-9395-a36ce19e642f@suse.com> (raw)
In-Reply-To: <18106e85-dd3c-4cd2-9039-30361cd477a1@zytor.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 2329 bytes --]

On 29.06.26 19:04, H. Peter Anvin wrote:
> On 2026-06-28 23:55, Juergen Gross wrote:
>> Signed-off-by: Xin Li (Intel) <xin@zytor.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> V2:
>> - new patch, taken from the RFC v2 MSR refactor series by Xin Li
>> V3:
>> - use instruction decoder (Peter Zijlstra)
>> V4:
>> - don't assume %rax for immediate form (Andrew Cooper)
>> ---
>>   arch/x86/mm/extable.c | 46 +++++++++++++++++++++++++++++++++++++------
>>   1 file changed, 40 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
>> index ceb8d03191ab..9974785c8968 100644
>> --- a/arch/x86/mm/extable.c
>> +++ b/arch/x86/mm/extable.c
>> @@ -166,25 +166,59 @@ static bool ex_handler_uaccess(const struct exception_table_entry *fixup,
>>   static bool ex_handler_msr(const struct exception_table_entry *fixup,
>>   			   struct pt_regs *regs, bool wrmsr, bool safe, int reg)
>>   {
>> +	unsigned long *regptr;
>> +	struct insn insn;
>> +	bool imm_insn;
>> +	u32 msr;
>> +
>> +	imm_insn = insn_decode_kernel(&insn, (void *)regs->ip) &&
>> +		   insn.vex_prefix.nbytes;
>> +	msr = imm_insn ? insn.immediate.value : (u32)regs->cx;
>> +	regptr = imm_insn ? insn_get_modrm_reg_ptr(&insn, regs) : &regs->ax;
>> +	if (unlikely(!regptr)) {
>> +		pr_err("Inconsistent %sMSR access instruction data at rIP: 0x%lx (%pS)!\n",
>> +		       wrmsr ? "WR" : "RD", regs->ip, (void *)regs->ip);
>> +		show_stack_regs(regs);
>> +		goto out;
>> +	}
>> +
>>   	if (__ONCE_LITE_IF(!safe && wrmsr)) {
>> -		pr_warn("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at rIP: 0x%lx (%pS)\n",
>> -			(unsigned int)regs->cx, (unsigned int)regs->dx,
>> -			(unsigned int)regs->ax,  regs->ip, (void *)regs->ip);
>> +		/*
>> +		 * To maintain consistency with existing RDMSR and WRMSR(NS) instructions,
>> +		 * the register operand for immediate form MSR instructions is ALWAYS
>> +		 * encoded as RAX in <asm/msr.h> for reading or writing the MSR value.
>> +		 */
>> +		u64 msr_val = *regptr;
> 
> This comment is inconsistent with the use of a *regptr. The code is valid
> without this assumption, since you do insn_get_modrm_reg_ptr(), so I think you
> can simply omit the comment.

Indeed, thanks for spotting.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

  reply	other threads:[~2026-06-30  6:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  6:55 [PATCH v4 00/18] x86/msr: Inline rdmsr/wrmsr instructions Juergen Gross
2026-06-29  6:55 ` [PATCH v4 01/18] x86/alternative: Support alt_replace_call() with instructions after call Juergen Gross
2026-06-29  6:55 ` [PATCH v4 02/18] coco/tdx: Rename MSR access helpers Juergen Gross
2026-06-29  6:55 ` [PATCH v4 03/18] KVM: x86: Remove the KVM private read_msr() function Juergen Gross
2026-06-29  6:55 ` [PATCH v4 04/18] x86/msr: Minimize usage of native_*() msr access functions Juergen Gross
2026-06-29  6:55 ` [PATCH v4 05/18] x86/msr: Move MSR trace calls one function level up Juergen Gross
2026-06-29  6:55 ` [PATCH v4 06/18] x86/hyperv: Switch from __rdmsr() to native_rdmsrq() Juergen Gross
2026-06-29  6:55 ` [PATCH v4 07/18] x86/opcode: Add immediate form MSR instructions Juergen Gross
2026-06-29  6:55 ` [PATCH v4 08/18] x86/extable: Add support for " Juergen Gross
2026-06-29 17:04   ` H. Peter Anvin
2026-06-30  6:42     ` Jürgen Groß [this message]
2026-06-29  6:55 ` [PATCH v4 09/18] x86/msr: Make wrmsrns() a first class citizen Juergen Gross
2026-06-29  6:55 ` [PATCH v4 10/18] x86/msr: Introduce sync_cpu_after_wrmsrns() Juergen Gross
2026-06-29  6:55 ` [PATCH v4 11/18] x86/msr: Use the alternatives mechanism for RDMSR Juergen Gross
2026-06-29  6:55 ` [PATCH v4 12/18] x86/alternatives: Add ALTERNATIVE_4() Juergen Gross
2026-06-29  6:55 ` [PATCH v4 13/18] x86/paravirt: Split off MSR related hooks into new header Juergen Gross
2026-06-29  6:55 ` [PATCH v4 14/18] x86/paravirt: Prepare support of MSR instruction interfaces Juergen Gross
2026-06-29  6:55 ` [PATCH v4 15/18] x86/paravirt: Switch MSR access pv_ops functions to " Juergen Gross
2026-06-29  6:55 ` [PATCH v4 16/18] x86/msr: Reduce number of low level MSR access helpers Juergen Gross
2026-06-29  6:55 ` [PATCH v4 17/18] x86/paravirt: Use alternatives for MSR access with paravirt Juergen Gross
2026-06-29  6:55 ` [PATCH v4 18/18] x86/msr: Make all MSR access functions __always_inline Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb31b08a-8263-431e-9395-a36ce19e642f@suse.com \
    --to=jgross@suse.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®