From: Olivier Langlois <olivier@trillion01.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] io_uring: Fix race condition when sqp thread goes to sleep
Date: Tue, 22 Jun 2021 15:07:55 -0400 [thread overview]
Message-ID: <cb33d013afae9cd3e2c245230cdbc39ba4679b13.camel@trillion01.com> (raw)
In-Reply-To: <d9d9527c-6d2e-b840-15dd-057618de7864@gmail.com>
On Tue, 2021-06-22 at 19:55 +0100, Pavel Begunkov wrote:
> On 6/22/21 7:53 PM, Olivier Langlois wrote:
> > On Tue, 2021-06-22 at 11:45 -0700, Olivier Langlois wrote:
> > > If an asynchronous completion happens before the task is
> > > preparing
> > > itself to wait and set its state to TASK_INTERRUPTABLE, the
> > > completion
> > > will not wake up the sqp thread.
> > >
> > I have just noticed that I made a typo in the description. I will
> > send
> > a v2 of that patch.
> >
> > Sorry about that. I was too excited to share my discovery...
>
> git format-patch --cover-letter --thread=shallow ...
>
> would be even better, but the fix looks right
>
You are too good... I thought that I could get away from hacking
manually the patch file for such a minor change...
It seems that I got caught...
Let me know if you need me to redo it the right way...
next prev parent reply other threads:[~2021-06-22 19:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 18:45 [PATCH 0/2] Minor SQPOLL thread fix and improvement Olivier Langlois, Olivier Langlois
2021-06-22 18:45 ` [PATCH 1/2] io_uring: Fix race condition when sqp thread goes to sleep Olivier Langlois
2021-06-22 18:53 ` Olivier Langlois
2021-06-22 18:55 ` Pavel Begunkov
2021-06-22 19:07 ` Olivier Langlois [this message]
[not found] ` <60d23218.1c69fb81.79e86.f345SMTPIN_ADDED_MISSING@mx.google.com>
2021-06-22 20:45 ` [PATCH 1/2 v2] " Pavel Begunkov
2021-06-22 22:37 ` Olivier Langlois
2021-06-22 22:42 ` Olivier Langlois
2021-06-22 23:03 ` Pavel Begunkov
2021-06-23 13:52 ` Olivier Langlois
2021-06-23 15:58 ` Pavel Begunkov
2021-06-22 18:45 ` [PATCH 2/2] io_uring: Create define to modify a SQPOLL parameter Olivier Langlois
2021-06-22 20:58 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb33d013afae9cd3e2c245230cdbc39ba4679b13.camel@trillion01.com \
--to=olivier@trillion01.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®