From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250AbcE0CYd (ORCPT ); Thu, 26 May 2016 22:24:33 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:33389 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932127AbcE0CYc (ORCPT ); Thu, 26 May 2016 22:24:32 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <7d7cb41b651443b5dd96be739700a8b2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit To: Jaehoon Chung , Ulf Hansson References: <1464232063-24841-1-git-send-email-shawn.lin@rock-chips.com> <57479A7E.3050103@samsung.com> Cc: shawn.lin@rock-chips.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , linux-rockchip@lists.infradead.org From: Shawn Lin Message-ID: Date: Fri, 27 May 2016 10:24:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <57479A7E.3050103@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/5/27 8:53, Jaehoon Chung 写道: > Hi Shawn, > > On 05/26/2016 12:07 PM, Shawn Lin wrote: >> dw_mci_get_cd have already dealed with these for >> both of internal card-detect and gpio card-detect. > > s/dealed/dealt > > This patch looks good to me. Could you resend the patch? not RFC. > Ok. > Best Regards, > Jaehoon Chung > >> >> Signed-off-by: Shawn Lin >> >> --- >> >> drivers/mmc/host/dw_mmc.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 829a6ee..cb30e91 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) >> mmc->max_seg_size = mmc->max_req_size; >> } >> >> - if (dw_mci_get_cd(mmc)) >> - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); >> - else >> - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); >> + dw_mci_get_cd(mmc); >> >> ret = mmc_add_host(mmc); >> if (ret) >> > > > > -- Best Regards Shawn Lin