From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610363C9433 for ; Wed, 25 Mar 2026 21:46:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774475193; cv=none; b=PmImGtBtJPtlNQgHTHoQU0u2tZEhgQVd4Z8yLu9q4iqaImUZLn7FiilDfSaOR1CH4WsoMxhcqXJAJGn+4sIwtc5wWYH/ir5HIMm2IUjt4/0LOEtZspm5+K9hnQuu6AJqwqzF3dILiSLvkBMQLV8jKDcc5KEcfMVNpCFFWT8nFiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774475193; c=relaxed/simple; bh=DVWCQ8NqG+tUBJXZDcsZ/S+o+QyjDYDrkQI0ATlfZkw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mwp/O/IA9OunyJcOn8coun9wCpSj9yh/wVhqbuLNqoHo6Dgz9tar88RK1cfaBqtqsB2DrTiKLQgTt88xX3N77zWMzxNdiaiFvrKQqFL8dtpX0NWbWbNycQ7kbvT7ltLN/XO0TUpXsN0e0lV++gt7ZVJDJMWcaRiuqy4AXdDEqjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GdimBKcJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NIbKheCG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GdimBKcJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NIbKheCG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PFHCqa585507 for ; Wed, 25 Mar 2026 21:46:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EHvpyCZJsypMHVwxXNF2FT+oeJZbUA/sFO+4H7ugunQ=; b=GdimBKcJjkA5CCQu kW8yzErCbl9vJ5021GQ6FIhsz4dVPvFr3QTIAZqzRychY7nbW3zwRlRvhFtqL4p3 2/jh7svL26CyWAf0pq5rHzDW3/8tJXs49hkEIWM5CHxyTDZTA6vl3mq2oJmhLAwb lDuzIqq6Dxn4Ab8u+ptgpaUTvH7qiugNjS5SwxFMcNePxhcgUf+LAkCFypi9lqOV 1jz0xjH6ppCx4a4ZLSI9sB7fMbUehUBN8Hc/9ZcGpLFZYpXYMQ65HcFnpiEPLpRW PvMOWnRkty5KqDJ5BTVQVqpqXEc90lxpurylU0megs7LvGCTNbthpxpTORx/gU/A CmKPmg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d46tp4105-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 21:46:31 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35c0bd3a968so311955a91.0 for ; Wed, 25 Mar 2026 14:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774475191; x=1775079991; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EHvpyCZJsypMHVwxXNF2FT+oeJZbUA/sFO+4H7ugunQ=; b=NIbKheCGa+DJWqoyoa/oTTprB4lwzF6P1sPk/PE4XoPzqkmyzT/PhCWqyEoF9YE1qp sxDshiniyEwo2nd3lBWQ5a3Q72esqEPLIqsPZfqXG19xtmLaRvoQE0eBbDfS+3DU6zuY WTclZKSFFT/z1/odFxmb/EnJh3zkjNYenIKoxPCfmD5CPODluqlKniHhtLtcjrul7ZGS AVgRqm2h6IYSvrkuSXiA+zPJQvtDCGk/iqZoEBCA3Fo4UgSc8NAQN7l6vw6mBLfZy5W/ I5RcrPdpFK1HJ6scWzbr2A2tbrnOmUPmGHYeTcbpyDFxy9/Glf3nfd7aKWKdbZnX8oKZ s/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774475191; x=1775079991; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EHvpyCZJsypMHVwxXNF2FT+oeJZbUA/sFO+4H7ugunQ=; b=J7S/FFrI3O3bGbyPqmEid9eTHT4iE2+BAPUr7GDS1fC9pCD7E52GAfWpIxWGuipHSq ZKn2R6hZQUE1qlVWwtwHckeQNe3I9d0Qoserh++ATyFxY/Ui4XSrrEQ9/8avf4jlF7hJ kqTSPG9818pq0Z1PY6ghOYu+x9TDKSXD4YWDdsfXFx8xYbP5qa/oR8OItKKBLL3TmETT LeWVJqqRUgh9L3/V6dUtouv8rY1s7iBIfRNMPv9+TTKcJQ87XBIgcPg+U65NSl5E1zvu N5UqjGxqYZz359jjyKUjKFmMIlMJpmBV/7oE3FKgQRT9c5q9GwLWbgEZvPrxmMFjYaEE kS+Q== X-Forwarded-Encrypted: i=1; AJvYcCV/12+iI01YoTGf3R3ZJiG+P2G0WIZTxvrs/Gbnc/dmK4xISCIvK4jqP8N4wTxYz6qy8XR3OwQwXN1ndlE=@vger.kernel.org X-Gm-Message-State: AOJu0YzYkdrEaxnwmytKRwBWuwpLjIUgAEm0c26EI8qprgMUouoiyYVv KtnbYYRibRbV8O9ua9nyiUpvMv58B98Qt0cx4BMhXBZ9V/fS9UJ2SwwpkQHJIcczcAQj5606SLX qgMIJTcujxh43B+WHY/AG1szHFwyCd5PCfD+RrWK2kOTyTZV/4E3InR3jRZIRlkYI8HE= X-Gm-Gg: ATEYQzyZwLPo3c7CLSs8sFjO7aESHdGVlYdp8M/pVeBe3XvruLawnQOfoGdC5eUgCN0 Zt169OYuDibUqYW/RluytmCuxE2v64Y6N/oPswXZO+hqn9bgIJ8dp5S5jKRDk1Ww552+6Lze+CI Bf11RHUfC0kHVt1HT97PuzmCrnYXn7lMJp6UCpYlmu5xJH9bM9KpE748EXMW+PlxlVExcL16ueD 3C9xfxgr3Ms/ralHzvzDY9OUMy+JPZEdiHjEhKoYE4RzZGYmKvd8mI90m+BhpHmg/1lc3jVaifn dzgDN7Yu5oG1dlWnTiQ0DSuqptYRklkVxgDtMvAKX0ghGu3hhAwHguBbvvVzyPI9InZRHKqdQdz PKqU5qfLCMj0pOBG5kgJCfFdovHb64rAeZLb7es5PAbZH X-Received: by 2002:a05:6a20:a103:b0:39b:ef0f:a6e with SMTP id adf61e73a8af0-39c4ab517ebmr5713779637.11.1774475190961; Wed, 25 Mar 2026 14:46:30 -0700 (PDT) X-Received: by 2002:a05:6a20:a103:b0:39b:ef0f:a6e with SMTP id adf61e73a8af0-39c4ab517ebmr5713758637.11.1774475190480; Wed, 25 Mar 2026 14:46:30 -0700 (PDT) Received: from [192.168.1.7] ([106.222.235.17]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7673978668sm378870a12.27.2026.03.25.14.46.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 14:46:30 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 03:16:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] drm/msm/a6xx: Switch to preemption safe AO counter To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-2-fc95b8d9c017@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: zliLOqppO85S4ky1lPsOWh9ihk3K52G2 X-Authority-Analysis: v=2.4 cv=F4lat6hN c=1 sm=1 tr=0 ts=69c457b7 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=yg4K9g8yQ9z8uKSC4i4MOg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=NwhR0-MFI0zYuXa4w7wA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: zliLOqppO85S4ky1lPsOWh9ihk3K52G2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDE1OSBTYWx0ZWRfXxeLWwYchs+P3 x4fbOX2Egi2gvGSWKRjVxtxv7zG1ysksxL5yx6k7xux32P1OLbJ20gGxw/BqCjuBHdrQBudGDVw +FC3wwrLkvB3jI6u6LhZpBHUim8OQa3hAXsCghYFknnpiMo+fbS42fsnhPQk4g7bbhZB+bPgjqt w7SuRdg2XzaRaiUda3Ee+Bh/P5f+mPFCoAAc55e3F3Y0CAElwrNV7KJ2vIYt7XVhfabNZvoTN0v r5wXlP7gJOIi5owe7crTWpezjyYNdkMQWbSYy6rxEB3izVgUUtkNE2ykMLuXSIjNaw4z5oDKNkA uTNqDGphu9wXW50s0v7uGIsbuLAEVgB5Xb5OvpN3LGn4NbL5TvzGpwq04rI+jHYrDtdWqvgFpCz NPJ7JNExyjgI6IAlC8yjWZPN/fgdbvEmjkRl0l64LGkZuicEot88te5cCPNrlV/0JA6k5qL3+Th DBEuipqOLyr4ypPEYCA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_05,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250159 On 3/24/2026 3:21 PM, Konrad Dybcio wrote: > On 3/23/26 9:12 PM, Akhil P Oommen wrote: >> CP_ALWAYS_ON_COUNTER is not save-restored during preemption, so it won't >> provide accurate data about the 'submit' when preemption is enabled. >> Switch to CP_ALWAYS_ON_CONTEXT which is preemption safe. >> >> Fixes: e7ae83da4a28 ("drm/msm/a6xx: Implement preemption for a7xx targets") >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> index 14d5b5e266f7..93bf2c40bfb9 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> @@ -345,7 +345,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) >> * GPU registers so we need to add 0x1a800 to the register value on A630 >> * to get the right value from PM4. >> */ >> - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, >> + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, >> rbmemptr_stats(ring, index, alwayson_start)); >> >> /* Invalidate CCU depth and color */ >> @@ -386,7 +386,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) >> >> get_stats_counter(ring, REG_A6XX_RBBM_PERFCTR_CP(0), >> rbmemptr_stats(ring, index, cpcycles_end)); >> - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, >> + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, >> rbmemptr_stats(ring, index, alwayson_end)); >> >> /* Write the fence to the scratch register */ >> @@ -478,10 +478,10 @@ static void a7xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) >> >> if (adreno_is_a8xx(adreno_gpu)) { >> rbbm_perfctr_cp0 = REG_A8XX_RBBM_PERFCTR_CP(0); >> - cp_always_on_counter = REG_A8XX_CP_ALWAYS_ON_COUNTER; >> + cp_always_on_counter = REG_A8XX_CP_ALWAYS_ON_CONTEXT; > > I'm a little worried about mixing the names here - KGSL uses both of > these registers (A6XX_KERNEL_PROFILE vs A6XX_KERNEL_PROFILE_CONTEXT) > to track different fields of the struct adreno_drawobj_profile_entry But this naming aligns with the HW reg spec. So I prefer to use the same. -Akhil > > Konrad