mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Carlo Caione <carlo@caione.org>,
	open list <linux-kernel@vger.kernel.org>
Cc: Linux Upstreaming Team <linux@endlessm.com>,
	bardliao@realtek.com, oder_chiou@realtek.com,
	alsa-devel@alsa-project.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO
Date: Thu, 15 Feb 2018 10:17:45 +0100	[thread overview]
Message-ID: <cb4736e2-bcc0-c8da-efd9-7d5ea7f23d25@redhat.com> (raw)
In-Reply-To: <CAOQ7t2ZHisZRPq6tKL3QNuKWQFNpVpJ-DoPdM80jMx8u7J=fBg@mail.gmail.com>

Hi,

On 15-02-18 10:11, Carlo Caione wrote:
> On Fri, Feb 9, 2018 at 2:23 PM, Carlo Caione <carlo@caione.org> wrote:
>> From: Carlo Caione <carlo@endlessm.com>
>>
>> On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in
>> the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to
>> the rt5645 driver to enable the jack detection also on non-DT platforms.
> 
> Please do not merge this yet, I'll submit a V3 soon.
> Hans pointed out that on some BayTrail there is indeed an extra GPIO
> but it is used to enable the external speaker amplifier. Better to
> guard this by a quirk.

Thank you Carlo, note that the tablet I was talking about is a rt5651 based
tablet, but yes you never know for what reasons someone will put an extra
GPIO in the resources table, so guarding this with a quirk seems like a good
idea.

Regards,

Hans

      reply	other threads:[~2018-02-15  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 14:23 Carlo Caione
2018-02-09 14:50 ` Andy Shevchenko
2018-02-15  9:11 ` Carlo Caione
2018-02-15  9:17   ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb4736e2-bcc0-c8da-efd9-7d5ea7f23d25@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bardliao@realtek.com \
    --cc=carlo@caione.org \
    --cc=carlo@endlessm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=oder_chiou@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®