mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Icenowy Zheng <zhengxingda@iscas.ac.cn>
To: Dominique Belhachemi <domibel@debian.org>
Cc: Maxime Ripard <mripard@kernel.org>,
	Maarten Lankhorst	 <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	Paul Cercueil <paul@crapouillou.net>,
	 Michal Wilczynski <m.wilczynski@samsung.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: verisilicon: support non-coherent DMA framebuffers
Date: Tue, 05 May 2026 17:27:33 +0800	[thread overview]
Message-ID: <cb47f13a5901d15a135cc4a4128d542ddc24a0bb.camel@iscas.ac.cn> (raw)
In-Reply-To: <1452a2d0d1f32afbd37fad2935a6e137c1e707be.camel@iscas.ac.cn>

在 2026-05-05二的 17:05 +0800,Icenowy Zheng写道:
> 在 2026-05-05二的 04:26 +0000,Dominique Belhachemi写道:
> > Wire up the standard non-coherent path matching the ingenic DRM
> > driver.
> 
> Ah I forgot that my test platform is also noncoherent -- it uses
> uncached memory map instead of cache maintenance.
> 
> Should some other facility to be wired in to check whether cache
> maintenance or uncached mapping is available and use that
> functionality?

Ah forgot to mention that drm/imagination driver requires uncached
mapping too, and this seems to be difficult to lower (currently
impossible because the userspace only does Vulkan coherent map now).

Thanks,
Icenowy

> 
> Thanks,
> Icenowy
> 
> > 
> > Tested on StarFive JH7110 (VisionFive 2 v1.3B).
> > 
> > Signed-off-by: Dominique Belhachemi <domibel@debian.org>
> > ---
> >  drivers/gpu/drm/verisilicon/vs_drm.c          | 31
> > +++++++++++++++++--
> >  drivers/gpu/drm/verisilicon/vs_drm.h          |  7 +++++
> >  .../gpu/drm/verisilicon/vs_primary_plane.c    | 11 ++++++-
> >  3 files changed, 46 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/verisilicon/vs_drm.c
> > b/drivers/gpu/drm/verisilicon/vs_drm.c
> > index fd259d53f49f..52d8749445df 100644
> > --- a/drivers/gpu/drm/verisilicon/vs_drm.c
> > +++ b/drivers/gpu/drm/verisilicon/vs_drm.c
> > @@ -4,7 +4,7 @@
> >   */
> >  
> >  #include <linux/aperture.h>
> > -#include <linux/dma-mapping.h>
> > +#include <linux/of_address.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/module.h>
> >  #include <linux/regmap.h>
> > @@ -49,6 +49,31 @@ static int vs_gem_dumb_create(struct drm_file
> > *file_priv,
> >  
> >  DEFINE_DRM_GEM_FOPS(vs_drm_driver_fops);
> >  
> > +static struct drm_gem_object *vs_gem_create_object(struct
> > drm_device
> > *drm,
> > +						   size_t size)
> > +{
> > +	struct drm_gem_dma_object *obj;
> > +
> > +	obj = kzalloc_obj(*obj);
> > +	if (!obj)
> > +		return ERR_PTR(-ENOMEM);
> > +
> > +	obj->map_noncoherent = to_vs_drm_dev(drm)->noncoherent;
> > +
> > +	return &obj->base;
> > +}
> > +
> > +static struct drm_framebuffer *
> > +vs_gem_fb_create(struct drm_device *drm, struct drm_file *file,
> > +		 const struct drm_format_info *info,
> > +		 const struct drm_mode_fb_cmd2 *mode_cmd)
> > +{
> > +	if (to_vs_drm_dev(drm)->noncoherent)
> > +		return drm_gem_fb_create_with_dirty(drm, file,
> > info,
> > mode_cmd);
> > +
> > +	return drm_gem_fb_create(drm, file, info, mode_cmd);
> > +}
> > +
> >  static const struct drm_driver vs_drm_driver = {
> >  	.driver_features	= DRIVER_MODESET | DRIVER_GEM |
> > DRIVER_ATOMIC,
> >  	.fops			= &vs_drm_driver_fops,
> > @@ -58,12 +83,13 @@ static const struct drm_driver vs_drm_driver =
> > {
> >  	.minor	= DRIVER_MINOR,
> >  
> >  	/* GEM Operations */
> > +	.gem_create_object	= vs_gem_create_object,
> >  	DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vs_gem_dumb_create
> > ),
> >  	DRM_FBDEV_DMA_DRIVER_OPS,
> >  };
> >  
> >  static const struct drm_mode_config_funcs vs_mode_config_funcs = {
> > -	.fb_create		= drm_gem_fb_create,
> > +	.fb_create		= vs_gem_fb_create,
> >  	.atomic_check		= drm_atomic_helper_check,
> >  	.atomic_commit		= drm_atomic_helper_commit,
> >  };
> > @@ -98,6 +124,7 @@ int vs_drm_initialize(struct vs_dc *dc, struct
> > platform_device *pdev)
> >  
> >  	drm = &vdrm->base;
> >  	vdrm->dc = dc;
> > +	vdrm->noncoherent = !of_dma_is_coherent(dev->of_node);
> >  	dc->drm_dev = vdrm;
> >  
> >  	ret = drmm_mode_config_init(drm);
> > diff --git a/drivers/gpu/drm/verisilicon/vs_drm.h
> > b/drivers/gpu/drm/verisilicon/vs_drm.h
> > index 606338206a42..17704cd0df1d 100644
> > --- a/drivers/gpu/drm/verisilicon/vs_drm.h
> > +++ b/drivers/gpu/drm/verisilicon/vs_drm.h
> > @@ -18,8 +18,15 @@ struct vs_drm_dev {
> >  
> >  	struct vs_dc *dc;
> >  	struct vs_crtc *crtcs[VSDC_MAX_OUTPUTS];
> > +
> > +	bool noncoherent;
> >  };
> >  
> > +static inline struct vs_drm_dev *to_vs_drm_dev(struct drm_device
> > *drm)
> > +{
> > +	return container_of(drm, struct vs_drm_dev, base);
> > +}
> > +
> >  int vs_drm_initialize(struct vs_dc *dc, struct platform_device
> > *pdev);
> >  void vs_drm_finalize(struct vs_dc *dc);
> >  void vs_drm_shutdown_handler(struct vs_dc *dc);
> > diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > b/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > index e8fcb5958615..0049737f492b 100644
> > --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > @@ -8,6 +8,7 @@
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_atomic_helper.h>
> >  #include <drm/drm_crtc.h>
> > +#include <drm/drm_fb_dma_helper.h>
> >  #include <drm/drm_fourcc.h>
> >  #include <drm/drm_framebuffer.h>
> >  #include <drm/drm_gem_atomic_helper.h>
> > @@ -16,8 +17,9 @@
> >  #include <drm/drm_print.h>
> >  
> >  #include "vs_crtc.h"
> > -#include "vs_plane.h"
> >  #include "vs_dc.h"
> > +#include "vs_drm.h"
> > +#include "vs_plane.h"
> >  #include "vs_primary_plane_regs.h"
> >  
> >  static int vs_primary_plane_atomic_check(struct drm_plane *plane,
> > @@ -86,6 +88,8 @@ static void
> > vs_primary_plane_atomic_disable(struct
> > drm_plane *plane,
> >  static void vs_primary_plane_atomic_update(struct drm_plane
> > *plane,
> >  					   struct drm_atomic_state
> > *atomic_state)
> >  {
> > +	struct drm_plane_state *old_state =
> > drm_atomic_get_old_plane_state(atomic_state,
> > +								
> > 	   plane);
> >  	struct drm_plane_state *state =
> > drm_atomic_get_new_plane_state(atomic_state,
> >  								  
> >   
> >    plane);
> >  	struct drm_framebuffer *fb = state->fb;
> > @@ -101,6 +105,8 @@ static void
> > vs_primary_plane_atomic_update(struct
> > drm_plane *plane,
> >  		return;
> >  	}
> >  
> > +	drm_fb_dma_sync_non_coherent(plane->dev, old_state,
> > state);
> > +
> >  	vcrtc = drm_crtc_to_vs_crtc(crtc);
> >  	output = vcrtc->id;
> >  	dc = vcrtc->dc;
> > @@ -169,5 +175,8 @@ struct drm_plane *vs_primary_plane_init(struct
> > drm_device *drm_dev, struct vs_dc
> >  
> >  	drm_plane_helper_add(plane,
> > &vs_primary_plane_helper_funcs);
> >  
> > +	if (to_vs_drm_dev(drm_dev)->noncoherent)
> > +		drm_plane_enable_fb_damage_clips(plane);
> > +
> >  	return plane;
> >  }


  reply	other threads:[~2026-05-05  9:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  4:26 Dominique Belhachemi
2026-05-05  9:03 ` Icenowy Zheng
2026-05-05 10:22   ` Chen-Yu Tsai
2026-05-05 22:25   ` Dominique Belhachemi
2026-05-06  9:01     ` Icenowy Zheng
2026-05-06 17:38       ` Dominique Belhachemi
2026-05-06 18:00         ` Icenowy Zheng
2026-05-05  9:05 ` Icenowy Zheng
2026-05-05  9:27   ` Icenowy Zheng [this message]
2026-09-11 15:33 ` Icenowy Zheng
2026-09-28  5:21   ` Dominique Belhachemi
2026-09-29  7:27     ` Icenowy Zheng
2026-09-30  5:52       ` Dominique Belhachemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb47f13a5901d15a135cc4a4128d542ddc24a0bb.camel@iscas.ac.cn \
    --to=zhengxingda@iscas.ac.cn \
    --cc=airlied@gmail.com \
    --cc=domibel@debian.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.wilczynski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=paul@crapouillou.net \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®