mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: Curtis Vogt <curtis.vogt@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pierre-Loup Griffais <pgriffais@valvesoftware.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/3] HID: valve-index: Reboot headset on system power transitions
Date: Thu, 10 Sep 2026 15:58:27 -0500	[thread overview]
Message-ID: <cb4d4f93-2e34-4c5b-b400-06fb01b6b04c@amd.com> (raw)
In-Reply-To: <20260910225259.66b480c6.michal.pecio@gmail.com>



On 9/10/26 15:52, Michal Pecio wrote:
> On Thu, 10 Sep 2026 15:43:18 -0500, Mario Limonciello wrote:
>>>> +/*
>>>> + * The headset's EDID service is lost when the host disables the DisplayPort
>>>> + * PHY during system suspend, so it needs the reboot on the way out of
>>>> + * suspend.  Doing it on the way in does not work: the headset dropping off
>>>> + * USB is a remote-wakeup event from its hub and aborts the suspend.
>>>> + */
>>>
>>> The internal hub which will be quirked by the next patch, or its parent?
>>
>> It has to be the internal hub if quirking it works, no?
> 
> I believe there are two separate problems here:
> 
> 1. resetting the device at suspend causes instant wakeup
> 2. a few seconds later the system wakes up anyway
> 
> 1. is solved by resetting on resume rather than suspend
> 2. is solved by the quirk
> 
> Questions:
> 
> Any chance that 2 also solves 1?
> Would resetting on suspend be preferable, as the comment suggests?
> Maybe it would, if the reset can race with DP seeing empty EDID?
> 
I do think that resetting on suspend makes a lot more sense for that 
exact reason.  That's why my original PoC did it that way.

That's a very good idea to see if the quirk + moving it back to suspend 
works.

  reply	other threads:[~2026-09-10 20:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 17:02 [PATCH 0/3] Add 'hid-valve-index' reset driver Mario Limonciello
2026-09-10 17:02 ` [PATCH 1/3] HID: Add shutdown callback for device drivers Mario Limonciello
2026-09-10 17:02 ` [PATCH 2/3] HID: valve-index: Reboot headset on system power transitions Mario Limonciello
2026-09-10 20:04   ` Michal Pecio
2026-09-10 20:43     ` Mario Limonciello
2026-09-10 20:52       ` Michal Pecio
2026-09-10 20:58         ` Mario Limonciello [this message]
2026-09-12 14:07           ` Curtis Vogt
2026-09-11  4:54       ` Curtis Vogt
2026-09-11  9:08         ` Michal Pecio
2026-09-11  5:54   ` Greg Kroah-Hartman
2026-09-11  6:01     ` Mario Limonciello
2026-09-11  9:16     ` Michal Pecio
2026-09-11  9:23       ` Greg Kroah-Hartman
2026-09-11 15:12         ` Mario Limonciello
2026-09-11 18:20           ` Michal Pecio
2026-09-10 17:02 ` [PATCH 3/3] USB: quirks: Ignore remote wakeup from the Valve Index breakout box hub Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb4d4f93-2e34-4c5b-b400-06fb01b6b04c@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=bentiss@kernel.org \
    --cc=curtis.vogt@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.pecio@gmail.com \
    --cc=pgriffais@valvesoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®