From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f226.google.com (mail-pf1-f226.google.com [209.85.210.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE8CE358D20 for ; Thu, 22 Jan 2026 19:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769109461; cv=none; b=M5UviP2CwQIrYGkSxsCKTdimXQ21JZvX+mFjstaw1hu8qiAdEs1MzW2hoBeZCgiJ+Ze24onxADQM6Aqx6W9FzhS0PxOQXn7t3+vEwwKatcODEhSsDm8olJVeZrA0sch5TdwuXHAAuvwuTtL6uLzUrnDkAKcdQVYMQTRGkR3VvdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769109461; c=relaxed/simple; bh=tEPT05n2Q9wBV7F2HsYew34a4H/4RFfQ3k0++weScEA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CJ3jp93BKt3AaInpb/0bB5XvuyQz0CjflvJrFKqCemXr61r3XBNulB9RvJs2c1H+YChOsbIDQA5nfoYfRHDvPa4Nlg2l/+k2/666LfOeEl23P41BZJoY3d03FhK8y7yDR9tbNAVpFeLMCmLS9AGjNnB9piJxPqWun4AyPchcZ2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=UPQO33jy; arc=none smtp.client-ip=209.85.210.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="UPQO33jy" Received: by mail-pf1-f226.google.com with SMTP id d2e1a72fcca58-82311f4070cso321173b3a.0 for ; Thu, 22 Jan 2026 11:17:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769109452; x=1769714252; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=71tizYyQqK+qEeiQ91p1bi+H6ziLWzyeylLQFrcF44E=; b=Eaf3rsKbt5V+1DUkiQIw7P5MsC2un3voN4S1m4Br6fSOGYnF6JTo5QnWMSsl4CbgzH suZLgpgNW0PZCfwzK66NhYtFU4rEHesbE6tVz9D0+4ZH6tzEAdOyYDagmtiqxZ6jC7zi v6WgNn7G7+9Wb8SgCAhNm+ZT1EVUy/56mdsRiwQ3FAdsW8bns5sroWS7sIZMZgevqD3s bx/PUDGOuxEwP9IL0pIb1Bjjr/uE3K1+gLdhkcjBFN3MFoE9Vp2D0plQontdqYM28IpW 33yg+Ru7woO+gUSVhFzoxIG145sSYG8rI1oFujFwk/ZUzXM1rmdv/EPDmFH+hKao5ikV dBmg== X-Gm-Message-State: AOJu0YzkpiRVth+fTL+oRmwMH/MJDJ7L5dFPlrWAax8Fxpi5GnfS3Kcr jCmOCQ4vWyEMlmndd+imD/EoSwEjPousN7lDx+a8Edmm7wztCYV8xzV1pp8+Zj3ITlPqgN3/vcf VsLJt3jMukqRky0o6xcAAbx/CWsgE8HKxQa2FgwaeOQlEiU7pVQyQ735JUuJKZX0k7lkqUzqnIQ nQQwe1bTvngwu8tmq/MQ8xs0Kny3h8XjVFiLEBU7ooffF/iR5YaKs4d2QX9v6HzLTU2aSaRU1/z 8CCJRqRjlIRVydPcgAJlILt X-Gm-Gg: AZuq6aLnEcD1FJd7cez0Ym+ZQUeChm3kCQ6NW3kpljq3f7QPH7GShirYZak76C7oeDu 4fUMtNtRYjrmaWM9w2LKnvw5eKFG/Oyk4trudNYrf5ThP7eLtA2GQ78kdsyu8TaDcxNDHh4PRL5 oIhr6iTizApmZzJoBkpqTj7kcnluHpg2IDSNI/t0+CIbSiEhkKktkDaUpjsud9WlOtdmuL9TD0S yI3lz0HwiLbZ6MjoChzX8/bJVDCaM6XWCKGZQ2PDdCYoHN5qNWJFZXLT0/x1iCfQ+bYVSyTd9it BLOIFj/N0LAvWu/TynHLa391SYEKqDQ4ku7mFO5ZGQcThyvZXUhoYssMpvYY4SyDw3r6j4qHoXC TPGG1c1XgclVw61+4l49Lx8uuBtNadCUQjTfAJ5K7NYbXIis9AS2wk5C7XqF8Dl5DpLziE2OVli lyjffxORyOjLn6gdGyQQrEEVyRkqMoGVJtdt20dupJ4kOLMlYd4R9Q X-Received: by 2002:a05:6a00:1995:b0:81f:c6cf:91cc with SMTP id d2e1a72fcca58-821978fd078mr3786088b3a.9.1769109451742; Thu, 22 Jan 2026 11:17:31 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-118.dlp.protect.broadcom.com. [144.49.247.118]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-823186eabb4sm18607b3a.5.2026.01.22.11.17.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2026 11:17:31 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2b71041d135so1618788eec.1 for ; Thu, 22 Jan 2026 11:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769109450; x=1769714250; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=71tizYyQqK+qEeiQ91p1bi+H6ziLWzyeylLQFrcF44E=; b=UPQO33jyy3q6o7BKpemSBUGHpey2MiHB4W8PqlANAwGgQ6HqNr51b84chpe8nXrAz3 iB6gksIflS1ye23SRDVOc4ruIg/pYIaMBViOe82/0BV8KCcejkomuf/V/Qul+JP0A2wV Q8al2U4yCghBVAAjTURSLIkU2wDMVLeMQP59w= X-Received: by 2002:a05:7022:613:b0:11b:c86b:3870 with SMTP id a92af1059eb24-1247d74215cmr260425c88.4.1769109450028; Thu, 22 Jan 2026 11:17:30 -0800 (PST) X-Received: by 2002:a05:7022:613:b0:11b:c86b:3870 with SMTP id a92af1059eb24-1247d74215cmr260397c88.4.1769109449292; Thu, 22 Jan 2026 11:17:29 -0800 (PST) Received: from [10.63.25.133] ([12.75.221.34]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1247d997f7bsm611297c88.11.2026.01.22.11.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 11:17:28 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 11:17:24 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gpio: brcmstb: implement irq_mask_ack To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Doug Berger , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Christophe Leroy , "open list:GPIO SUBSYSTEM" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20260122010516.1200630-1-florian.fainelli@broadcom.com> <20260122010516.1200630-3-florian.fainelli@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/21/2026 11:36 PM, Andy Shevchenko wrote: > On Thu, Jan 22, 2026 at 3:06 AM Florian Fainelli > wrote: >> >> From: Doug Berger >> >> The irq_mask_ack operation is slightly more efficient than doing >> irq_mask and irq_ack separately. > > I would refer to the callbacks as > > .irq_mask() > .irq_ack() > > et cetera. Ack. > >> More importantly for this driver it bypasses the check of >> irqd_irq_masked ensuring a previously masked but still active >> interrupt gets remasked if unmasked at the hardware level. This >> allows the driver to more efficiently unmask the wake capable >> interrupts when quiescing without needing to enable the irqs >> individually to clear the irqd_irq_masked state. > > ... > >> -// Copyright (C) 2015-2017 Broadcom >> +// Copyright (C) 2015-2026 Broadcom > > Shouldn't it be rather 2015-2017,2026 ? (In one case when I updated a > driver for Intel, I went via Git history to gather the info.) Ack. > > ... > >> static void brcmstb_gpio_set_imask(struct brcmstb_gpio_bank *bank, >> - unsigned int hwirq, bool enable) >> + unsigned int hwirq, bool enable, bool ack) > > This type of interface is usually discouraged as it makes code harder > to read and follow. Since there are a lot of duplication, I recommend > to move the ack op to a separate helper. Good point, knowing the order and what set in those parameters can be confusing. > > ... > >> - gpio_generic_write_reg(&bank->chip, >> - priv->reg_base + GIO_MASK(bank->id), imask); >> + if (ack) >> + gpio_generic_write_reg(&bank->chip, >> + priv->reg_base + GIO_MASK(bank->id), >> + imask); > > Id est this piece... > > > >> +static void brcmstb_gpio_irq_mask_ack(struct irq_data *d) >> +{ >> + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); >> + struct brcmstb_gpio_bank *bank = gpiochip_get_data(gc); >> + >> + brcmstb_gpio_set_imask(bank, d->hwirq, false, true); > > ...and call it here explicitly (seems the only place for it, so it can > even be just moved here without an intermediate helper). Will do, thanks! -- Florian