From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdH3Nh3 (ORCPT ); Wed, 30 Aug 2017 09:37:29 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59802 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbdH3Nh1 (ORCPT ); Wed, 30 Aug 2017 09:37:27 -0400 Subject: Re: [PATCH v3 03/11] staging: typec: fusb302: Set max supply voltage to 5V To: Hans de Goede , Darren Hart , Andy Shevchenko , Wolfram Sang , Sebastian Reichel , Greg Kroah-Hartman , Heikki Krogerus Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Liam Breck , Tony Lindgren , linux-pm@vger.kernel.org, devel@driverdev.osuosl.org, "Yueyao (Nathan) Zhu" References: <20170830094814.17758-1-hdegoede@redhat.com> <20170830094814.17758-4-hdegoede@redhat.com> From: Guenter Roeck Message-ID: Date: Wed, 30 Aug 2017 06:37:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170830094814.17758-4-hdegoede@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/30/2017 02:48 AM, Hans de Goede wrote: > Anything higher then 5V may damage hardware not capable of it, so > the only sane default here is 5V. If a board is able to handle a > higher voltage that should come from board specific data such as > device-tree and not be hard coded into the fusb302 code. > > Cc: "Yueyao (Nathan) Zhu" > Signed-off-by: Hans de Goede Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/fusb302/fusb302.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c > index 03a3809d18f0..6baed06a3c0d 100644 > --- a/drivers/staging/typec/fusb302/fusb302.c > +++ b/drivers/staging/typec/fusb302/fusb302.c > @@ -1187,9 +1187,9 @@ static const struct tcpc_config fusb302_tcpc_config = { > .nr_src_pdo = ARRAY_SIZE(src_pdo), > .snk_pdo = snk_pdo, > .nr_snk_pdo = ARRAY_SIZE(snk_pdo), > - .max_snk_mv = 9000, > + .max_snk_mv = 5000, > .max_snk_ma = 3000, > - .max_snk_mw = 27000, > + .max_snk_mw = 15000, > .operating_snk_mw = 2500, > .type = TYPEC_PORT_DRP, > .default_role = TYPEC_SINK, >