From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A01CC433DB for ; Sat, 16 Jan 2021 23:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29D4F22D50 for ; Sat, 16 Jan 2021 23:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727795AbhAPXkK (ORCPT ); Sat, 16 Jan 2021 18:40:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbhAPXkH (ORCPT ); Sat, 16 Jan 2021 18:40:07 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80982C061574 for ; Sat, 16 Jan 2021 15:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=AoD5f7YvM8N8YtJEZFUziWMNgh5j6/Uyf7sbiChOgO8=; b=kmOJIaGBaVlx8P+pd1wpWhTBrd Ee4avyLWlwlmOalxRZ2TKPG2TdUIt0HY+hkfHFqInP70NeqaOHpHP98UJzjNhctqFVTXAkLhIXJr3 bXuNMgOs/iOurl5viCOfYdhPcvyXrujMuuNj8SVBRJkvXvEkrk0lBQmKjnh1dckOVhNQFgJysLExp 9ey5eoOsXAJuHe20BOVGexBO4fvVmOj/M9awkUgGYjKVZqcfJ2bNtIWCMv/6q4FYy3eWie9khWa/v K19Uh+Ax7Y6pfTth/FavHxL7JwUX2c4IVwzFRq0nYWc/gtdzcFuaKxySDfzQ5K6ls/q0/wxz2eD/r 4PB/wMoA==; Received: from [2601:1c0:6280:3f0::9abc] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0vA9-0005xt-O3; Sat, 16 Jan 2021 23:39:22 +0000 Subject: Re: Missing param value! Expected 'rw=...value...' To: Heiner Kallweit , Xiaoming Ni Cc: Linux Kernel Mailing List References: <27b2e02f-0840-2686-7aad-16274519dcdc@gmail.com> From: Randy Dunlap Message-ID: Date: Sat, 16 Jan 2021 15:39:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <27b2e02f-0840-2686-7aad-16274519dcdc@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/16/21 3:07 PM, Heiner Kallweit wrote: > Since 60b7cab23e5e ("proc_sysctl: fix oops caused by incorrect command parameters.") > I'm getting the following warning: Missing param value! Expected 'rw=...value...' > AFAIK param rw doesn't require a value. That's what my command line looks like: > Command line: initrd=\intel-ucode.img initrd=\initramfs-linux.img root=/dev/sda2 rw > "rw" isn't a sysctl, so it looks like that added test is too early in that function. -- ~Randy You can't do anything without having to do something else first. -- Belefant's Law