From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD06C61DF4 for ; Fri, 24 Nov 2023 10:06:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345437AbjKXKGO (ORCPT ); Fri, 24 Nov 2023 05:06:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345402AbjKXKGK (ORCPT ); Fri, 24 Nov 2023 05:06:10 -0500 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 05156D73; Fri, 24 Nov 2023 02:06:15 -0800 (PST) Received: from [172.30.11.106] (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id 35883613FF940; Fri, 24 Nov 2023 18:06:12 +0800 (CST) Message-ID: Date: Fri, 24 Nov 2023 18:06:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 2/2] wifi: rtlwifi: rtl8821ae: phy: fix an undefined bitwise shift behavior Content-Language: en-US To: Ping-Ke Shih , "dan.carpenter@linaro.org" , "kvalo@kernel.org" , "nathan@kernel.org" , "ndesaulniers@google.com" , "trix@redhat.com" Cc: "lizetao1@huawei.com" , "linville@tuxdriver.com" , "Larry.Finger@lwfinger.net" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "llvm@lists.linux.dev" , "kernel-janitors@vger.kernel.org" X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui In-Reply-To: <167fbc7a77db447d90f696666f6f0a9b@realtek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/11/24 16:51, Ping-Ke Shih wrote: > Subject: [PATCH v2 2/2] wifi: rtlwifi: rtl8821ae: phy: fix an undefined bitwise shift behavior > > [...] >> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c >> b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c >> index 6df270e29e66..52ab1b0761c0 100644 >> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c >> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c >> @@ -31,7 +31,12 @@ static u32 _rtl8821ae_phy_calculate_bit_shift(u32 bitmask) >> { >> u32 i = ffs(bitmask); >> >> - return i ? i - 1 : 32; >> + if (!i) { >> + WARN_ON_ONCE(1); >> + return 0; >> + } >> + >> + return i - 1; >> } > Personally, I prefer to use __ffs(), because in normal case no need additional '-1', > and abnormal cases should not happen. Hi,  Ping-Ke Replace _rtl8821ae_phy_calculate_bit_shift() by __ffs(bitmask) is better, but I'm not sure what callers should do when callers check bitmask is 0 before calling. Maybe this check is useless? I can send a v3 patch if using __ffs(bitmask) and no check for bitmask is fine. Or could you send this patch if you have a better idea? Thanks for your suggestion! Su Hui