From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959583ACF1E for ; Fri, 6 Mar 2026 14:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809192; cv=none; b=Yi/E/Zm6fM2Dkj5PzbD6JS3gLGHnkCc0YVQpqGanml3fcmPpIDDQWgw8fudvS/FBhX5OhpLSTMNqN3FCgLk4QamZlZMlrx+JV7gn/UCWL7taDq2uMHBBqmWWUKba8xjVNHuqCCXCPFs9pmSdiSZXTd1G1W1RgJVvg4BvfXoKV08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809192; c=relaxed/simple; bh=Jdnkgn4TzM9FmMI4HNPLlzFfbmreK2eV70pDyocbis0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=siLI6kzRU9PZuQctIKfae0rAAMIHSRA7KmbzlWU3xWFdB2eieSBbyaPWHOqzeErsDbv/jHRsTdZSfpzpl5dYwOZMgOodrBXEoJCuc+fO6jEhxEGxIY+LzC2b8ANZDKRJb+0iuYhlVQ0RP3hovq1qgy5gSkA7UhaZyqJHSIJPXms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WCHDtMh6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E+tNAXvp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WCHDtMh6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E+tNAXvp" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Bb31L629054 for ; Fri, 6 Mar 2026 14:59:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= i6f1COXjYeremRBrKM7FlVp1/afp7FpybumgeuDEdSw=; b=WCHDtMh6w13y4pb7 juxCuUiLQTLu0QFKNgeo/e6JQhRW1WzJ3m/oEF+LNJWowihVh0hta2MuvFcdxpDy wG5P9nRzPiu8C0s6WCtdGvXDRE2820iDUmj63SawUgoiNRQxbwRq1TTsb6kdVXKe L7Y0dunTtbdGHcT2cKlLGZjZNcu8p6GSFTiA6i2NyMp1qlUsQAGnHlrl8jj7Ww4K YKf4nvOgXn4d4ugfHvLUZHHFc/c7Fh3QuD4dIQ8T9rgQebV5rGzae/UHrt3+TGDk p7rmEJwPFSOPdfFwG/wKaggH/MqWmGXnCLBlielSrz/0I2mltMsFr73SiCTCM8p8 9aLQmQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqj4sb2nk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 14:59:50 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-824a2df507eso26025971b3a.2 for ; Fri, 06 Mar 2026 06:59:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772809190; x=1773413990; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i6f1COXjYeremRBrKM7FlVp1/afp7FpybumgeuDEdSw=; b=E+tNAXvp8TXZbs7/y0qFhG1m7Royf++pegLHoDGeKiHiUrWmtIu7ggklPwIf9GVeko r+3s0wg/PHjC6JHSdA6a2G7zCrmMZtbsuKLgB+G4yNiWe6Ei8j92P8FLMkr/WIJDyPpa dGfRvmyA8SYxewKsAhlWMwt8CtSBqlGr7Zmety19LeHQCtKn9AqQIvwZ3H7G1Y+JA4Pp 95oA9vA0BD5xiipZXulqfvECQA3HT4BQUwTlUZTH6iurYEvh1fJM7UuQPMKgvgmxSjzL ejamVhl60yMnZp+BEfC/WYfCLLwrULeQ155BMi5sG+98gUPy59p5GCjQkeewTwpqFhxE 49DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772809190; x=1773413990; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i6f1COXjYeremRBrKM7FlVp1/afp7FpybumgeuDEdSw=; b=mGMzstH+nlzw3B4hfvLp5yfoJ7DXBJ4vbg7wXp9CyhMqL0PwQE07jH2e+dRMFt2Hht AtNTjCPZOEGqfJl498+nQNpSwxXgYX0ISZ+/ugSE/3kmPTB0ny8ibV5ZhqgBqcnSVTVj 0ve1N8hB6nTnus34YkvhAVIT1Fx2H/pCxVmNNYcJhpJXnu3g6yezihh6wzivce7M2hLk oPfk64IGARAyAMDjXHeBe8RVxWOpXcS8n3AZym3lysTXYLjNo6Hm8w+DdntUOdCv2mR1 tyUafN23tEq77m3123OCgZ1YCiVEv76cg0EeSQXPUaiIvLb2O4kzEUBoYvf2+630zoiL cm+Q== X-Forwarded-Encrypted: i=1; AJvYcCWL/WOqJbrSVoa/y5dpPXMjZqV/JeTQ1BMhiB2ngJ0PgMuMEm19BgNy9YZoF1H0UGaSzYMHoejflrBeQw0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2ovK9sCSdiiEmzlKoMz8keK3ld+OE3qI7P/CObHZET6sCoTFw F7x8vbgnaCS+t8dgUA7HKormKWwaxy2K2EQc4x01JmrZzXiAAlQVbH37Xdd+cQOmUtpNCkf6M0U lmXDlNcRnKqRUAEP3rMi1bN6yON+wiYEZvqdUeRNkbgsvOK/3x+SHBIcdH1r3KppO5ww= X-Gm-Gg: ATEYQzwlU8RlbeTDIO1srVbzyQYg/GcZ1/Qe9/OdzTl6/By1mIRk7wK2DplY6Oxnt4N PlhCb3NrRYJBYqokWPpot7VASZLIPaI/Dq47yhU0RWSrZHsrrOW2G1eFmq13/HuKySQolJItnux 8mpc4m4HCpHCh+RIciGOOVzgsarPHQasntWxbexeDUqLpX/T4TMslk2GpusyGP9UP6ONNxEMg7z qas9o86SwXV9ByFainHZYmeV2UNCPQe6oYmlIfinreHNi/aBeMEJ2leUzq3ewKtR4ZryHkUFDBB ar8aTE6Kb1b7WpDe3rB5xBelZmb2qYfFc//x3Cz167cEAiXGxQEvvB0kFosg20nCqf+RvrKOILe Y0lRHeWMAnjlA6IZliQ8Sj/Zach0KsaV0O++hxOupXzqBYurV9gXCNcmvVsZbPctr6IAmSQY4nR +p3ngSTq9pJWk= X-Received: by 2002:a05:6a00:27a7:b0:81b:1a87:9eb9 with SMTP id d2e1a72fcca58-829a2dca08bmr2370412b3a.25.1772809190244; Fri, 06 Mar 2026 06:59:50 -0800 (PST) X-Received: by 2002:a05:6a00:27a7:b0:81b:1a87:9eb9 with SMTP id d2e1a72fcca58-829a2dca08bmr2370387b3a.25.1772809189723; Fri, 06 Mar 2026 06:59:49 -0800 (PST) Received: from ?IPV6:2401:4900:88f5:81:e13b:ce78:7823:d9c3? ([2401:4900:88f5:81:e13b:ce78:7823:d9c3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829aeea8644sm117824b3a.33.2026.03.06.06.59.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 06:59:49 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 20:29:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] clk: qcom: camcc-x1e80100: Add support for camera QDSS debug clocks To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jagadeesh Kona , Bryan O'Donoghue , Konrad Dybcio , Abel Vesa , Rajendra Nayak , Stephan Gerhold Cc: Ajit Pandey , Imran Shaik , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260304-purwa-videocc-camcc-v2-0-dbbd2d258bd6@oss.qualcomm.com> <20260304-purwa-videocc-camcc-v2-4-dbbd2d258bd6@oss.qualcomm.com> <1d92329d-139d-49aa-8fc4-515e7c574774@kernel.org> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: <1d92329d-139d-49aa-8fc4-515e7c574774@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE0NCBTYWx0ZWRfX2zf9V/d0AxnK a1qAP9M8gFbcwTpXLrydfvAutwT4EptDEL0Xp+dix7jKQet/dB3BmotpRecMY5x3D40Ws1UkhSH p1NUIx+TLZulik/BoafYhjT5VCInGE3BVNL+E+O45w43nFfOCOd0zEOTUuJSd0axdtCJgF2gyt6 L0mtnlE7cMVaM3e7JCk1jjf5gmLiUj3/2oAGiLTWWGKTbMRSUQznfHcqm9obbStsPFaIEtoV1/h FmZ2VbNy2ec1BWvYWRv4gKnxRnWkpOm8lwxpac3C45Nh6DwwuL6eEv3rIJUZjZ7sLHOOrLlwFqE 0yLYxo6S+FBp11aDlqSAjuJFb5YgAk1YMIJypt7opbbPYR3jN2+WTHICyKaLcv+REYR5NkQ1QMi BcMvGabKc2ZAjQJ2TmmMYy6cjWvDI/UdnV5Qlli2wKUgWW10OleA61h8oC31yarPbGQgJClCRo9 p4W9c5vHq73joVEXrfw== X-Proofpoint-ORIG-GUID: qEC-nK0uFlQqYy1Q_9ds7nr9FTiivecW X-Proofpoint-GUID: qEC-nK0uFlQqYy1Q_9ds7nr9FTiivecW X-Authority-Analysis: v=2.4 cv=T8uBjvKQ c=1 sm=1 tr=0 ts=69aaebe7 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=y2yTRUwKQ5IGBUayTIQA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060144 On 3/5/2026 1:23 PM, Krzysztof Kozlowski wrote: > On 04/03/2026 18:40, Jagadeesh Kona wrote: >> static struct clk_branch cam_cc_sfe_0_clk = { >> .halt_reg = 0x133c0, >> .halt_check = BRANCH_HALT, >> @@ -2398,6 +2459,9 @@ static struct clk_regmap *cam_cc_x1e80100_clocks[] = { >> [CAM_CC_PLL6_OUT_EVEN] = &cam_cc_pll6_out_even.clkr, >> [CAM_CC_PLL8] = &cam_cc_pll8.clkr, >> [CAM_CC_PLL8_OUT_EVEN] = &cam_cc_pll8_out_even.clkr, >> + [CAM_CC_QDSS_DEBUG_CLK] = &cam_cc_qdss_debug_clk.clkr, >> + [CAM_CC_QDSS_DEBUG_CLK_SRC] = &cam_cc_qdss_debug_clk_src.clkr, >> + [CAM_CC_QDSS_DEBUG_XO_CLK] = &cam_cc_qdss_debug_xo_clk.clkr, >> [CAM_CC_SFE_0_CLK] = &cam_cc_sfe_0_clk.clkr, > > Continuing review form bindings: > So indeed the this ABI is used by X1E, but commit msg completely missed > that - just said you are adding X1P clocks. > I will update the cover letter that both header & this change needs to be picked together to avoid ABI diff. Thanks, Jagadeesh