From: Jon Hunter <jonathanh@nvidia.com>
To: Aapo Vienamo <avienamo@nvidia.com>, Rob Herring <robh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/7] dt-bindings: Add Tegra PMC pad configuration bindings
Date: Fri, 20 Jul 2018 12:16:04 +0100 [thread overview]
Message-ID: <cb67ced4-eef8-abb5-5706-3282a55edbb2@nvidia.com> (raw)
In-Reply-To: <20180717183020.5ab9bfa6@dhcp-10-21-25-168>
Adding Linus ...
On 17/07/18 16:30, Aapo Vienamo wrote:
...
>>>>> +Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt.
>>>>> +
>>>>> +The values accepted by power-source property are
>>>>> +TEGRA_IO_PAD_VOLTAGE_1V8 and TEGRA_IO_PAD_VOLTAGE_3V3, which are defined
>>>>> +in dt-bindings/pinctrl/pinctrl-tegra-io-pad.h.
>>>>
>>>> You need to list out what properties the child nodes can have.
>>>>
>>>> power-source needs a vendor prefix.
>>>
>>> Isn't it a generic pinctrl property?
>>
>> I don't know offhand. Doesn't look like it if you have custom values.
>
> It's listed under "Supported generic properties" in
> pinctrl-bindings.txt. The convention seems to be not to add a vendor
> prefix even though such custom macro values are used. The property is
> currently used by qcom,pmic-gpio, qcom,pmic-mpp, and renesas,pfc-pinctrl.
> I could not find a bindings document describing it with a vendor prefix.
Looking at other users of the 'power-source' property it is not clear to
me if the values should/can be vendor specific or not. I see cases where
some people use definitions and others use actual voltages.
Linus, any recommendations here?
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2018-07-20 11:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 12:00 [PATCH v3 0/7] Tegra PMC pinctrl pad configuration Aapo Vienamo
2018-07-12 12:00 ` [PATCH v3 1/7] soc/tegra: pmc: Fix pad voltage configuration for Tegra186 Aapo Vienamo
2018-07-12 12:00 ` [PATCH v3 2/7] soc/tegra: pmc: Factor out DPD register bit calculation Aapo Vienamo
2018-07-12 12:00 ` [PATCH v3 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered() Aapo Vienamo
2018-07-12 12:00 ` [PATCH v3 4/7] soc/tegra: pmc: Use X macro to generate IO pad tables Aapo Vienamo
2018-07-12 12:00 ` [PATCH v3 5/7] dt-bindings: Add Tegra PMC pad configuration bindings Aapo Vienamo
2018-07-16 15:43 ` Rob Herring
2018-07-17 12:23 ` Aapo Vienamo
2018-07-17 14:22 ` Rob Herring
2018-07-17 15:30 ` Aapo Vienamo
2018-07-20 11:16 ` Jon Hunter [this message]
2018-07-29 20:54 ` Linus Walleij
2018-07-12 12:00 ` [PATCH v3 6/7] soc/tegra: pmc: Remove public pad voltage APIs Aapo Vienamo
2018-07-12 12:00 ` [PATCH v3 7/7] soc/tegra: pmc: Implement pad configuration via pinctrl Aapo Vienamo
2018-07-12 13:01 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb67ced4-eef8-abb5-5706-3282a55edbb2@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=avienamo@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome