From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbdJCUP7 (ORCPT ); Tue, 3 Oct 2017 16:15:59 -0400 Received: from mout.web.de ([212.227.17.11]:50319 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdJCUP4 (ORCPT ); Tue, 3 Oct 2017 16:15:56 -0400 Subject: [PATCH 3/4] ARM: OMAP: Use kcalloc() in omap_system_dma_probe() From: SF Markus Elfring To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Aaro Koskinen , Russell King , Tony Lindgren Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Tue, 3 Oct 2017 22:15:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:wLMKMtN4PbrP7xUT3zLrnAt0xvxzvFswkMz67vbQisw297VUNh6 w+GNSfHC8JJV5AlhR/oDaFn2jGd4CjcfPmgUfmgiXjo9p8dQgQ0ypNU3nQ73SrGusSA5jEm mm+IIcHd5q0MhEdfLvE75RimPlI4ub81TtojofwioqMbpPFz35VFji3w++xmUo8VmOhtSw7 1Ae9PV6FLcD6EfthdnI2g== X-UI-Out-Filterresults: notjunk:1;V01:K0:uoHxXGqIok0=:cv1Mx8Pny8BeuFx/Li+sYc N/l04wrl8awZjL+xzqQY+cbUSf5YPwjZfXnn2UbiGZ9/0ddmN5xSKWBIzM4I6kQBJ0EI/Vktc 58Pp+OOdGHBddus8SLr08a6x5ZU1G5+Z8/R3leJVMWkBtRfPerA0NqeITPpPlCbXO4ByMmU0T yn/rf0XBnL4d4XA26KAiCRNYD8FLI1hvlB3pDO5VQIq9deLsZos29WJF3ZAd3E77nChZ95Skv 7c26bW3v5MrkmTjG5aSBIBDbGIezrTMxcq2eJYUx/QnAKKx+ceqdnb4OW1aPGpIpIRVYy/ByM UOXW1SCh2GzpscIMuRJZ5mVxah2WtzdcyCFF0enoPI4pvtl6zuKLyF+y5JbvvhUaLCajd10Pc LQVrMnnnnx1h8kSeSXTGQuce4aUtRAKvfu3Xpnr9mDu2KDwPNsHwbYgWna0Q99cxmCt+oTZTh gEQ70ZGi74C7yGtvsKayHaHgfKsf5e4jug2/pU17et7KKdHl5WLDZgw9Nc/abW9LGM/DjEOqx UqJSFeQXcfKG6hS4/GQTebNLW487N//7TlPtOOPGyuYdEllQUER2W5XI5nmtMeGSnoxkEgsqQ uHNlNX7BDufMs/AL7fOx9AYTfrWQjTTiFsuzAySS/fzgHKjL1RCg+BYUvHib1AtTtQS6zxLgb cSv9Rdwasi/q7QzhTAQkMWliXp1w+TeBJvUJWsu3eVlZRput6aLJukLHnpfL7TPET2BeGsog3 ODFycnsQQp7KG2greyZfecEI9ILFZZ+kI0VBCCzCOwm+jeX4wnrRYcKxroX/kj66iz1qJYpAB 1pu87wY1C0+Eky6tMp3sSniwBlsvCJ25eHqSv/b85JgKJyxtsk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 3 Oct 2017 21:07:33 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/arm/plat-omap/dma.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 409e4ecaebe9..d4012d6c0dcb 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -1321,8 +1321,9 @@ static int omap_system_dma_probe(struct platform_device *pdev) return -ENOMEM; if (dma_omap2plus()) { - dma_linked_lch = kzalloc(sizeof(struct dma_link_info) * - dma_lch_count, GFP_KERNEL); + dma_linked_lch = kcalloc(dma_lch_count, + sizeof(*dma_linked_lch), + GFP_KERNEL); if (!dma_linked_lch) { ret = -ENOMEM; goto exit_dma_lch_fail; -- 2.14.2