From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ACE8C001DE for ; Mon, 7 Aug 2023 19:29:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbjHGT3m (ORCPT ); Mon, 7 Aug 2023 15:29:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjHGT3k (ORCPT ); Mon, 7 Aug 2023 15:29:40 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 899F51717; Mon, 7 Aug 2023 12:29:36 -0700 (PDT) Received: from nicolas-tpx395.localdomain (unknown [IPv6:2606:6d00:15:bae9::7a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id 36BB06607136; Mon, 7 Aug 2023 20:29:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691436575; bh=phyKlnNZeX0sqt4LzjAAxHvZjJzRNwOhF/IBWpOHfWM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=J3pdc0xHX6TkPPouCyZCt3Oxprigg+uPGtuU/ROrxL4CxKWZFq1L3oJmInroc/HUN tqhOwaHXikKKpAXA9lK4+QIthT8KvJuVIbf5TKD19uQBeIvRF2/vrcXm0SR9ELIgu+ yApnbDZ9Gdhjfs2Brroj9dlukpyN/RzkW5yK0RdL/0o4+qKR4+/Va3gwvzmA8SANCj j8yAVJn2nZsYugnNOx2B38QF/rJCFda9F/wRQ6oZRNFTN1HAxDN5zkKC9uLFiYdkIf udN54pApEI8FoiHEnVAr0dHcz6/+uaJBJ9GJD2QearzcJsRPY1luw+Dh3nrj/3yiOR q9AJZWB9EotLw== Message-ID: Subject: Re: [PATCH 4/5] docs: uapi: media: Add a layout diagram for MT2110T From: Nicolas Dufresne To: Andrzej Pietrasiewicz , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno Cc: kernel@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Mon, 07 Aug 2023 15:29:25 -0400 In-Reply-To: <2e08b843-d1f3-a095-8e5c-cc4997773040@collabora.com> References: <20230804192737.19016-1-nicolas.dufresne@collabora.com> <20230804192737.19016-5-nicolas.dufresne@collabora.com> <2e08b843-d1f3-a095-8e5c-cc4997773040@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le lundi 07 ao=C3=BBt 2023 =C3=A0 20:40 +0200, Andrzej Pietrasiewicz a =C3= =A9crit=C2=A0: > Hi Nicolas, >=20 > W dniu 4.08.2023 o=C2=A021:27, Nicolas Dufresne pisze: > > This diagram details the partitioning done in each tiles. >=20 > If I understand correctly there are 8 partitions in the diagram, each par= tition=20 > consists of 80 bytes, 64 bytes containing MSB data and 16 bytes containin= g LSB > data. The diagram says "MSB 8 bits" and "LSB 2 bits" which might be confu= sing > because it suggests that the length of the partitions is maybe 8 bits plu= s 2 > bits. IOW it is not clear that the numbers (8 and 2) refer to the kind of= =20 > contents rather than lengths. Maybe to the left of the diagram should be = some=20 > arrows/curly braces describing the partitions' lengths? You mean you'd add the partition height (4) in pixels ? Note, I'm thinking = of using "8 MSB of pixel data", as it seem to translate to a better english "8= most significant bits of pixel data". I'm trying to avoid replacing the text, it= only meant to be a visual support. An alternative, is really to leave the detail= s in the text, and label it "MSB of pixel data" and "LSB of pixel data". Any preference ? Nicolas >=20 > Regards, >=20 > Andrzej >=20 > >=20 > > Signed-off-by: Nicolas Dufresne > > --- > > .../userspace-api/media/v4l/mt2110t.svg | 268 +++++++++++++++++= + > > 1 file changed, 268 insertions(+) > > create mode 100644 Documentation/userspace-api/media/v4l/mt2110t.svg > >=20 > > diff --git a/Documentation/userspace-api/media/v4l/mt2110t.svg b/Docume= ntation/userspace-api/media/v4l/mt2110t.svg > > new file mode 100644 > > index 000000000000..d4fc223f5fde > > --- /dev/null > > +++ b/Documentation/userspace-api/media/v4l/mt2110t.svg > > @@ -0,0 +1,268 @@ > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + MSB 8 bits<= /tspan> > > + > > + > > + > > + > > + > > + > > + LSB 2 bits<= /tspan> > > + > > + > > + > > + > > + > > + > > + MSB 8 bits<= /tspan> > > + > > + > > + > > + > > + > > + > > + LSB 2 bits<= /tspan> > > + > > + > > + > > + > > + > > + > > + MSB 8 bits<= /tspan> > > + > > + > > + > > + > > + > > + > > + LSB 2 bits<= /tspan> > > + > > + > > + > > + > > + > > + > > + MSB 8 bits<= /tspan> > > + > > + > > + > > + > > + > > + > > + LSB 2 bits > > + > > + > > + > > + > > + > > + > > + MSB 8 bits > > + > > + > > + > > + > > + > > + > > + LSB 2 bits > > + > > + > > + > > + > > + > > + > > + MSB 8 bits > > + > > + > > + > > + > > + > > + > > + LSB 2 bits > > + > > + > > + > > + > > + > > + > > + MSB 8 bits > > + > > + > > + > > + > > + > > + > > + LSB 2 bits > > + > > + > > + > > + > > + > > + > > + MSB 8 bits > > + > > + > > + > > + > > + > > + > > + LSB 2 bits > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + 16 px > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + 32 px > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + >=20