From: Randy Dunlap <rdunlap@infradead.org>
To: Junhan Zhou <Junhan@mellanox.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Liming Sun <lsun@mellanox.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] EDAC, mellanox: Add ECC support for BlueField DDR4
Date: Thu, 21 Mar 2019 08:23:23 -0700 [thread overview]
Message-ID: <cb7939d0-2723-7d8c-2f9f-03c24f0cef77@infradead.org> (raw)
In-Reply-To: <DB6PR0501MB270922D61D8F228A31A664CDB3420@DB6PR0501MB2709.eurprd05.prod.outlook.com>
On 3/21/19 7:30 AM, Junhan Zhou wrote:
>>> +config EDAC_BLUEFIELD
>>> + tristate "Mellanox BlueField Memory ECC"
>>> + depends on (MELLANOX_PLATFORM && ARM64 && ACPI) ||
>> COMPILE_TEST
>>
>> Hi,
>>
>> While I am in favor of using COMPILE_TEST whenever possible, I don't see
>> how that is possible here if:
>>
>> # MELLANOX_PLATFORM is not set
>> # ARM64 is not set
>> # ACPI is not set
>> COMPILE_TEST=y
>>
>> Can you please explain?
>>
>> Thanks.
>>
>> ~Randy
>
> Good point. I tried compiling it against the x86 architecture and it fails because it can't find the definition for arm_smccc_smc(). But it would compile for the ARM64 architecture with both ACPI and MELLANOX _PLATFORM not set, so I'll change it to ARM64 && ((MELLANOX_PLATFORM && ACPI) || COMPILE_TEST) instead.
> The dependency on ACPI is because our BlueField SoC firmware only uses ACPI to pass the device mappings, and MELLANOX_PLATFORM because this device is only seen on the Mellanox BlueField SoC so it would be pointless to be used elsewhere, but these doesn't prevent it from being compiled.
>
> -Junhan
>
Sounds fine. Thanks.
--
~Randy
next prev parent reply other threads:[~2019-03-21 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e59276b6f3dc165703ddcb47a8a006d8a62d9c95.1551216637.git.Junhan@mellanox.com>
2019-02-27 20:21 ` [PATCH v1 1/1] " Junhan Zhou
2019-03-14 17:13 ` Junhan Zhou
2019-03-15 15:12 ` Borislav Petkov
2019-03-18 18:39 ` Junhan Zhou
2019-03-18 18:39 ` [PATCH v2] " Junhan Zhou
2019-03-18 19:19 ` Randy Dunlap
2019-03-21 14:30 ` Junhan Zhou
2019-03-21 15:23 ` Randy Dunlap [this message]
2019-03-21 14:31 ` [PATCH v3] " Junhan Zhou
2019-05-23 17:29 ` James Morse
2019-05-30 18:48 ` Junhan Zhou
2019-06-04 17:13 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7939d0-2723-7d8c-2f9f-03c24f0cef77@infradead.org \
--to=rdunlap@infradead.org \
--cc=Junhan@mellanox.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsun@mellanox.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®