From: Pavel Skripkin <paskripkin@gmail.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq()
Date: Sun, 20 Feb 2022 19:20:40 +0300 [thread overview]
Message-ID: <cb7db1ac-8e7e-d549-a5c0-fcd072ae815e@gmail.com> (raw)
In-Reply-To: <20220220154847.7521-3-straube.linux@gmail.com>
Hi Michael,
On 2/20/22 18:48, Michael Straube wrote:
> -static int ch_freq_map_num = ARRAY_SIZE(ch_freq_map);
> -
> u32 rtw_ch2freq(u32 channel)
> {
> - u8 i;
> - u32 freq = 0;
> -
> - for (i = 0; i < ch_freq_map_num; i++) {
> - if (channel == ch_freq_map[i].channel) {
> - freq = ch_freq_map[i].frequency;
> - break;
> - }
> - }
> - if (i == ch_freq_map_num)
> - freq = 2412;
> -
> - return freq;
> + return ch_freq_map[channel - 1];
> }
What if channel has wrong value? The old code returned some default
value, but with new one we will hit OOB.
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-02-20 16:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 15:48 [PATCH 0/3] staging: r8188eu: clean up rtw_rf.c Michael Straube
2022-02-20 15:48 ` [PATCH 1/3] staging: r8188eu: remove 5 GHz channels from ch_freq_map Michael Straube
2022-02-21 17:13 ` Greg KH
2022-02-21 19:07 ` Michael Straube
2022-02-21 19:41 ` Larry Finger
2022-02-25 8:57 ` Greg KH
2022-02-20 15:48 ` [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq() Michael Straube
2022-02-20 16:20 ` Pavel Skripkin [this message]
2022-02-20 16:30 ` Michael Straube
2022-02-21 12:22 ` Dan Carpenter
2022-02-21 19:20 ` Michael Straube
2022-02-21 20:54 ` Pavel Skripkin
2022-02-22 5:40 ` Dan Carpenter
2022-02-22 5:34 ` Dan Carpenter
2022-02-20 15:48 ` [PATCH 3/3] staging: r8188eu: clean up rtw_rf.c Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7db1ac-8e7e-d549-a5c0-fcd072ae815e@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome