From: Perry Yuan <perry.yuan@amd.com>
To: <rafael.j.wysocki@intel.com>, <Mario.Limonciello@amd.com>,
<viresh.kumar@linaro.org>, <Ray.Huang@amd.com>,
<gautham.shenoy@amd.com>, <Borislav.Petkov@amd.com>
Cc: <Alexander.Deucher@amd.com>, <Xinmei.Huang@amd.com>,
<Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v5 4/8] cpufreq: amd-pstate: fix max_perf calculation for amd_get_max_freq()
Date: Fri, 15 Mar 2024 11:38:05 +0800 [thread overview]
Message-ID: <cb7e254f8def659a35481dc48d90d2b4391e21f5.1710473712.git.perry.yuan@amd.com> (raw)
In-Reply-To: <cover.1710473712.git.perry.yuan@amd.com>
From: Perry Yuan <Perry.Yuan@amd.com>
When CPU core Precision Boost state changed, the max frequency will also
need to be updated according to the current boost state, if boost is
disabled now, the max perf will be limited to nominal perf values.
otherwise the max frequency will be showed wrongly.
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
---
drivers/cpufreq/amd-pstate.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 025f35bd3b01..a4bcac673fdb 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -676,6 +676,10 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata)
nominal_perf = READ_ONCE(cpudata->nominal_perf);
max_perf = READ_ONCE(cpudata->highest_perf);
+ /* when boost is off, the highest perf will be limited to nominal_perf */
+ if (!amd_pstate_global_params.cpb_boost)
+ max_perf = nominal_perf;
+
boost_ratio = div_u64(max_perf << SCHED_CAPACITY_SHIFT,
nominal_perf);
--
2.34.1
next prev parent reply other threads:[~2024-03-15 3:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 3:38 [PATCH v5 0/8] AMD Pstate Driver Core Performance Boost Perry Yuan
2024-03-15 3:38 ` [PATCH v5 1/8] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Perry Yuan
2024-03-15 3:38 ` [PATCH v5 2/8] cpufreq: amd-pstate: initialize new core precision boost state Perry Yuan
2024-03-15 3:38 ` [PATCH v5 3/8] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Perry Yuan
2024-03-15 3:38 ` Perry Yuan [this message]
2024-03-15 3:38 ` [PATCH v5 5/8] cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Perry Yuan
2024-03-15 3:38 ` [PATCH v5 6/8] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Perry Yuan
2024-03-15 3:38 ` [PATCH v5 7/8] cpufreq: amd-pstate: remove legacy set_boost callback for passive mode Perry Yuan
2024-03-15 3:38 ` [PATCH v5 8/8] cpufreq: amd-pstate-ut: support new cpb boost control interface Perry Yuan
2024-03-15 16:06 ` [PATCH v5 0/8] AMD Pstate Driver Core Performance Boost Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7e254f8def659a35481dc48d90d2b4391e21f5.1710473712.git.perry.yuan@amd.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®