From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEAF3126B2 for ; Tue, 10 Feb 2026 23:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770765029; cv=none; b=RsBZiBTa6LctJm76KzGnHoyXvuqCPgrOmwEFHHBFzS86CAp8RuQV/hPksgSQ92nLHVXo/uqE3ySl4e9CJ+bY1QTXnLtqc6AfPLJR+vgdQAhL5w9snMl8rFnknHC1JK8qLWrGCm201gf7qoeWnzkduv2iPdjBJQ8J/KkyNtoVJ5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770765029; c=relaxed/simple; bh=4sobIFVCzlAWjuunypO7GnznePi635vRgqgh2zI8NLA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LggsU9BfWHQlVusbRP3y/rvMEE7Tm14P6HrDQkPJFJAEDSbZg5dIYYK6J6MzE2ybLDvtVG3fWh1JZNOTfSaoC90qjsg4Yz7yytWPuFWlrXTCE/NpqEObna+GIcW+uRyGaTc2XnRN7e6bIEBa4QXAqVKBbKh0uEgnl2l8rFnvYVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CZbNg1pB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZqRnpBKK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CZbNg1pB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZqRnpBKK" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61AH3W8N2943436 for ; Tue, 10 Feb 2026 23:10:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2ZPzz5BSHYfETil2X4klxpr3dDUNgN0B8V4yT78kuwA=; b=CZbNg1pBEa6tQ6uz 8ShjER4DruWzpafyKC4iou7riNe/+NPhWNW9d0j5rK3evgj5WnQ3nYWFEvlHWhL3 fOisNJn3by/PNEGve2wiheQbB+WVsSOyVZJ5E7CN3U4JnHS31FDPcEVVAqxkRegQ PrOaj7sPattHxdXoW0NSsGrRLaQoBXWbjjma9CpqoV0ZEI6LaBQK06QnhOFjMIA0 YNBTRuG2ljbBrB0o7lLobsRzenD9lP2fteFyfaQi0q1Vt3CUuyVlc5lqxMT0ZS4v +kzAYQshaFngchsJlBoiDMIJe0ES9W2M9kK5DbcKvqFlUQzYC8Ez+DBlF/Fy3lS/ ak1BIw== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c88r716aq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Feb 2026 23:10:26 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2ba8013a9e3so1136414eec.0 for ; Tue, 10 Feb 2026 15:10:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770765026; x=1771369826; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2ZPzz5BSHYfETil2X4klxpr3dDUNgN0B8V4yT78kuwA=; b=ZqRnpBKK+d1ptyFk5WPBGjPCqHyLWx4eB6doQlJDxWdVuaDRA0JIUFgJeUO0MC51/R kJag4NlGOMkB030mb+IsxGte4tKrV0/7qsVp0TdlfHSb0vPlqo7lVVrroFRknGl2FsI9 zd/gJGFq1oCAy+kKGfgTJ2dNbSutBlgjRU1WSA3cL4eeo6u20l1uH7WVTESaJJJkUsRz OZQUZL4Th2uOOPkAh+3Iq1ltLHuobsYP07oDjfFlaYuwp8r1XZYtTqp7jGpRSXFH7tx/ Dbi+wH2AHfqrlyU+g+dIZ8wLYTM5siS4KXKHzZ/04AQURTB6qYrjDuetc1Mcv6N+1o2V Cd7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770765026; x=1771369826; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2ZPzz5BSHYfETil2X4klxpr3dDUNgN0B8V4yT78kuwA=; b=YyAf0eYJDncOWcO8gAVRzbX8AA7BsXi6zuF8VXfL4PLbWWhfvy9WOvsdkFdzVlnvf7 kCioMJTLRRD5TNN/1LtP4OQuAJ2D2Mv8GdAw6XXpJb0s6NANQtaixSntwQZ/GE7azvPZ LAOKNyXwF+4E6DqfcAluqKFhnkRkqgaA9M+pmX8Woh5DBQ+xvQgbzmKSjxtiw2I+5qnT lwLcLhcMCp469WMtpqsSr60V1C8aXzWPxGArLmuGKBEilnqYjMNXAcCdy4E5l4kgoL6R EKIDV3O+Mb14z+j++QJNtY+fb4E2uIvNkJzMRNL43UlwUOHt4AptaUAeFXdgekAfXoWD g3WA== X-Forwarded-Encrypted: i=1; AJvYcCVZmPjSaeo4fh+une6fzcPTHV/bPBPmdajZaGAj+ichIOnZKyRNzBH5jpLwf605cJRNj6/DBlHjmF1lLjY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3d2DnPspZCfnDnft9DOLkFWpV5BXgGiJRkYvky9jTtTXlvhlW G6y+9aLRSXu4dn8JmHsv39dSuSRMGKNfCjWmSelDPoJR71CmUv7kka63taaQLpUZ6eOJkovUild KqVNC3Eq9J7mtDTRfhrGmN9FQALp3ZulajFY6q4lo/EBZZ07mC+1FHYDWfVCfHIw6Dio= X-Gm-Gg: AZuq6aKuN/ma1uD7CSIoLGz5IqC18klGJnxtO1wtHzsPZuMkLahBl2tZCFUkBQlRa4g cKmYoLU55XtfdPgeKsZ5zpQ9GJR8LEpQxRDLtIgTRdgEc4yY2HPT7qBS1r4kOr8iM5rruE661ZC xgrrSoZmbK6c2uerXpuV/RbSjaOtXcHbrX/kCcW8852xZ2ISCzSh/Ewtr+Dyy0wteAU1H+oZo+1 xAGGbKgb7zgaNShuFeh+y2ZAGkEhf9VArqgjVgchdiENND2+4JHJT1T9BvAZEZ1v3F5kOWNkNbJ C6oWaXBevUVrcIFDqYOgeFV+qQpCXUiq0qMrslYKtsipHH7VTDqcvFdRNKiQ0k3xFcaK5260qmJ UhrIgprTCtx3QHTK5bBrRaFcZ8Kc+KstMJpTWXRskfm+elnGKxhKHQIU= X-Received: by 2002:a05:7300:e788:b0:2b8:4a34:6c39 with SMTP id 5a478bee46e88-2b85647ee35mr5986898eec.16.1770765025668; Tue, 10 Feb 2026 15:10:25 -0800 (PST) X-Received: by 2002:a05:7300:e788:b0:2b8:4a34:6c39 with SMTP id 5a478bee46e88-2b85647ee35mr5986878eec.16.1770765025023; Tue, 10 Feb 2026 15:10:25 -0800 (PST) Received: from [192.168.86.165] ([76.176.48.107]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855c3daf7sm10940431eec.20.2026.02.10.15.10.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 15:10:24 -0800 (PST) Message-ID: Date: Tue, 10 Feb 2026 15:10:21 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] firmware: smccc: add timeout, touch wdt To: Vedashree Vidwans , salman.nabi@arm.com, sudeep.holla@arm.com, andre.przywara@arm.com, lpieralisi@kernel.org, mark.rutland@arm.com Cc: ardb@kernel.org, chao.gao@intel.com, linux-arm-kernel@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, sdonthineni@nvidia.com, vsethi@nvidia.com, vwadekar@nvidia.com References: <20260210224023.2341728-1-vvidwans@nvidia.com> <20260210224023.2341728-2-vvidwans@nvidia.com> Content-Language: en-US From: Trilok Soni In-Reply-To: <20260210224023.2341728-2-vvidwans@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: vU5NhOtBZ8kxGVwVP8RcIY0BiSQXOCT9 X-Authority-Analysis: v=2.4 cv=YaywJgRf c=1 sm=1 tr=0 ts=698bbae2 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=lsoD3MMNObdLvy1227ExmA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=Ikd4Dj_1AAAA:8 a=OPovUEjlS86QoOQlm80A:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDE5MiBTYWx0ZWRfXwyO+CCUAzio5 MFJeTFga9TKjkWYtBQAKkVwAvemcoSiCZzk+4ZphYJBM2PRoDFTASJjo9YkfgZuctyGx3V7BOut 2KU47GvAMxsNFQBy58pbH1ElhogeqalBEKHBcQKDBIEWKU5q/lmqFTMKHQ8iEO4G8csh2nbPvHF WSLYH7W5dW9KzdGKzdQFFUtciJ0uuEozT/xkatpF0j1Zl/a7w3QqLX1dLFQlrWY7yTDQxntoSlP 5PfgEU1EGGS/DbUh7nuoMOF32wMs2QKc0p9+cqznxkc2P7zPdWNK5Fj99ws7euf973/NUATZUqS 9XS8IDzlHVx/KRSsgnBrMx5LuMKdUjueTcAjtg3p1FAYTp+pRZcYAB6qwTi7Pf+ttNHRqPtEjz8 KydrDbgH4owNFIE4rKtaTq+lnPde6ARWtiMN9+f8bHCrpnMG2VGsv1s35m/w0cnjDql44iaF9ea NECGTisGFk/rrCj2uYQ== X-Proofpoint-GUID: vU5NhOtBZ8kxGVwVP8RcIY0BiSQXOCT9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_03,2026-02-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100192 On 2/10/2026 2:40 PM, Vedashree Vidwans wrote: > Enhance PRIME/ACTIVATION functions to touch watchdog and implement > timeout mechanism. This update ensures that any potential hangs are > detected promptly and that the LFA process is allocated sufficient > execution time before the watchdog timer expires. These changes improve > overall system reliability by reducing the risk of undetected process > stalls and unexpected watchdog resets. > > Signed-off-by: Vedashree Vidwans > --- > drivers/firmware/smccc/lfa_fw.c | 40 +++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/firmware/smccc/lfa_fw.c b/drivers/firmware/smccc/lfa_fw.c > index da6b54fe1685..b0ace6fc8dac 100644 > --- a/drivers/firmware/smccc/lfa_fw.c > +++ b/drivers/firmware/smccc/lfa_fw.c > @@ -17,6 +17,9 @@ > #include > #include > #include > +#include > +#include > +#include > > #undef pr_fmt > #define pr_fmt(fmt) "Arm LFA: " fmt > @@ -37,6 +40,14 @@ > #define LFA_PRIME_CALL_AGAIN BIT(0) > #define LFA_ACTIVATE_CALL_AGAIN BIT(0) > > +/* Prime loop limits, TODO: tune after testing */ Do you want to keep this TODO? Your patches are not marked as RFC. > +#define LFA_PRIME_BUDGET_US 30000000 /* 30s cap */ > +#define LFA_PRIME_POLL_DELAY_US 10 /* 10us between polls */ Are these values going to be tunable from the userspace or kernel module parameters? > + > +/* Activation loop limits, TODO: tune after testing */ Ditto. > +#define LFA_ACTIVATE_BUDGET_US 20000000 /* 20s cap */ > +#define LFA_ACTIVATE_POLL_DELAY_US 10 /* 10us between polls */ ... ---Trilok Soni