From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640B4C43461 for ; Fri, 2 Apr 2021 17:38:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43FBB61163 for ; Fri, 2 Apr 2021 17:38:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235500AbhDBRiv (ORCPT ); Fri, 2 Apr 2021 13:38:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35107 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235122AbhDBRir (ORCPT ); Fri, 2 Apr 2021 13:38:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617385126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TKDRlulogoRtKYWAUF1pyaqEOli9TuwMVFnHg7gDyqg=; b=SPv70vAssGxeWskwIjz44+8Y540A4Z+bEV3DJDBgeoczZq/+BCzVgMNPYJftN06vxqowQb 3oxVbGc51WvJye0c005rii3ntG8c9yJj6cDbnAOqNuhYHEfTEQIegz2PV9pAhZUGd7F09u R6ISiCgoXUb6BBxCWrzrTqb65PG2Elk= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-pmobN0_gOrynCxoLT1zCbQ-1; Fri, 02 Apr 2021 13:38:44 -0400 X-MC-Unique: pmobN0_gOrynCxoLT1zCbQ-1 Received: by mail-ej1-f70.google.com with SMTP id h14so3370434ejg.7 for ; Fri, 02 Apr 2021 10:38:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TKDRlulogoRtKYWAUF1pyaqEOli9TuwMVFnHg7gDyqg=; b=qbxo/2yk9Uy4U0zBV15yMjMbInRCuLf4OyNyRhBeNHfQCb3a9EJdm4ebWB/NuXcOsU ZrPS1IOeOwjzvIM1GcbsB4gxl1RCLPC+IMVjwwSYmNgnF9BvhPd/wChxpBPCj01CLlGs Zy5qGaTtkfZjhwHUbZQj7L1tl1npLdOW0RiBgQW1F7aORVNjIng+OdB6S0sVLyru005d EADTCf1ohn8Ptiuu2eU0hh2qi2K+YSPA/5o0LZNoRPO1Tui1qDDTKP65vbdiuCQDbtuw MX5QfP/fWaN98JVBKGQD1xYdgxVJBSuPL/FnKfof24vKryrOzYVstM8qxJg1/gVzCCVL QbcQ== X-Gm-Message-State: AOAM530syHqZ08WSYSKQVYnmSlzdSuf8mHT5/UoZ5zeYuUrAPt9ZrEtc w2EA2Y8Tq0da3KIriFszj/c2cWvPohNqCKE40+ClZhmLVBnem15M338wFO6hkVLw+xRb9KN/YyA cjrXoVUSoOPCejJ5XYzva71+Q X-Received: by 2002:a17:907:3f10:: with SMTP id hq16mr2635475ejc.181.1617385123130; Fri, 02 Apr 2021 10:38:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAS7ZbtJVwnzUWnA/6X0McPrVes3ar3lqem09HSmYxMrqLZW+HviZElaAarzltynI2Jr8wwA== X-Received: by 2002:a17:907:3f10:: with SMTP id hq16mr2635443ejc.181.1617385122924; Fri, 02 Apr 2021 10:38:42 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id y17sm4462135ejf.116.2021.04.02.10.38.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Apr 2021 10:38:42 -0700 (PDT) Subject: Re: [PATCH v2 0/9] KVM: my debug patch queue To: Maxim Levitsky , kvm@vger.kernel.org Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Ingo Molnar , Andrew Morton , Thomas Gleixner , Sean Christopherson , Marc Zyngier , Catalin Marinas , open list , Julien Thierry , Stefano Garzarella , Borislav Petkov , Suzuki K Poulose , Jonathan Corbet , Jessica Yu , "H. Peter Anvin" , Jan Kiszka , Will Deacon , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , Vitaly Kuznetsov , Vasily Gorbik , Joerg Roedel , Claudio Imbrenda , Jim Mattson , Cornelia Huck , David Hildenbrand , Wanpeng Li , Janosch Frank , Christian Borntraeger , "open list:S390" , Heiko Carstens , Kieran Bingham , "open list:DOCUMENTATION" , "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , James Morse References: <20210401135451.1004564-1-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: Date: Fri, 2 Apr 2021 19:38:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210401135451.1004564-1-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/21 15:54, Maxim Levitsky wrote: > Hi! > > I would like to publish two debug features which were needed for other stuff > I work on. > > One is the reworked lx-symbols script which now actually works on at least > gdb 9.1 (gdb 9.2 was reported to fail to load the debug symbols from the kernel > for some reason, not related to this patch) and upstream qemu. Queued patches 2-5 for now. 6 is okay but it needs a selftest. (e.g. using KVM_VCPU_SET_EVENTS) and the correct name for the constant. Paolo > The other feature is the ability to trap all guest exceptions (on SVM for now) > and see them in kvmtrace prior to potential merge to double/triple fault. > > This can be very useful and I already had to manually patch KVM a few > times for this. > I will, once time permits, implement this feature on Intel as well. > > V2: > > * Some more refactoring and workarounds for lx-symbols script > > * added KVM_GUESTDBG_BLOCKEVENTS flag to enable 'block interrupts on > single step' together with KVM_CAP_SET_GUEST_DEBUG2 capability > to indicate which guest debug flags are supported. > > This is a replacement for unconditional block of interrupts on single > step that was done in previous version of this patch set. > Patches to qemu to use that feature will be sent soon. > > * Reworked the the 'intercept all exceptions for debug' feature according > to the review feedback: > > - renamed the parameter that enables the feature and > moved it to common kvm module. > (only SVM part is currently implemented though) > > - disable the feature for SEV guests as was suggested during the review > - made the vmexit table const again, as was suggested in the review as well. > > Best regards, > Maxim Levitsky > > Maxim Levitsky (9): > scripts/gdb: rework lx-symbols gdb script > KVM: introduce KVM_CAP_SET_GUEST_DEBUG2 > KVM: x86: implement KVM_CAP_SET_GUEST_DEBUG2 > KVM: aarch64: implement KVM_CAP_SET_GUEST_DEBUG2 > KVM: s390x: implement KVM_CAP_SET_GUEST_DEBUG2 > KVM: x86: implement KVM_GUESTDBG_BLOCKEVENTS > KVM: SVM: split svm_handle_invalid_exit > KVM: x86: add force_intercept_exceptions_mask > KVM: SVM: implement force_intercept_exceptions_mask > > Documentation/virt/kvm/api.rst | 4 + > arch/arm64/include/asm/kvm_host.h | 4 + > arch/arm64/kvm/arm.c | 2 + > arch/arm64/kvm/guest.c | 5 - > arch/s390/include/asm/kvm_host.h | 4 + > arch/s390/kvm/kvm-s390.c | 3 + > arch/x86/include/asm/kvm_host.h | 12 ++ > arch/x86/include/uapi/asm/kvm.h | 1 + > arch/x86/kvm/svm/svm.c | 87 +++++++++++-- > arch/x86/kvm/svm/svm.h | 6 +- > arch/x86/kvm/x86.c | 14 ++- > arch/x86/kvm/x86.h | 2 + > include/uapi/linux/kvm.h | 1 + > kernel/module.c | 8 +- > scripts/gdb/linux/symbols.py | 203 ++++++++++++++++++++---------- > 15 files changed, 272 insertions(+), 84 deletions(-) >