From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE662F4A0C for ; Tue, 9 Dec 2025 15:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765295246; cv=none; b=NAUmn7R2TPl4SaLw9DrAMStHN1g9pFMOPuZmGxnCmaOrS8Xh497OKKe3av2kifuQR8FSYW1ZCrLbR2yZk578kSAe+y7t4zQKpuSNueVhYP9jVJLAzIN1XaRCwhh/0Hj3qMOOlv/FqglEw228gq56eTE0wkVcBsPmd5MjoCYZwiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765295246; c=relaxed/simple; bh=lAA44fPZ+EdgJuey2t5vEPwQ7JCLgJhCXwin1+pD5es=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ib2T+YCFqG5Ho7rX0GRtW9+NvJPoFlYVfZCAfo6U8HIrcHvdZZjnnHDTicvBg4Jj3vHuUpdEhy92pqaieUvV7XH7QzQA2FqNSSsK1+vu7jIblHA2xH1PjIRU88Ne1hhe/jAZGL6FknAsV8GD3Rv6/8uKxYqmDpUR1gdo4PhU4y4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WXhioQas; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FHLYeMMO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WXhioQas"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FHLYeMMO" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B9FhZRV340059 for ; Tue, 9 Dec 2025 15:47:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NDHkj3CwoCQL6wJWOKPjGCsfcQFkvee6eMCgSP3pCQc=; b=WXhioQasmjcCm9iz Sn7wLcl6RiRm/Dl6N9GIRF4mHJckZqbq7ig8uw5nxiZ2bfKo+07RigJmnXisssN/ yaDAYxYFgmM0D2IvV8blD3Tk/V3yV9y8isrbcb6agxemT29NmtnnGj8Df/eBawAO 81ZZWW+F1Aiin5NNGNXy1YSqOmHQaTmlvw678LlMoWoTlxrgL42lfXT7o0dzwbWm ctbEAZsqCJ771ItbEzF0dAgfLjZRo5nBDUmw4n26XGNGp909Uu/oz+NUAIfKIjyJ g20Yo4XNXGD/+xBiTa9BgvD8rphHenvFUC29iDZ8y4FARv3uHg4KDPfJHRDQ09Eb qntGeQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4axm9c8kay-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Dec 2025 15:47:23 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b609c0f6522so9920204a12.3 for ; Tue, 09 Dec 2025 07:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765295242; x=1765900042; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NDHkj3CwoCQL6wJWOKPjGCsfcQFkvee6eMCgSP3pCQc=; b=FHLYeMMOxw2hQb4FwYBuoSV5h2ntApaJ3tJ+cqdeGfyZg/wuZ6QE0LElLNsb45upzq y2jCygWY/GvffPgK/MHkLdlUS0U7aj8mCKdIZXrGSgLXvZCVAKtnbDNElOOwMQRU6hsu cD3kE1HIonwbURQpKJmwWHpdWyj3AxwSkpGBYVvBezrWQ6ZsPHs1QS+C563RJF0c5MED fHj3evy0muogN++FA0dmejgeiXWuMmamZK3Wwgev3dci2TQbuPZ1LJAVNX0GCAoWYsiZ nMsR0NfR9E4ae9ZpKN5jiOe+H0Y/es929yn29acIpPKQG0ZF9Szk85wOPFIBpMvs7265 SSAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765295242; x=1765900042; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NDHkj3CwoCQL6wJWOKPjGCsfcQFkvee6eMCgSP3pCQc=; b=cqkhadzt6raUJtXm/W2u5pj4BjVVhFU8Lue/PHfGfClIraII6WLvBfagp3TzI9u7to h8fYhCxr1GWdnXx4UuLe6Tgk2uBjTG1gn+92y6RAOiJ+dOcKRqHY9LtncQvpkzJ187aa ih7m5Hm583Q5zIeTQUY19OnCSZHfGn5lcW5zIXOX8dmj7OatS8XGHQfEmCCr6jj6zR31 J4Xbop/nPR2yrD4qucV2NTdep7ivi+Z8s8xHpTaUqox1aJVbm2thh9jzvuxU8kjShZ48 G1u7r9XTY5PiH+oLAP5YvB5qYSU0CExU/3D2ryUgqyBDacAVNf6E7WljupKq2QrQRXjT VpmQ== X-Forwarded-Encrypted: i=1; AJvYcCUh/fxtQ1y3TK1TSO1NRPtvONMrqgpkHl5WsAe6Vs7EaV/5dS0+YM5vD+EObVJw/voXPM7Zmte6uIxdJJw=@vger.kernel.org X-Gm-Message-State: AOJu0YwS9BEkZ/NdOgOs5hxviT4UiXiDgW4QvMXB2Uh8moAeIZEHXdnA TbLa3G/Yj7Nl6/BHt8+AN10ISlF28cks+7ecbMH/3C0Wlm1VNZkEUBscp8+rZHC/qE2dGgnEBgm zM5FSVqooN1cSH+aVrAeg+FRa13054WOIHOACo2+sDdUFKGqStRVLdbsdum0bFgrPeiQ= X-Gm-Gg: AY/fxX4AW0PAn6DUbwMiC0nL/kW78ibneUK8y5SYAPVAY0LHvQKvdvL8lHzt7kB/2X4 PWp5EaWXUOlxCaGn8dLu5nWWtA0qEnEyRz7CZCYBY6jSymQphDtXVoH7QdZY6AGr5ZVVJcEXZEy FKVYASIpXlNYR4z0FKWu+6BjoH86LgJqeQ++7w2ynViYcjABDsnB7v/2QzxMzuHixVtiz6nF9BO +e6zp5JUe4FSA2wIqI+cPWvgWARtiXpV7HJyuI/sR8VErUW29IjhZnv/SxVUD/b/zHSwIV5df7s ZmRz8CguqKA/8FYo7MPbqCDohm1GNygBO9ArPVaUxkixzY7JlPjiGn55m2E/1p3vvrkeKdeRPXq 7z98NOvH2kRnaaF1xQQB0PL9qeN7dBjKTmUG1mJmM8k8zEVc54tvzHyrhxd/iRdzq9zq/MQ== X-Received: by 2002:a05:7301:1906:b0:2a4:3593:c7c6 with SMTP id 5a478bee46e88-2abc70fa21emr8054975eec.6.1765295242108; Tue, 09 Dec 2025 07:47:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhrMcLrAfPV8e9p+ctKvu2z65Q8ub97vqIxMWVyLeOFWssQ0s0J2qpalQgDpvc7C9ctW7Uww== X-Received: by 2002:a05:7301:1906:b0:2a4:3593:c7c6 with SMTP id 5a478bee46e88-2abc70fa21emr8054946eec.6.1765295241549; Tue, 09 Dec 2025 07:47:21 -0800 (PST) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2aba87aa5fcsm44776850eec.3.2025.12.09.07.47.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Dec 2025 07:47:21 -0800 (PST) Message-ID: Date: Tue, 9 Dec 2025 07:47:19 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "wifi: ath12k: Enable REO queue lookup table feature on QCN9274 hw2.0" To: Oliver Sedlbauer , stable@vger.kernel.org Cc: quic_rajkbhag@quicinc.com, Jeff Johnson , Sasha Levin , Vasanthakumar Thiagarajan , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251208103152.236840-1-os@dev.tdt.de> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20251208103152.236840-1-os@dev.tdt.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA5MDExNyBTYWx0ZWRfX3YOO83dGhgsE ys9epCeljv6RIoI9QaI4yEWWwKVe+Zm5pZK5Lu79gbklTtRLNXRqD0/ZKeuAYm9th5YTteNUIvW yO3K4JrIACXzTKrikFKBGUzJqAWpymwRzpF4phvPjebT42DlUKi5Vaec8l1mj/j3F1St5ocChMm 7aEFgo5ubLkKiFXci/5rxYtKYQ+4b2BUVAzakgWLbCZpPlgWxjygE3aqZo+QXwtDnJKF4EiyNwi VhmE3FxKDTV06iirCGqbbhJxIgNeMzrwm4rnZW8XhCCJmwd/Eg6jrobLftuxawGBdQEhp5lncwj 6+Tu0qSWkPjuTARJuDGmI6gRPBlNXoJG3H5ojvGc2DISUVztNjdu3smIGPd26VxbVR+vXKaqDe6 FGIWkc+faCg90rZGu8JXVKbKDLEoiQ== X-Proofpoint-ORIG-GUID: jHtfROm7NQUd_J9tu4ld20_d_S0bl6eB X-Authority-Analysis: v=2.4 cv=Vcj6/Vp9 c=1 sm=1 tr=0 ts=6938448b cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yIxbBWfxqtjDTp5mS7gA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: jHtfROm7NQUd_J9tu4ld20_d_S0bl6eB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_04,2025-12-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512090117 On 12/8/2025 2:31 AM, Oliver Sedlbauer wrote: > This reverts commit 3b5e5185881edf4ee5a1af575e3aedac4a38a764. > > The REO queue lookup table feature was enabled in 6.12.y due to an > upstream backport, but it causes severe RX performance degradation on > QCN9274 hw2.0 devices. > > With this feature enabled, the vast majority of received packets are > dropped, reducing throughput drastically and making the device nearly > unusable. > > Reverting this change restores full RX performance. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.5-01651-QCAHKSWPL_SILICONZ-1 > > Fixes: 3b5e5185881e ("wifi: ath12k: Enable REO queue lookup table feature on QCN9274 hw2.0") > Signed-off-by: Oliver Sedlbauer > --- > Note: > This commit reverts a backport that was not a fix. The backported change > breaks previously working behavior on QCN9274 hw2.0 devices and should > not have been applied to the 6.12.y stable kernel. > > drivers/net/wireless/ath/ath12k/hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/hw.c b/drivers/net/wireless/ath/ath12k/hw.c > index 057ef2d282b2..e3eb22bb9e1c 100644 > --- a/drivers/net/wireless/ath/ath12k/hw.c > +++ b/drivers/net/wireless/ath/ath12k/hw.c > @@ -1084,7 +1084,7 @@ static const struct ath12k_hw_params ath12k_hw_params[] = { > .download_calib = true, > .supports_suspend = false, > .tcl_ring_retry = true, > - .reoq_lut_support = true, > + .reoq_lut_support = false, > .supports_shadow_regs = false, > > .num_tcl_banks = 48, Stable team: The issue with enabling this feature has been fixed in the mainline with: afcefc58fdfd ("wifi: ath12k: Fix packets received in WBM error ring with REO LUT enabled") Hence this patch should not be reverted in the mainline. But it is difficult to backport that patch, so the original patch should be reverted in all of the stable trees where it was backported: 6.6, 6.12, 6.15, 6.16 /jeff