From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0393A7F60 for ; Sat, 28 Mar 2026 18:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774723225; cv=none; b=duf0kkM9NhECLhQwsCzVkznNBNvgTQ+puGXz8/2Im1Ew7FMv75YTAgmuw4C+HqP8CGC9pIRlrWp/BfESaun9b3GwG8RDYOQ/FZDauA4KWRPODt12fjdjBtS1tvHqBmCaMCWK4dE7nhBlN8i5Ceitzpc5vIoer1xs+IWEuxDgylc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774723225; c=relaxed/simple; bh=pUsHPV8G/3k3Z/1QODa79omaY5CvVTeJ0qf9Q51K5Cw=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=V6pbhpmDfPu7xB+Z0nQht2zym49tJXPgFlbjFQxqjvFgAD0q9QH3oauGK6vNY4jHQ96NVIwb73n1ThmjX9X6FTuPdq6UIf/pa7pqYTb8PDdwNEoGJ7YXp9+DfqRmbHF+op6wreK8YROLw97bX3i0qfSTlqSckhMfa211vDayH8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=mw2f7gB5; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="mw2f7gB5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1774723212; x=1775328012; i=markus.elfring@web.de; bh=rp0KLlyOcPxYIt1f5VzYWMurzYYBzbHfTfVlXut2sqI=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=mw2f7gB5NFJOyKMgWhCjbYZQQFwgBpwhQcy+8xE0oSxZ2i8XcwvxCTLrSk7Rs9r3 YuPkr+0v9famua0uEHWcVX8Jdjux4X3FBTPAvy8klZa2qLl/m0WEzfdaxPYgkm9uL 7jC71MFwldzjIEl+BAsiWB4+tJzWs0Qzc6zakjpwtWzsmQWZak87EACXK0BokgO3u ir7GJZQOSDm3LFj/s+UyFp8jY/+wQ5irqEzbFCV/y7vI7m3lWT/qD4j2+1yy2d8Zr 3hppUTRXwk348sLEjNmckYsmj7bzm+c543yNtyg/sOokawEmz9ovCLgzFM2hzX2KM oEg8Z7u7aV29GoblSQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from client.hidden.invalid by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MVrft-1vzAkL1dFl-00N28k; Sat, 28 Mar 2026 19:40:12 +0100 Message-ID: Date: Sat, 28 Mar 2026 19:40:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Felix Gu , openipmi-developer@lists.sourceforge.net, Corey Minyard Cc: LKML References: <20260327-ipmi-v1-1-d4a4417140b2@gmail.com> Subject: Re: [PATCH] ipmi: Fix sysfs file leak on maintenance_mode creation failure Content-Language: en-GB, de-DE From: Markus Elfring In-Reply-To: <20260327-ipmi-v1-1-d4a4417140b2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:v+b33uAqgmSMf9HDzISXG2AuRNcvnMi6orekrHygMj40bmSdOKS 8lGZFcdbh56V6a7JJQkJhCdv6b843/69jDKab+K3LwsoyTZ3JZD/n7C9/Zl2Q6Km5nCphqM rXsRrc6iuv1e0lLtSo3CYuv3/49lv9R9dHePf9UeS6JNo3AaEyUFs2BAmTlCrKeIH8/a7e6 6TNA7QMfCmXdxgI/R1nUA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:huD8OFywm2w=;IRnjN5ItY2h0K8wQJWDEp37eJ/t uifWGGw4gqY3n/M3Zv0YMN6Iq5hU+GSuhRfsgJPir6DSkNrUrUgFgLlo6XtT0A7S9gcrhxiIo SuFkuHsWO5kDvf7GRnuae0jk0ATicmuwQmz1BKSOHhd2/+wlyM+5xrBQd16lMe7RyM0FchOUj 1ZC++7Zy7ngIR8OsYKIjHTaM/2+TLPYKsog43XKOk79GdwCCzOl82koc/6SoMt31b9qEEoccK ejpGEwyI7ql8g9F19VuVMS3JBdZ6QlnNI3ILt8xTo37pmiS6lqUZR9NqRK06PghUSL+aADNzb 4+wb+u8x1yEt+7CMxrNWZ7HBN40hVFKovHv8XPlXbc/OAQeSkWH1lNTBw4+K8iCYhNche8Nej JWwCRbrJuAU2NgxtCqYIee3crpjs1YaR/I4zWguO0aK+wgzTjFCBvHuuPgeUj9C6y/TCSb2q+ VD6iBI28U4bOlGGtwEdxu2ooNK86s2spJSTFO7vFG3lZ+Orw3C9TCsgIcauGNkqh0X53vYV59 duneAkpwhdSXtvmLU/HB0YU1fcoG22LmvQrLRZ3z9puENCFL6OnDMRK1EGz308YRG0d1Fpw00 hdK3QFnLQm43uMiYcdqHskzgzSFXv4Td16CEt5vDFfJ26fzccnNRiVadEIifiUxXjgMM6xgzS rSFLwBJKJNBOFfyxN46Xz+NFG4HhT3znv1q2xTYVXk3s8bvVMbjRCrTCLQ3aVNp6e3V6AQ9CO UWel8SwYjQ4xmFqKAJELzHLZ9zmFP7Qm4XGXu1tR9uPZ7XZ8MqgrCpWEOIjLNToAq17kAV5jG H0IYUv1BMmk7hRwMd5+IjR/6JOgQtDMSdjCZpdwPgacEdXTyIvBWPHuuD6mhfZUFSUCO3+78Q aIl4bWRYHh1VV2ODK4gC0Oiby1M0BSVto2lEkaOJ42l+X6SbnPPXkMD+shItLtGfWJ4vTj/y8 V1Y0QMAqySMD109YL/fPY6CX6kpD1OIvJ8i7xD3kqdXDIZ75AulmIi1rm6r8UPQIgq6ZBKpG3 wRnbR30edDsPNLOD2FIMFD0/YHUHip04c6Lh/YMq8XF4jmvKwEwR+I9hrnU3OTJH3xc42u5U7 lynY3MmGgKNz/zwFHqKAfVBnuq6+Os5lKWH4tgM6Orfhws5kdu9NQba5JYzRSmDExDChrwOWq Dm0idNsEDzrW4TeGluZ9fcwtZz6Qa12PPPYyr5ubKMpnXGTR8iy9GBMq0daEObmdMzgFZawim m38UV0/6ioi3dXdGlkj9w/BeZAiqM92BqYAhkbzy9vOlAUlyTkdolrkXzfaHIQiBwVg1w4oca hFiJGbWWZLYbR4MPRjUe5BmpjBkAFDiGMGZk6fCjYxyXCi4PvMT2CfpHxFVf7vXRRok46Fd+b W8Q8G7NwZMNKUFuLvE/o7os7f8c4UHVkWLaBIEN0i+p3GzKLmX6ZU5gnGqsh8oFThYYNt7rEY EYo8Nvrng5SNYslKL86ibTGSXMr/5x4FKRbZ3P10YwN6Jt0kQpGjrYJa2URh/vOwMXfKz2hql TCFEqdvP9iQlm4x8AR/quLR4PbJ/Yg2QOkZ9dhKz9viqPwNLgo3KpxnhBGWxLVtlTYx1qENgU ZvMmlNwHt4uGBBC0T6itNkc3guRJp65WiAySxnnShAqj7YG9yv7xB6XpdZ1AC1xanLy7xxKI0 BWNRhuAcP+10IHFibQlbXkvcFjGk1oDdyGwaMmLv/dDRDJbhuGUv19k3aa38thKVjIMrmxFNG gLrLaVKZKtHb067nOsqr2pyI30VtCmtfr0SM6nqMiH4OvblaWmxDO6eRrWGnoheKl9sQAS5yw PFMzp3ACQX8uWAfdPGMAXlUkVn/4uAa18dMMzUa2nFX5H368XFpkop+kLm10Bq6ZWQuRtuKIC uVXSqZ0S7ASR4rURIxXajIlDTTXQxoOeVg0zzhrkEdpBv2P94jGo3oKNCvN34Ms5IVj/tXtH7 JaV2FzcFP2QEmWgEv+t+nWJO+x9whf/uVroaQHAayowbpLnQZPEZKMO+STfwTTdp6qMXIi5Tc yb/a5/JPNrvqizxtrGaaR2tOrutVqq8g2nf/ySSjUlBmKBMGa2Ni+IWp7zHgrXExaAQbgj+Zd 3EOE25uAM2EAG0IAsoQL9k+48o/j4pRRq9syXGO+ZcayYq57GTJILv11I7IaydSHpO8QvtZlZ 8VsvRn/bSNiDJrt+cssoP36nIKSl0PE6AITeLNROPtS71oZpRNi/ygcTsXsuD2PPAtcYW39hF 8Sb1H3RnoakgNe90qMh15PXFJcYq17Z0MjdZivGQWQKWLZ5TQ/TLxZRZayBb7TYkrzfpuT7sP MmOwriFX5p3tJUQJ6vREgNPN4Vo6S15a+O5op2AJBTalbD7ca09us2cILJvLB7WbFvAp5klYi OK6BA30XkPJHuBpM4tPSc8EA8wIvEYocblOqt80CNu09UvCbFIfAYontdeGGalpSXH1W7HKdZ mIAexnxigv1O5+Qjwk0eim7Soiz9LnCMEBA1R5DEhaMKG4J9Kgl2ghpUge/YGPt4hzQnVqMM6 ppM30JLQOVbJeKSIs/q+biEB/gCt0kw2v4Tdb6cnk85gy6Ap3Qukjp6n0ujOtZXr8OStrl7+m N9weH7jvi6Z8C+EGoeQUWEiQ9pWHOaom7OXNjFTZP/ZuGXM3d9Pka3HY1HmZviIXL/hdSEMhn c0iOepc5gOJv98iB3n/9D7cwdWKSo+rbJ2mYoTKXXE6oKwcFF/zwetvUWTz07j5wh0b1uVvs8 V6YNFpjBXTJ8XZPbol0Xhid0DTBysJp66oSIiNpEXSmuwEaBR6oLHdJWgGVYSm7OFjxTsgFBV WFN8Hvp2d3tGz2RFNlNhmrMkgp0DlSceiuGERySJLvSqW9Tgq9fEHgVbEpg9wY/wgbLVZLCQW P3Fe/yW1lSSH7MsFvwtjzQcVNjVx36aZcM1NaRgbQTCHw0HUMh/Ac26+SCkrCNcPRJu3UIjXJ 9FVBj7kB1tbTuAgAh3n0KYuSMDXLcHKDQqjFU5OIS0A+KAhZMciIEZ61d2w1Ms3+HdGMf9Cea WOjAXe1SJX2iAUA54o1M5G+P6mts/2UATIHm5dXBoXJmdW3Xyg0eR/K5IGbmRSjwMvaGoXSOK GdUQWFbWgjaoM3lS6y9ba2GCNE0OeUAwfa5LPthRqV3sKOfx2sjHqWWdMJkzkJchU+K/6rI4y Ds/uop5zl7p/x/eudO34Ze9n+oOJt05QSwZX0i5gfhfYWKg/iZmIYeXmQQ19m4/xZEn7tbauJ ze5jzJu3Sy9FNZa0x9mj4/hSKa5qxfp+EnTwOoiPu83jFNI9FwX750NsmDGHUrvzbYrKjfc9l KzLIHtU/bIh0xTJy99dCBI528Iyiv0MAXysq3SpmQEOfuL1zDyLoFk1sYWaRD22Ngf3rVdoYA CWZBRn+rXqtt2pGFOL6XBEF61zbz5e5C1YbKgN8AZJUIlNA4a6I5ENMdrCF2XFPeMaoq7vTg1 /DLhrVqu7ahgJo1VrdNaIUfHn5frkiKkjBbO+zfdsmCwmdo7ZJ6NkCIsTrr/LIYPhKpJQ90hy WHa5h1BGzaIaCRsCLd1lhiABJMv5Kt71avMuzVaOnsyXllWARvy2rWNLia5ZASc6lKNBStUgu bmc6XE3jvVPaOYsW0dbb0r+06J9qkiDN6VNTpMiwURnjJZipxwSM4MwiuU/LAFtQpEQqTKZYl ZaVPQjqggfjhket4d/O8vNr2VZFRIjEPOKf20BPR16uoKRJ/xKzd2Wr9Vs7Tf7cBPzI4QyhYU +zRwp2DDhE/aiFhMJzTp2da9ABZvmbieTze46u2pCM9EkURvxqQAftCa8Biz8E9MiIJOuOLg5 RTQoPyCnq8RYaxWHz3cRe/Hj3QrlU+OXlRmRZZPt3qvCUht7vVQqfdYMQ2403bsUuPdLoa2Bf K04NalyooTZ09rXLAVk1OdXe98iEXIa8LlO4Qsw3Vwg4Z7WMCh0mQADu0sPBftILSPgoaQNzq 4saFCi2DC2lY9dAOlZSREEr9qy16AuvGUqjz/+VDd1YrGrtMaSJZYKSyRWWBIKzNL0G4YEn7G LY2PlyGWumVHJ5ZbPYM5BfUwxYVr+cZy5rUhdiC6/6uj+myR+ejKVs57oa4QMXhR5MSzOVYSZ qbvFuH3UGNi5G0RE9NaCmIBXVXACT18uZK+Hv8w+pr/zLVwZqnoYVHr0g6/AmQoM1nRNINYPi 4tikv/EtNhKLrmoRUWtoHjiisrilPiohOWiA2hBgdKxuIuH5kyW/gqOpER0tUjkmkF8Fa7jyT LWj4HKw7aB2W7FuQRVvwkMNPgKQoja3W3d353WhhjSR2jC1GFqVnYBgKuTAKGrCpA17SCuqxi fs8gUgasFfLcW6MI8TiNVwLaB8XEelOTgkz08E/mcZ3DSB//xjoLZTJ+dqCaJg6yEv8n3j4Bs zTslyMxh9/MXdnmFtmHAO+cXnYTtEhB55E1yP4vQgzMiT3bLLBCKMc/54SZOPp1btxhJbSd7b hPOODd8zICto5/5hi+kBXAzVrs6MGJOlkf6QFqXq0nFsxD8D4sa47Qg13CGKzsRHodZI0Vv2H /E1iOQ8t9sBpgJER8UoJFQZH0MQmYOBYfGo//O6VHIBpvvF2yW/QC0fVgpil+/dGSAYoqDnZ2 ZPZIcmJS5sGg0VAXn5wr7P4i5wToFSpKx5LG+0btC0R+c8bDr3fRRHFQxMFzuswyLROuBtfVJ XnEj7QgO9bJAtRP0kEq3C5SS5mR/s1tZsIA9Yz7kVZFwIRL3JW47L06L4LmzWFrlA1FoUSTJs isXZjk+CrW49eDDaTiAxJZbR2iUkgNJolOWEeaswwYSj4w5a72514u4hItODM8skZzqA3laXf WUNTPZS/9fAwP/Gd+hDXysr6magYH4OZkVPwPzkV+mw0PQy+3CXYCKeI77zEcMjhXvSw1Uk25 yPxOVnTij9/EAnVcrPvHt9jL50eOLSvbk/rUn7DB2enM6Kc5IxNTaFBt3LA1Oyqk5CXI2kJJ+ tHF2pvf6S4L8T6M0sozxVOqEI24M4shO/GL4eg+jNR4386Z6lVKkd5nBM9HgPJsTuCE6/bSb/ 2psyHM+E7veUFf3bAmU6CIdlBrb+i66XTEj8S7wtD7XtAeB+H7eozBQIM9nzQ8e7vm/BjEE59 nYn85V/xNxjkj66AA/bw/a7BUMT3cEX379wCBYBPq/Fp0dJbO1aMQM3qiahYs1aVXdKe720Ez DPIpP5tiVL4tmfEw4tHDKD0NMs9FTHbCOV3KQjGfbCYAIKXvC3upzLJtKpHNz3Fg4fxEDWzCr AxCKRr4br6a0HEJgb3xlihAZ8ZMpzKSt+QJfLBb3VL9tzqFOOw12P5MItKIhkcM= =E2=80=A6 > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -3734,6 +3734,7 @@ int ipmi_add_smi(struct module *owner, > sysfs_attr_init(&intf->maintenance_mode_devattr.attr); > rv =3D device_create_file(intf->si_dev, &intf->maintenance_mode_devatt= r); > if (rv) { > + device_remove_file(intf->si_dev, &intf->nr_msgs_devattr); > device_remove_file(intf->si_dev, &intf->nr_users_devattr); > goto out_err_bmc_reg; > } How do you think about to avoid a bit of duplicate source code here? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/coding-style.rst?h=3Dv7.0-rc5#n526 Regards, Markus