From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA43C433E0 for ; Mon, 18 May 2020 01:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9786F20758 for ; Mon, 18 May 2020 01:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbgERBuI (ORCPT ); Sun, 17 May 2020 21:50:08 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58074 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726730AbgERBuI (ORCPT ); Sun, 17 May 2020 21:50:08 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 35ED3310FD138A30BCB2; Mon, 18 May 2020 09:50:05 +0800 (CST) Received: from [127.0.0.1] (10.74.149.191) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Mon, 18 May 2020 09:49:59 +0800 Subject: Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F To: Andrew Lunn CC: , , , , , , , , Yufeng Mo , Jian Shen References: <1589358344-14009-1-git-send-email-tanhuazhong@huawei.com> <20200513131226.GA499265@lunn.ch> From: tanhuazhong Message-ID: Date: Mon, 18 May 2020 09:49:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20200513131226.GA499265@lunn.ch> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.149.191] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/13 21:12, Andrew Lunn wrote: > On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote: >> From: Yufeng Mo >> >> PHY loopback is already supported by genphy driver. This patch >> adds the set_loopback interface to RTL8211F PHY driver, so the PHY >> selftest can run properly on it. >> >> Signed-off-by: Yufeng Mo >> Signed-off-by: Jian Shen >> Signed-off-by: Huazhong Tan > > It took three people to write a 1 line patch? > >> --- >> drivers/net/phy/realtek.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c >> index c7229d0..6c5918c 100644 >> --- a/drivers/net/phy/realtek.c >> +++ b/drivers/net/phy/realtek.c >> @@ -615,6 +615,7 @@ static struct phy_driver realtek_drvs[] = { >> .resume = genphy_resume, >> .read_page = rtl821x_read_page, >> .write_page = rtl821x_write_page, >> + .set_loopback = genphy_loopback, >> }, { >> .name = "Generic FE-GE Realtek PHY", >> .match_phy_device = rtlgen_match_phy_device, > > Do you have access to the data sheets? Can you check if the other PHYs > supported by this driver also support loopback in the standard way? > They probably do. > > Andrew > Hi, Andrew. There are two type of phys we are using, rtl8211f and "Marvell 88E1512". "Marvell 88E1512" has already supported loopback (f0f9b4ed2338 ("net: phy: Add phy loopback support in net phy framework")). So now we adds loopback support to the rtl8211f. From the data sheet other phys should support this loopback as well, but we have no way to verify it. What's your suggestion? Thanks:) > . >