From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F64C4338F for ; Mon, 23 Aug 2021 22:32:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8219061371 for ; Mon, 23 Aug 2021 22:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233174AbhHWWdK (ORCPT ); Mon, 23 Aug 2021 18:33:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbhHWWdF (ORCPT ); Mon, 23 Aug 2021 18:33:05 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59E13C061575 for ; Mon, 23 Aug 2021 15:32:21 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id d26so8053496wrc.0 for ; Mon, 23 Aug 2021 15:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QK0nYGFUqHQWTFniaZjb4pWhF5u+zRG36OlmvbNcxZA=; b=sf/88eEMM0Xnn1lTkkbFnuTTbaIsl14zVPV8vlQJ/Q2f1R7YJc3ILd9iu6Qroy7yyF d+FJkgoxQ3xVulEc+lQA1722L5QOsBjK8O+JGxiHR0ut2e0RlwVNZBQAKWcl1kIppTgi 2x0z9EFanDIrJxWFiOVBRhnMIOVhLF57Re0ZvGH3j+7q4SA6hV4Haq8fvHW/v61qRmam zKQhcP2hnCy6EhRE3NSdDSi6pj71sxRuVJXV46IkBuwPCqaJNazBxxeXhdtK9XAE28A4 q1rar5VjUjN/letnmHWIhSSv9TeXsDoEVDJPFCs9rY6AMNJqotZw/CsmHCUafsUjzYCu AgUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QK0nYGFUqHQWTFniaZjb4pWhF5u+zRG36OlmvbNcxZA=; b=K85xxzGX8xgksRrQZ41flKY5u7qcTIAtAfzEyL5cv89lVP4MQzdtBZvqXyYv7yOMPv Qx7EcsbbEECHzwoW+n//i/8/yPZyTxntkV5HEYq1sYLmQrEed+Z43hNPGkArO9eB8s7Q TCST7FWh8jbiabbcC9UjIfRtYKobqofIobBaSfxFf3HthvgsjNZHAG4Fl665hSdfWWfn Hx+JwXI7PvrN7qobG4UaovijmnyKfr+usdkYQ6Oy4dbEXYlNxTKNwvtY037XHyJaS86X fK9FPWtwgPvVzHB3y2Ku3KHFJ4G2qJQs79xtMR0qMrxV+qk+tEAWeZl218QpoH2yiW69 8a3Q== X-Gm-Message-State: AOAM532ruaXC0tTY9z5c9dfnLOg7Dw3H0ZXoalcCSmqmoglJf++HyEsY 2+ztdekSaGW7WHgcc/+tXewl7E88WlI= X-Google-Smtp-Source: ABdhPJzmoD8YZhYtINsMDgdK3AKcXG2TGCinOiK2YoBxHXKoeMeyzgazs5kxGBm9URIoajPiXs0Pvw== X-Received: by 2002:a5d:5144:: with SMTP id u4mr16377802wrt.30.1629757940288; Mon, 23 Aug 2021 15:32:20 -0700 (PDT) Received: from ?IPv6:2a02:8108:96c0:3b88::687e? ([2a02:8108:96c0:3b88::687e]) by smtp.gmail.com with ESMTPSA id a5sm458608wmj.30.2021.08.23.15.32.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Aug 2021 15:32:19 -0700 (PDT) Subject: Re: [PATCH] staging: r8188eu: remove ip.h header file To: Phillip Potter Cc: Greg KH , Larry Finger , Martin Kaiser , "Fabio M. De Francesco" , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List References: <20210823081820.9724-1-straube.linux@gmail.com> From: Michael Straube Message-ID: Date: Tue, 24 Aug 2021 00:31:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/21 12:21 AM, Phillip Potter wrote: > On Mon, 23 Aug 2021 at 09:19, Michael Straube wrote: >> >> The struct ip_options declared in ip.h is only unsed in the optlength >> macro which is also defined in ip.h. All other definitions/declarations >> in ip.h are duplicated from . Remove the ip.h >> header file and its includes. >> >> Signed-off-by: Michael Straube >> --- > > Dear Michael, > > Thanks for the patch. Sorry, but it seems to conflict with your > earlier patch titled: "[PATCH] staging: r8188eu: remove if_ether.h > header file". They apply fine individually, but not together - can you > confirm this is the case for you as well and not just me? > > Regards, > Phil > Hi Phillip, yes I can confirm, sorry about that. I will rework and send both patches in a series. Thank you for testing and pointing out this conflict. best regards, Michael