mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Imran Khan <imran.f.khan@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] kernfs: make ->attr.open RCU protected.
Date: Tue, 14 Jun 2022 17:20:23 +1000	[thread overview]
Message-ID: <cb8e3574-31ac-b858-81db-2b86cb75b340@oracle.com> (raw)
In-Reply-To: <Yqf+J/P1/24i6rN9@slm.duckdns.org>

Hello Tejun,

On 14/6/22 1:19 pm, Tejun Heo wrote:
> On Tue, Jun 14, 2022 at 12:08:37PM +1000, Imran Khan wrote:
>> +static struct kernfs_open_node *
[...]
> 
> Hahahaha didn't know they'd be taking two different arguments. Sorry about
> the many iterations but it'd probably be better to have two different
> versions for the two argument types. Other than that, looks fine to me.
> 

No problem. I have made the changes in v6 (at [1]) to make use of 2 helpers
based on the arguments.

Thanks
 -- Imran

[1]: https://lore.kernel.org/lkml/20220614070346.810168-1-imran.f.khan@oracle.com/

  reply	other threads:[~2022-06-14  7:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  2:08 [PATCH v5 0/4] " Imran Khan
2022-06-14  2:08 ` [PATCH v5 1/4] " Imran Khan
2022-06-14  3:19   ` Tejun Heo
2022-06-14  7:20     ` Imran Khan [this message]
2022-06-14  2:08 ` [PATCH v5 2/4] kernfs: Change kernfs_notify_list to llist Imran Khan
2022-06-14  2:08 ` [PATCH v5 3/4] kernfs: Introduce interface to access global kernfs_open_file_mutex Imran Khan
2022-06-14  2:08 ` [PATCH v5 4/4] kernfs: Replace global kernfs_open_file_mutex with hashed mutexes Imran Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb8e3574-31ac-b858-81db-2b86cb75b340@oracle.com \
    --to=imran.f.khan@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®