mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Eric Biggers <ebiggers@kernel.org>,
	Jaegeuk Kim <jaegeuk@kernel.org>, "Chao Yu" <chao@kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>
Cc: Daniel Rosenberg <drosen@google.com>,
	Gabriel Krisman Bertazi <krisman@collabora.com>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<syzkaller-bugs@googlegroups.com>,
	<syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com>
Subject: Re: [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature
Date: Fri, 9 Oct 2020 09:30:15 +0800	[thread overview]
Message-ID: <cb993e67-b947-81f9-9f0a-10d924710e5c@huawei.com> (raw)
In-Reply-To: <20201008191522.1948889-1-ebiggers@kernel.org>

On 2020/10/9 3:15, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> syzbot reported:
> 
>      general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN
>      KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
>      CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0
>      Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
>      RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107
>      [...]
>      Call Trace:
>       f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline]
>       __f2fs_setup_filename fs/f2fs/dir.c:118 [inline]
>       f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163
>       f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494
>       __lookup_hash+0x115/0x240 fs/namei.c:1445
>       filename_create+0x14b/0x630 fs/namei.c:3467
>       user_path_create fs/namei.c:3524 [inline]
>       do_mkdirat+0x56/0x310 fs/namei.c:3664
>       do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46
>       entry_SYSCALL_64_after_hwframe+0x44/0xa9
>      [...]
> 
> The problem is that an inode has F2FS_CASEFOLD_FL set, but the
> filesystem doesn't have the casefold feature flag set, and therefore
> super_block::s_encoding is NULL.
> 
> Fix this by making sanity_check_inode() reject inodes that have
> F2FS_CASEFOLD_FL when the filesystem doesn't have the casefold feature.
> 
> Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com
> Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups")
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

  parent reply	other threads:[~2020-10-09  1:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 14:59 general protection fault in utf8_casefold syzbot
2020-10-08 19:15 ` [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature Eric Biggers
2020-10-08 19:26   ` Gabriel Krisman Bertazi
2020-10-09  1:30   ` Chao Yu [this message]
2020-10-09  2:40 ` general protection fault in utf8_casefold syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb993e67-b947-81f9-9f0a-10d924710e5c@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=chao@kernel.org \
    --cc=drosen@google.com \
    --cc=ebiggers@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=krisman@collabora.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®