From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E56BC4742C for ; Wed, 11 Nov 2020 18:49:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C8D420797 for ; Wed, 11 Nov 2020 18:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbgKKStX (ORCPT ); Wed, 11 Nov 2020 13:49:23 -0500 Received: from mga09.intel.com ([134.134.136.24]:47344 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgKKStW (ORCPT ); Wed, 11 Nov 2020 13:49:22 -0500 IronPort-SDR: T1wLCwdut8NaWugLt3A4CO4/g53RGujLZM+rQiL6RuxJ8kszsdFZREtja8kMdnzK9J8E9sRo6J glRrM7pdN9Ew== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="170362578" X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="170362578" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 10:49:21 -0800 IronPort-SDR: TiF3SoCyDQmKQoegLE8eXd23N1ySpKy12U9bQ8jsLajrLqclQiB179AIUgHB41XAwFOTTWEkHw ujpi/m2viFCQ== X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="339148549" Received: from dnminiba-mobl1.amr.corp.intel.com ([10.251.19.220]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 10:49:20 -0800 Date: Wed, 11 Nov 2020 10:49:20 -0800 (PST) From: Mat Martineau To: Colin King , Jakub Kicinski cc: Matthieu Baerts , "David S . Miller" , Geliang Tang , Paolo Abeni , netdev@vger.kernel.org, mptcp@lists.01.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mptcp: fix a dereference of pointer before msk is null checked. In-Reply-To: <20201109125215.2080172-1-colin.king@canonical.com> Message-ID: References: <20201109125215.2080172-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2020, Colin King wrote: > From: Colin Ian King > > Currently the assignment of pointer net from the sock_net(sk) call > is potentially dereferencing a null pointer sk. sk points to the > same location as pointer msk and msk is being null checked after > the sock_net call. Fix this by calling sock_net after the null > check on pointer msk. > > Addresses-Coverity: ("Dereference before null check") > Fixes: 00cfd77b9063 ("mptcp: retransmit ADD_ADDR when timeout") > Signed-off-by: Colin Ian King > --- > net/mptcp/pm_netlink.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Hi Colin and Jakub - I noticed that the follow-up discussion on this patch didn't go to the netdev list, so patchwork did not get updated. This patch is superseded by the following, which already has a Reviewed-by tag from Matthieu: http://patchwork.ozlabs.org/project/netdev/patch/078a2ef5bdc4e3b2c25ef852461692001f426495.1604976945.git.geliangtang@gmail.com/ Thanks! -- Mat Martineau Intel