From: Lubomir Rintel <lkundrak@v3.sk>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name"
Date: Mon, 24 Sep 2018 14:08:13 +0200 [thread overview]
Message-ID: <cba084f2a3fc438b64ca222014ed679638aebfb1.camel@v3.sk> (raw)
In-Reply-To: <26184.1537790420@warthog.procyon.org.uk>
On Mon, 2018-09-24 at 13:00 +0100, David Howells wrote:
> Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> > This changes UAPI, breaking iwd and libell:
> >
> > ell/key.c: In function 'kernel_dh_compute':
> > ell/key.c:205:38: error: 'struct keyctl_dh_params' has no member
> > named 'private'; did you mean 'dh_private'?
> > struct keyctl_dh_params params = { .private = private,
> > ^~~~~~~
> > dh_private
> >
> > This reverts commit 8a2336e549d385bb0b46880435b411df8d8200e8.
> >
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: James Morris <jmorris@namei.org>
> > Cc: "Serge E. Hallyn" <serge@hallyn.com>
> > Cc: Mat Martineau <mathew.j.martineau@linux.intel.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: <stable@vger.kernel.org>
>
> Can I stick your Signed-off-by on it?
1. Yes, please do.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> David
prev parent reply other threads:[~2018-09-24 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 9:47 Lubomir Rintel
2018-09-24 12:00 ` David Howells
2018-09-24 12:08 ` Lubomir Rintel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba084f2a3fc438b64ca222014ed679638aebfb1.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®