From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A28DC54FCB for ; Thu, 23 Apr 2020 14:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B5522074F for ; Thu, 23 Apr 2020 14:48:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="BMVw9gHa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728804AbgDWOsM (ORCPT ); Thu, 23 Apr 2020 10:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726450AbgDWOsM (ORCPT ); Thu, 23 Apr 2020 10:48:12 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C82D9C08E934; Thu, 23 Apr 2020 07:48:11 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id C317422F99; Thu, 23 Apr 2020 16:48:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1587653286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLmBZL0FMhG+mFKlP2Ht3IzgRfKlXEzRMeQdQ+FbklY=; b=BMVw9gHa6625K6Ui86hhu5yBTBrixqKjDF/MkErR/f+ykPUOWc+923D2EJAhzY3SZQSwJC NATLzsxcUFj3zAA7qPUQpKwhO1ckB3eV+z6Qb4HppFp3BaweHTtEjzqngjmdjUX3d8gijp aRNO5cl2Zi5o1SJcnUN5hzdrVxIkWio= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Apr 2020 16:48:05 +0200 From: Michael Walle To: Colin King Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "David S . Miller" , Guenter Roeck , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: phy: bcm54140: fix less than zero comparison on an unsigned In-Reply-To: <20200423141016.19666-1-colin.king@canonical.com> References: <20200423141016.19666-1-colin.king@canonical.com> Message-ID: X-Sender: michael@walle.cc User-Agent: Roundcube Webmail/1.3.10 X-Spamd-Bar: + X-Rspamd-Server: web X-Rspamd-Queue-Id: C317422F99 X-Spamd-Result: default: False [1.40 / 15.00]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; NEURAL_HAM(-0.00)[-0.881]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[lunn.ch,gmail.com,armlinux.org.uk,davemloft.net,roeck-us.net,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2020-04-23 16:10, schrieb Colin King: > From: Colin Ian King > > Currently the unsigned variable tmp is being checked for an negative > error return from the call to bcm_phy_read_rdb and this can never > be true since tmp is unsigned. Fix this by making tmp a plain int. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 4406d36dfdf1 ("net: phy: bcm54140: add hwmon support") > Signed-off-by: Colin Ian King FWIW since Andrew already reviewed it: Reviewed-by: Michael Walle -michael