From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F912C21D8 for ; Mon, 6 Jul 2026 12:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783339263; cv=none; b=lPZKvD5k+J+mjuc3+xIw3RIYuruEqFuRrzydPzr17qAd1oiP9Fmq4GHV808I4uDXu1rajqGYSZkQ7pzh4tycecCaVsXUjSZd8P3HC/P2BZj9r98yr2y/xX8OwZ6BNFI9TJhV+Q7TM39FMN1c4vAOVztjuwkKVjyC0P3p6BPvUoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783339263; c=relaxed/simple; bh=EAlHrwhetPy5UUC3W8aIh5wf5YgWxz04Rg10+M4pvug=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=hHqXSqNE3+hGjTXdUBFyjQQgSaBLnprRNAKE9i1oOe2OM5VzSPwG4oto35l3nmJWNDQqxTLAYkSYmrNUCrIoNdn5CVOIGbuttFcyTruwHWKxHbdVnK41TPQTBxFLXo700cQOxpDMNi9YAHhj7ALJx3PkJ8ZSQCpz3uTE4+SM0Ps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Oj1iMQPw; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Oj1iMQPw" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493c00f74baso17995095e9.0 for ; Mon, 06 Jul 2026 05:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783339260; x=1783944060; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=fprC08uNeLBQCAiE9ZHVQcO4Xl64TZSly/5LDUMpKCs=; b=Oj1iMQPw7xpYSXItOqRWr/n6qemHggsm13KqJ2SokgtGuiAcpaeyWp7LLQMsBOcbp2 6PK55C5AAcr0vzLCUt/QoJFj0bMUqyu7KF9jtcf9MHfm3tBBjABTGmN8WQTn9cD+KpdU 6zTH2D3Nfmg7mvGfDpR/UimTBTufaW7AY0L/OcVXeXbHlszjqVljooKbQMnaTfSwctaC 1XGcWV6VguhM6XsLNkFJCH4kjZIoRUYsZIMC1A9XWRHgwo2D/AG2knuM5kgdWUl99GIM myO0igsRg42UY/nZ53uJI5LY5EM2FPxTzByIl/Ot2wkQYxtDwRnSdHKVxLjKsXAeww9F f9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783339260; x=1783944060; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fprC08uNeLBQCAiE9ZHVQcO4Xl64TZSly/5LDUMpKCs=; b=p7grbRivascqJG+u2u6OZG7CXkDEKK9572JAiZGGQB2EX9X0yEwhUB1I22FlnVGB57 iaJ3MI2rTQZUPAQ9J2ge+f5PpMqoiPtgR/rJSPGBxbA1cVfk0TwsSTQitK0O/r6xo/5n UJnkIAl6LfZASe3yEXup7ooAY46HIGnpo2naLkMwOxCRf2nCO0/5iA4UQED+LKBRNdu9 semIpCK5OUfJGFuMsXAs2Dp9DGjnxKKK0zB22ZSrqFwLkfKvmKd4spTgVPvFD2564QUi Tq5vNF9w4/tmvF1ygvCrLamfHpepiiWtsdQDecXf7gqmbv/PCLsI0ggJt/l+MiyOYoPE R3bg== X-Forwarded-Encrypted: i=1; AHgh+RrooIjPaD4AlXe+yFZdcuxHduxMAnHgVnX31HZ53w0+BGwHes3ec0MDMlo419OpuXRcfZesa3ZvRi+WxTs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgj0xLp5fVtlyplXgF47fS25srlUdmy3JlcjqEGz6MbyeGxWMp fzlyYD7mGMSaJiI6AUnL2VZMzbNLANKDBUr2rpKofNi+O1cLW4mS+D7spUIqPBIyBUc= X-Gm-Gg: AfdE7cm+7SDlB/oUoiLEktB6KWszINkmaMjbiWe1cyiM8qsl3tCCYHNJAzqayTPJACZ NLTvVSU3qTml2DIARZuMbt2negFYzSVwWababM6XXaI96ZXr820nUv9u9PzWybnihU2Ee2g3PTT 6Njd4e5y9jnDH4RVt//P2UdsANOsDaN993Yuh1NdqAQ/SUWqRgF2OdMPu4de81Od1uuhCPSwKk0 yc3leuDVHUtljposk2TDMwml28YfxQL0xmlWrqyY0LVjxMcDA1C7YxUM9p/AXVnLnphEj6v3bMc 99M2fRqTitAQXwjs7nKor1qJZnUBf4LVVJmBfrpw/CoBo/6tZ15aF+/vJtmAoSArmdJW5Z46i/t JSxls/EO1UN2/h46IlEoXDfmmoo3JjtKqiJQugVHawiM0qPVth1z/w7wy5yCAUCexOvDmPYNvRw JoyAQ3acCu//3i/xxppBYQ8DFP9S3JHHpYnnbQRcRNlRpytCpig57LKMA= X-Received: by 2002:a05:600c:540e:b0:492:437a:a653 with SMTP id 5b1f17b1804b1-493df0aea9dmr865725e9.26.1783339260467; Mon, 06 Jul 2026 05:01:00 -0700 (PDT) Received: from ?IPV6:2001:a61:136f:7201:4a82:7cef:c61f:a3f3? ([2001:a61:136f:7201:4a82:7cef:c61f:a3f3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f21328sm24625159f8f.32.2026.07.06.05.00.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 05:00:59 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 14:00:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/4] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet To: Manuel Ebner , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shaoxul@foxmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260702143142.890654-1-oneukum@suse.com> <20260702143142.890654-3-oneukum@suse.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 02.07.26 20:19, Manuel Ebner wrote: > On Thu, 2026-07-02 at 16:25 +0200, Oliver Neukum wrote: >> >> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c >> index 5544af1f4aa5..7beea6d0e731 100644 >> --- a/drivers/net/usb/usbnet.c >> +++ b/drivers/net/usb/usbnet.c >> @@ -2347,6 +2347,25 @@ void usbnet_cdc_status(struct usbnet *dev, struct urb *urb) >>   } >>  } >>  EXPORT_SYMBOL_GPL(usbnet_cdc_status); >> + >> +/* Make sure packets have correct destination MAC address > /* > * Make sure packets have the correct destination MAC address This sort of puts me into a conundrum. Does networking code use the short style of comments or not? The documentation says that it does. I am fine either way, but I need a clear rule. >> + * >> + * A firmware bug observed on some devices (ZTE MF823/831/910) is that the >> + * device sends packets with a static, bogus, random MAC address (event if > > (even if the device ... Understood > >> + * device MAC address has been updated). Always set MAC address to that of the >> + * device. > > Always set the MAC address to the one of your device. Understood Regards Oliver