From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5558FC47097 for ; Thu, 3 Jun 2021 10:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A81E60FE7 for ; Thu, 3 Jun 2021 10:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbhFCKyv (ORCPT ); Thu, 3 Jun 2021 06:54:51 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:7090 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhFCKys (ORCPT ); Thu, 3 Jun 2021 06:54:48 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FwjN86jZlzYqK7; Thu, 3 Jun 2021 18:50:16 +0800 (CST) Received: from dggpemm500009.china.huawei.com (7.185.36.225) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 18:53:02 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm500009.china.huawei.com (7.185.36.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 18:53:01 +0800 Subject: Re: [PATCH -next] crypto: algboss - Replaced simple_strtol() with kstrtouint() To: Herbert Xu , Eric Biggers References: <20210524120834.1580343-1-liushixin2@huawei.com> <20210603081238.GA1160@gondor.apana.org.au> CC: "David S. Miller" , , From: Liu Shixin Message-ID: Date: Thu, 3 Jun 2021 18:53:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20210603081238.GA1160@gondor.apana.org.au> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500009.china.huawei.com (7.185.36.225) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/3 16:12, Herbert Xu wrote: > On Mon, May 24, 2021 at 02:57:50PM -0700, Eric Biggers wrote: >> It would be better to just remove all the code related to CRYPTOA_U32 and >> crypto_attr_u32, as it is never used. > I agree, it's been unused for over a decade. > > Thanks, Thank you both for the advice, I will fix it. Besides, I noticed that type CRYPTOA_UNSPEC has never been used, should I remove it together? Thanks,