mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Mario Limonciello <mario.limonciello@amd.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
	<linux-rtc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	linux-pm@vger.kernel.org, tobrohl@gmail.com, aalsing@gmail.com,
	Dhaval.Giani@amd.com, xmb8dsv4@gmail.com, x86@kernel.org,
	dhaval.giani@gmail.com
Subject: Re: [PATCH v2 0/4] Extend time to wait for UIP for some callers
Date: Wed, 22 Nov 2023 17:58:07 +0100	[thread overview]
Message-ID: <cbb60eed-a835-4ee7-a43d-e871c16713e1@o2.pl> (raw)
In-Reply-To: <20231120141555.458-1-mario.limonciello@amd.com>

W dniu 20.11.2023 o 15:15, Mario Limonciello pisze:
> A number of users have reported their system will have a failure reading
> the RTC around s2idle entry or exit.
>
> This failure manifests as UIP clear taking longer than 10ms.
>
> By a debugging patch provided by Mateusz Jończyk it is shown that this
> has taken upwards of 300ms in some cases.
>
> This series adjusts the UIP timeout to be configurable by the caller and
> changes some callers which aren't called in an interrupt context to allow
> longer timeouts.
>
> Mario Limonciello (4):
>   rtc: mc146818-lib: Adjust failure return code for mc146818_get_time()
>   rtc: Adjust failure return code for cmos_set_alarm()
>   rtc: Add support for configuring the UIP timeout for RTC reads
>   rtc: Extend timeout for waiting for UIP to clear to 1s

Series tested on top of Linux 6.1.63, 6.6.2 and 6.7-rc2
(on a laptop that is not affected by the problems).
No problems found, can be submitted to stable.

Tested-by: Mateusz Jończyk <mat.jonczyk@o2.pl>

Patches 1 and 2:

Reviewed-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Acked-by: Mateusz Jończyk <mat.jonczyk@o2.pl>

Greetings,

Mateusz


  parent reply	other threads:[~2023-11-22 16:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 14:15 Mario Limonciello
2023-11-20 14:15 ` [PATCH v2 1/4] rtc: mc146818-lib: Adjust failure return code for mc146818_get_time() Mario Limonciello
2023-11-20 14:15 ` [PATCH v2 2/4] rtc: Adjust failure return code for cmos_set_alarm() Mario Limonciello
2023-11-20 14:15 ` [PATCH v2 3/4] rtc: Add support for configuring the UIP timeout for RTC reads Mario Limonciello
2023-11-22 17:06   ` Mateusz Jończyk
2023-11-20 14:15 ` [PATCH v2 4/4] rtc: Extend timeout for waiting for UIP to clear to 1s Mario Limonciello
2023-11-22 17:16   ` Mateusz Jończyk
2023-11-22 16:58 ` Mateusz Jończyk [this message]
2023-11-23  8:31 ` [PATCH v2 0/4] Extend time to wait for UIP for some callers Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbb60eed-a835-4ee7-a43d-e871c16713e1@o2.pl \
    --to=mat.jonczyk@o2.pl \
    --cc=Dhaval.Giani@amd.com \
    --cc=a.zummo@towertech.it \
    --cc=aalsing@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=dhaval.giani@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=tobrohl@gmail.com \
    --cc=x86@kernel.org \
    --cc=xmb8dsv4@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®