mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Asaf Nuri Bertizlioğlu" <asafbertizlioglu@gmail.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (coretemp) Remove unused for_each_sibling() and name_attr
Date: Fri, 20 Nov 2026 11:26:00 -0800	[thread overview]
Message-ID: <cbb8f3b5-e2f5-4bc0-97f1-c77f897fb698@roeck-us.net> (raw)
In-Reply-To: <20261120165926.579575-1-asafbertizlioglu@gmail.com>

On Fri, Nov 20, 2026 at 07:59:26PM +0300, Asaf Nuri Bertizlioğlu wrote:
> The for_each_sibling() macro lost its only user in commit
> e1b370b64031 ("hwmon: (coretemp) Simplify sibling management").
> 
> The name_attr member of struct platform_data has been unused since
> commit d72d19c26c41 ("hwmon: (coretemp) Convert to use
> devm_hwmon_device_register_with_groups"), which left the "name"
> attribute to the hwmon core.
> 
> Remove both. No functional change.
> 
> Built with CONFIG_SMP=y and CONFIG_SMP=n at W=1 with no new
> warnings. Apart from the struct platform_data allocation size,
> which shrinks from 88 to 56 bytes, the generated code is unchanged.
> 
> The unused definitions were found with an LLM-based coding assistant,
> which also drafted this changelog. Both findings were confirmed with
> gcc -Wunused-macros, git grep and the git history.
> 
> Signed-off-by: Asaf Nuri Bertizlioğlu <asafbertizlioglu@gmail.com>

Applied.

Thanks,
Guenter

      reply	other threads:[~2026-11-20 19:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 16:59 Asaf Nuri Bertizlioğlu
2026-11-20 19:26 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbb8f3b5-e2f5-4bc0-97f1-c77f897fb698@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=asafbertizlioglu@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®